From ea6aff8079b7cecf011ae266ee93261d296d414e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Jamr=C3=B3z?= Date: Tue, 18 Jun 2024 13:44:23 +0200 Subject: [PATCH] CI: Fix release-npm-packages action (#89284) Remove redundant git checkout --- .drone.yml | 4 ++-- pkg/build/cmd/npm.go | 7 ------- scripts/drone/events/release.star | 2 +- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.drone.yml b/.drone.yml index 5bdf545df46..27d0c0324f6 100644 --- a/.drone.yml +++ b/.drone.yml @@ -2670,7 +2670,7 @@ steps: NPM_TOKEN: from_secret: npm_token failure: ignore - image: golang:1.21.10-alpine + image: node:18.12.0-alpine name: release-npm-packages trigger: event: @@ -4607,6 +4607,6 @@ kind: secret name: gcr_credentials --- kind: signature -hmac: 006c79befa5fdfb008b79047e1b4174e4df631d9b77d55021d6195a5bc2ca7ef +hmac: ca7643a4737afad897d5002fa877bf31a1f60c25e976b977af608624df745b88 ... diff --git a/pkg/build/cmd/npm.go b/pkg/build/cmd/npm.go index 13994fb4e19..ba35679f57a 100644 --- a/pkg/build/cmd/npm.go +++ b/pkg/build/cmd/npm.go @@ -3,7 +3,6 @@ package main import ( "fmt" "os" - "os/exec" "strings" "github.com/urfave/cli/v2" @@ -74,12 +73,6 @@ func NpmReleaseAction(c *cli.Context) error { return fmt.Errorf("no tag version specified, exitting") } - cmd := exec.Command("git", "checkout", ".") - if err := cmd.Run(); err != nil { - fmt.Println("command failed to run, err: ", err) - return err - } - err := npm.PublishNpmPackages(c.Context, tag) if err != nil { return err diff --git a/scripts/drone/events/release.star b/scripts/drone/events/release.star index 5e71f1eed04..cdf8c9883c0 100644 --- a/scripts/drone/events/release.star +++ b/scripts/drone/events/release.star @@ -62,7 +62,7 @@ def retrieve_npm_packages_step(): def release_npm_packages_step(): return { "name": "release-npm-packages", - "image": images["go"], + "image": images["node"], "depends_on": [ "compile-build-cmd", "retrieve-npm-packages",