E2E: Do not skip visualization suggestions (#40955)

* E2E: Do not skip visualization suggestions 

Was disabled because drone performance is so varied that it sometimes completes and sometimes needs a lot more time, trying to increase wait time and see if that helps.

* Made it possible to go directly to panel edit

* Fixes
This commit is contained in:
Torkel Ödegaard
2021-10-28 09:56:21 +02:00
committed by GitHub
parent 7521d56cec
commit eabaa3af2d
5 changed files with 15 additions and 20 deletions
@@ -8,6 +8,7 @@ interface OpenDashboardDefault {
interface OpenDashboardOptional {
timeRange?: TimeRangeConfig;
queryParams?: object;
}
export type PartialOpenDashboardConfig = Partial<OpenDashboardDefault> & OpenDashboardOptional;
@@ -21,9 +22,9 @@ export const openDashboard = (config?: PartialOpenDashboardConfig) =>
...config,
};
const { timeRange, uid } = fullConfig;
const { timeRange, uid, queryParams } = fullConfig;
e2e.pages.Dashboard.visit(uid);
e2e.pages.Dashboard.visit(uid, queryParams);
if (timeRange) {
setDashboardTimeRange(timeRange);
+7 -3
View File
@@ -3,7 +3,7 @@ import { e2e } from '../index';
import { Selector } from './selector';
import { fromBaseUrl } from './url';
export type VisitFunction = (args?: string) => Cypress.Chainable<Window>;
export type VisitFunction = (args?: string, queryParams?: object) => Cypress.Chainable<Window>;
export type E2EVisit = { visit: VisitFunction };
export type E2EFunction = ((text?: string, options?: CypressOptions) => Cypress.Chainable<JQuery<HTMLElement>>) &
E2EFunctionWithOnlyOptions;
@@ -40,7 +40,7 @@ const processSelectors = <S extends Selectors>(e2eObjects: E2EFunctions<S>, sele
if (key === 'url') {
// @ts-ignore
e2eObjects['visit'] = (args?: string) => {
e2eObjects['visit'] = (args?: string, queryParams?: object) => {
let parsedUrl = '';
if (typeof value === 'string') {
parsedUrl = fromBaseUrl(value);
@@ -51,7 +51,11 @@ const processSelectors = <S extends Selectors>(e2eObjects: E2EFunctions<S>, sele
}
e2e().logToConsole('Visiting', parsedUrl);
return e2e().visit(parsedUrl);
if (queryParams) {
return e2e().visit({ url: parsedUrl, qs: queryParams });
} else {
return e2e().visit(parsedUrl);
}
};
continue;