From eb8b6a5a707ae47bff3b8808f09cef03f6dd6ca3 Mon Sep 17 00:00:00 2001
From: Juan Cabanas <juan.cabanas@grafana.com>
Date: Thu, 29 Aug 2024 15:31:28 -0300
Subject: [PATCH] ShareDrawer: Wording and defaults improvements (#92629)

---
 .../dashboard-scene/sharing/ShareButton/ShareButton.tsx     | 2 +-
 .../dashboard-scene/sharing/ShareButton/ShareMenu.tsx       | 2 +-
 .../ShareButton/share-internally/ShareInternally.tsx        | 3 ++-
 public/locales/en-US/grafana.json                           | 6 +++---
 public/locales/pseudo-LOCALE/grafana.json                   | 6 +++---
 5 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx b/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx
index cc7518fc85f..0d8363c9d1b 100644
--- a/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx
+++ b/public/app/features/dashboard-scene/sharing/ShareButton/ShareButton.tsx
@@ -36,7 +36,7 @@ export default function ShareButton({ dashboard, panel }: { dashboard: Dashboard
       <Button
         data-testid={newShareButtonSelector.shareLink}
         size="sm"
-        tooltip={t('share-dashboard.share-button-tooltip', 'Copy shortened link')}
+        tooltip={t('share-dashboard.share-button-tooltip', 'Copy link')}
         onClick={buildUrl}
       >
         <Trans i18nKey="share-dashboard.share-button">Share</Trans>
diff --git a/public/app/features/dashboard-scene/sharing/ShareButton/ShareMenu.tsx b/public/app/features/dashboard-scene/sharing/ShareButton/ShareMenu.tsx
index b899bb92904..3735dd068c8 100644
--- a/public/app/features/dashboard-scene/sharing/ShareButton/ShareMenu.tsx
+++ b/public/app/features/dashboard-scene/sharing/ShareButton/ShareMenu.tsx
@@ -43,7 +43,7 @@ export default function ShareMenu({ dashboard, panel }: { dashboard: DashboardSc
       testId: newShareButtonSelector.shareInternally,
       icon: 'building',
       label: t('share-dashboard.menu.share-internally-title', 'Share internally'),
-      description: t('share-dashboard.menu.share-internally-description', 'Advanced settings'),
+      description: t('share-dashboard.menu.share-internally-description', 'Link settings'),
       renderCondition: true,
       onClick: () => onMenuItemClick(shareDashboardType.link),
     });
diff --git a/public/app/features/dashboard-scene/sharing/ShareButton/share-internally/ShareInternally.tsx b/public/app/features/dashboard-scene/sharing/ShareButton/share-internally/ShareInternally.tsx
index 5fc5e6c8be4..fb29868b59e 100644
--- a/public/app/features/dashboard-scene/sharing/ShareButton/share-internally/ShareInternally.tsx
+++ b/public/app/features/dashboard-scene/sharing/ShareButton/share-internally/ShareInternally.tsx
@@ -68,7 +68,8 @@ function ShareInternallyRenderer({ model }: SceneComponentProps<ShareInternally>
     <>
       <Alert severity="info" title={t('link.share.config-alert-title', 'Link configuration')}>
         <Trans i18nKey="link.share.config-alert-description">
-          Updating your settings will modify the default copy link to include these changes.
+          Updating your settings will modify the default copy link to include these changes. Please note that these
+          settings are saved within your current browser scope.
         </Trans>
       </Alert>
       <div className={styles.configDescription}>
diff --git a/public/locales/en-US/grafana.json b/public/locales/en-US/grafana.json
index c33b57d1979..ddb0abacdda 100644
--- a/public/locales/en-US/grafana.json
+++ b/public/locales/en-US/grafana.json
@@ -1162,7 +1162,7 @@
   },
   "link": {
     "share": {
-      "config-alert-description": "Updating your settings will modify the default copy link to include these changes.",
+      "config-alert-description": "Updating your settings will modify the default copy link to include these changes. Please note that these settings are saved within your current browser scope.",
       "config-alert-title": "Link configuration",
       "config-description": "Create a personalized, direct link to share your dashboard within your organization, with the following customization settings:",
       "copy-link-button": "Copy link",
@@ -2228,12 +2228,12 @@
     "menu": {
       "export-json-title": "Export as JSON",
       "share-externally-title": "Share externally",
-      "share-internally-description": "Advanced settings",
+      "share-internally-description": "Link settings",
       "share-internally-title": "Share internally",
       "share-snapshot-title": "Share snapshot"
     },
     "share-button": "Share",
-    "share-button-tooltip": "Copy shortened link"
+    "share-button-tooltip": "Copy link"
   },
   "share-drawer": {
     "confirm-action": {
diff --git a/public/locales/pseudo-LOCALE/grafana.json b/public/locales/pseudo-LOCALE/grafana.json
index 195424cf456..bc7da0abbdb 100644
--- a/public/locales/pseudo-LOCALE/grafana.json
+++ b/public/locales/pseudo-LOCALE/grafana.json
@@ -1162,7 +1162,7 @@
   },
   "link": {
     "share": {
-      "config-alert-description": "Ůpđäŧįʼnģ yőūř şęŧŧįʼnģş ŵįľľ mőđįƒy ŧĥę đęƒäūľŧ čőpy ľįʼnĸ ŧő įʼnčľūđę ŧĥęşę čĥäʼnģęş.",
+      "config-alert-description": "Ůpđäŧįʼnģ yőūř şęŧŧįʼnģş ŵįľľ mőđįƒy ŧĥę đęƒäūľŧ čőpy ľįʼnĸ ŧő įʼnčľūđę ŧĥęşę čĥäʼnģęş. Pľęäşę ʼnőŧę ŧĥäŧ ŧĥęşę şęŧŧįʼnģş äřę şävęđ ŵįŧĥįʼn yőūř čūřřęʼnŧ þřőŵşęř şčőpę.",
       "config-alert-title": "Ŀįʼnĸ čőʼnƒįģūřäŧįőʼn",
       "config-description": "Cřęäŧę ä pęřşőʼnäľįžęđ, đįřęčŧ ľįʼnĸ ŧő şĥäřę yőūř đäşĥþőäřđ ŵįŧĥįʼn yőūř őřģäʼnįžäŧįőʼn, ŵįŧĥ ŧĥę ƒőľľőŵįʼnģ čūşŧőmįžäŧįőʼn şęŧŧįʼnģş:",
       "copy-link-button": "Cőpy ľįʼnĸ",
@@ -2228,12 +2228,12 @@
     "menu": {
       "export-json-title": "Ēχpőřŧ äş ĴŜØŃ",
       "share-externally-title": "Ŝĥäřę ęχŧęřʼnäľľy",
-      "share-internally-description": "Åđväʼnčęđ şęŧŧįʼnģş",
+      "share-internally-description": "Ŀįʼnĸ şęŧŧįʼnģş",
       "share-internally-title": "Ŝĥäřę įʼnŧęřʼnäľľy",
       "share-snapshot-title": "Ŝĥäřę şʼnäpşĥőŧ"
     },
     "share-button": "Ŝĥäřę",
-    "share-button-tooltip": "Cőpy şĥőřŧęʼnęđ ľįʼnĸ"
+    "share-button-tooltip": "Cőpy ľįʼnĸ"
   },
   "share-drawer": {
     "confirm-action": {