From eba83d89733dcf0184196795ad8c2cefb3e91d49 Mon Sep 17 00:00:00 2001 From: Ryan McKinley Date: Fri, 22 Aug 2025 20:44:19 +0300 Subject: [PATCH] feedback --- pkg/registry/apis/datasource/plugincontext.go | 4 ++-- pkg/registry/apis/datasource/register.go | 2 +- pkg/registry/apis/datasource/sub_query_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/registry/apis/datasource/plugincontext.go b/pkg/registry/apis/datasource/plugincontext.go index 8648b2cbaab..8774951e694 100644 --- a/pkg/registry/apis/datasource/plugincontext.go +++ b/pkg/registry/apis/datasource/plugincontext.go @@ -31,7 +31,7 @@ type PluginDatasourceProvider interface { UpdateDataSource(ctx context.Context, ds *datasourceV0.DataSource) (*datasourceV0.DataSource, error) // Delete a data source (any type) - Delete(ctx context.Context, uid string) error + DeleteDataSource(ctx context.Context, uid string) error // Return settings (decrypted!) for a specific plugin // This will require "query" permission for the user in context @@ -130,7 +130,7 @@ func (q *scopedDatasourceProvider) UpdateDataSource(ctx context.Context, ds *dat } // Delete implements PluginDatasourceProvider. -func (q *scopedDatasourceProvider) Delete(ctx context.Context, uid string) error { +func (q *scopedDatasourceProvider) DeleteDataSource(ctx context.Context, uid string) error { user, err := identity.GetRequester(ctx) if err != nil { return err diff --git a/pkg/registry/apis/datasource/register.go b/pkg/registry/apis/datasource/register.go index 746cd1e4fc3..06afd325d6f 100644 --- a/pkg/registry/apis/datasource/register.go +++ b/pkg/registry/apis/datasource/register.go @@ -173,7 +173,7 @@ func (b *DataSourceAPIBuilder) GetGroupVersion() schema.GroupVersion { func addKnownTypes(scheme *runtime.Scheme, gv schema.GroupVersion) { scheme.AddKnownTypes(gv, - &datasourceV0.DataSource{}, // or AddKnownTypeWithName? + &datasourceV0.DataSource{}, &datasourceV0.DataSourceList{}, &datasourceV0.HealthCheckResult{}, &unstructured.Unstructured{}, diff --git a/pkg/registry/apis/datasource/sub_query_test.go b/pkg/registry/apis/datasource/sub_query_test.go index 6147a704cb6..57aa7626aba 100644 --- a/pkg/registry/apis/datasource/sub_query_test.go +++ b/pkg/registry/apis/datasource/sub_query_test.go @@ -133,7 +133,7 @@ func (m mockDatasources) UpdateDataSource(ctx context.Context, ds *v0alpha1.Data } // Delete implements PluginDatasourceProvider. -func (m mockDatasources) Delete(ctx context.Context, uid string) error { +func (m mockDatasources) DeleteDataSource(ctx context.Context, uid string) error { return nil }