Table: Enable tableNextGen by default (#109832)

* Table: Enable tableNextGen by default

* kill off tableNextGen feature flag

* i18n

* i18n

* i18n

* remove state beta from table panel

* fix migration for 0 decimals migration

* add explicit auto option bacjk

* match impl from previous migrations code

* try changing some selectors

* remove timezone test from Cypress

* fix PlaylistForm unit test

* fix some selectors

* clean up i18n, are these gridcells somehow?

* return a couple of selectors caught in the dragnet to being cell instead of gridcell

* fix i18n for en-US

* clean up gdevs now that wrapHeaderText has no default

* update role in e2e for when it is re-enabled
This commit is contained in:
Paul Marbach
2025-08-26 17:25:16 -04:00
committed by GitHub
parent 1c13f4a0f2
commit ec38e0bd58
60 changed files with 253 additions and 2650 deletions
@@ -4,7 +4,6 @@ import testDashboard from '../dashboards/DashboardLiveTest.json';
test.use({
featureToggles: {
tableNextGen: true,
kubernetesDashboards: process.env.KUBERNETES_DASHBOARDS === 'true',
},
});
@@ -51,7 +51,7 @@ test.describe(
.getByGrafanaSelector(selectors.components.Panels.Panel.title(title))
.getByRole('row')
.nth(1)
.getByRole('cell')
.getByRole('gridcell')
.first();
const time = await timeCell.textContent();
if (time) {
@@ -79,7 +79,7 @@ test.describe(
.getByGrafanaSelector(selectors.components.Panels.Panel.title(title))
.getByRole('row')
.nth(1)
.getByRole('cell')
.getByRole('gridcell')
.first();
await expect(async () => {
const inUtc = timesInUtc[title];
@@ -2,12 +2,6 @@ import { test, expect } from '@grafana/plugin-e2e';
const DASHBOARD_ID = 'P2jR04WVk';
test.use({
featureToggles: {
tableNextGen: true,
},
});
test.describe(
'Panels test: Geomap spatial operations',
{
@@ -2,12 +2,6 @@ import { test, expect } from '@grafana/plugin-e2e';
const PANEL_UNDER_TEST = 'Lines 500 data points';
test.use({
featureToggles: {
tableNextGen: true,
},
});
test.describe(
'Panels test: Panel edit base',
{
@@ -4,7 +4,7 @@ import { test, expect, E2ESelectorGroups } from '@grafana/plugin-e2e';
const DASHBOARD_UID = 'dcb9f5e9-8066-4397-889e-864b99555dbb';
test.use({ viewport: { width: 2000, height: 1080 }, featureToggles: { tableNextGen: true } });
test.use({ viewport: { width: 2000, height: 1080 } });
// helper utils
const waitForTableLoad = async (loc: Page | Locator) => {
@@ -2,9 +2,6 @@ import { test, expect } from '@grafana/plugin-e2e';
test.use({
viewport: { width: 1280, height: 1080 },
featureToggles: {
tableNextGen: true,
},
});
test.describe(
@@ -1,6 +1,6 @@
import { test, expect } from '@grafana/plugin-e2e';
test.use({ viewport: { width: 1280, height: 1080 }, featureToggles: { tableNextGen: true } });
test.use({ viewport: { width: 1280, height: 1080 } });
test.describe('Panels test: Table - Sparkline', { tag: ['@panels', '@table'] }, () => {
test('Tests sparkline tables are successfully rendered', async ({ gotoDashboardPage, selectors, page }) => {
@@ -38,7 +38,7 @@ test.describe(
formatExpectError('Could not locate header elements in table panel')
).toContainText(['col1', 'col2']);
await expect(
panelEditPage.panel.data,
panelEditPage.panel.locator.getByRole('gridcell'),
formatExpectError('Could not locate headers in table panel')
).toContainText(['val1', 'val2', 'val3', 'val4']);
});
@@ -58,7 +58,7 @@ test.describe(
formatExpectError('Could not locate header elements in table panel')
).toContainText(['col1', 'col2']);
await expect(
panelEditPage.panel.data,
panelEditPage.panel.locator.getByRole('gridcell'),
formatExpectError('Could not locate data elements in table panel')
).toContainText(['val1', 'val2', 'val3', 'val4']);
});
@@ -11,12 +11,6 @@ const STANDARD_OTIONS_CATEGORY = 'Standard options';
const DISPLAY_NAME_LABEL = 'Display name';
const REACT_TABLE_DASHBOARD = { uid: 'U_bZIMRMk' };
test.use({
featureToggles: {
tableNextGen: true,
},
});
test.describe(
'plugin-e2e-api-tests admin',
{
@@ -190,7 +190,7 @@ test.describe(
await expect(panel).toBeVisible();
// Check the table cells in the panel
const panelCells = panel.locator('[role="table"] [role="cell"]');
const panelCells = panel.locator('[role="gridcell"]');
// Should have 3 columns
await expect(panelCells).toHaveCount(3);
@@ -198,7 +198,7 @@ test.describe(
await expect(page.getByText('"wave":-0.5877852522916832')).toBeVisible();
// Column has correct value of "targetLabelValue"
await expect(panel.locator('[role="table"] [role="cell"]').filter({ hasText: 'targetLabelValue' })).toBeVisible();
await expect(panel.locator('[role="gridcell"]').filter({ hasText: 'targetLabelValue' })).toBeVisible();
});
}
);
@@ -1,11 +1,5 @@
import { test, expect } from '@grafana/plugin-e2e';
test.use({
featureToggles: {
tableNextGen: true,
},
});
test.describe(
'Visualization suggestions',
{