Split preference store (#46843)

* Split preference store * Chore: Add tests to pref * Fix preference in wire * Rename and adjust * Add pref service test * Rename methods, add tests * Rename Preferences to Preference, names IDs correctly * Fix lint * Refactor Save * Refactor upsert Add new logic for QueryHistory Rename some fields according to go naming conventions Refactore tests * Roll back ID that breaks tests * Rename Id to ID in UpdatePreferenceQuery * Use preference as a model to modify store * Move pref store fakes to pref test file * Add integration tag for store tests * Adjust test Co-authored-by: yangkb09 <yangkb09@gmail.com>
2022-04-14 14:22:00 +02:00
parent 060ccacbf9
commit ecd6cd4a92
8 changed files with 1054 additions and 1 deletions
@@ -0,0 +1,88 @@
+package prefimpl
+
+import (
+	"context"
+	"strings"
+
+	pref "github.com/grafana/grafana/pkg/services/preference"
+	"github.com/grafana/grafana/pkg/services/sqlstore"
+	"github.com/grafana/grafana/pkg/services/sqlstore/db"
+)
+
+type store interface {
+	Get(context.Context, *pref.Preference) (*pref.Preference, error)
+	List(context.Context, *pref.Preference) ([]*pref.Preference, error)
+	Insert(context.Context, *pref.Preference) (int64, error)
+	Update(context.Context, *pref.Preference) error
+}
+
+type sqlStore struct {
+	db db.DB
+}
+
+func (s *sqlStore) Get(ctx context.Context, query *pref.Preference) (*pref.Preference, error) {
+	var prefs pref.Preference
+	err := s.db.WithDbSession(ctx, func(sess *sqlstore.DBSession) error {
+		exist, err := sess.Where("org_id=? AND user_id=? AND team_id=?", query.OrgID, query.UserID, query.TeamID).Get(&prefs)
+		if err != nil {
+			return err
+		}
+		if !exist {
+			return pref.ErrPrefNotFound
+		}
+		return nil
+	})
+	if err != nil {
+		return nil, err
+	}
+	return &prefs, nil
+}
+
+func (s *sqlStore) List(ctx context.Context, query *pref.Preference) ([]*pref.Preference, error) {
+	prefs := make([]*pref.Preference, 0)
+	params := make([]interface{}, 0)
+	filter := ""
+
+	if len(query.Teams) > 0 {
+		filter = "(org_id=? AND team_id IN (?" + strings.Repeat(",?", len(query.Teams)-1) + ")) OR "
+		params = append(params, query.OrgID)
+		for _, v := range query.Teams {
+			params = append(params, v)
+		}
+	}
+
+	filter += "(org_id=? AND user_id=? AND team_id=0) OR (org_id=? AND team_id=0 AND user_id=0)"
+	params = append(params, query.OrgID)
+	params = append(params, query.UserID)
+	params = append(params, query.OrgID)
+
+	err := s.db.WithDbSession(ctx, func(dbSession *sqlstore.DBSession) error {
+		err := dbSession.Where(filter, params...).
+			OrderBy("user_id ASC, team_id ASC").
+			Find(&prefs)
+
+		if err != nil {
+			return err
+		}
+
+		return nil
+	})
+	return prefs, err
+}
+
+func (s *sqlStore) Update(ctx context.Context, cmd *pref.Preference) error {
+	return s.db.WithTransactionalDbSession(ctx, func(sess *sqlstore.DBSession) error {
+		_, err := sess.ID(cmd.ID).AllCols().Update(cmd)
+		return err
+	})
+}
+
+func (s *sqlStore) Insert(ctx context.Context, cmd *pref.Preference) (int64, error) {
+	var ID int64
+	var err error
+	err = s.db.WithTransactionalDbSession(ctx, func(sess *sqlstore.DBSession) error {
+		ID, err = sess.Insert(cmd)
+		return err
+	})
+	return ID, err
+}