From ed5b6179ac4cf51ba09440b6bbd8bbed829e1e0f Mon Sep 17 00:00:00 2001 From: Konrad Lalik Date: Mon, 26 Aug 2024 12:21:41 +0200 Subject: [PATCH] [v11.1.x] Alerting: Fix invalid loading condition for vanilla Prometheus rules (#92398) Alerting: Fix invalid loading condition for vanilla Prometheus rules (#92390) Remove invalid loading condition (cherry picked from commit 30035b23674cba6fc8985e1230b61ccdd807183d) --- .../features/alerting/unified/hooks/useCombinedRule.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/public/app/features/alerting/unified/hooks/useCombinedRule.ts b/public/app/features/alerting/unified/hooks/useCombinedRule.ts index 705ee589e62..006c3ecefc9 100644 --- a/public/app/features/alerting/unified/hooks/useCombinedRule.ts +++ b/public/app/features/alerting/unified/hooks/useCombinedRule.ts @@ -204,12 +204,7 @@ export function useCombinedRule({ ruleIdentifier }: { ruleIdentifier: RuleIdenti const [ fetchRulerRuleGroup, - { - currentData: rulerRuleGroup, - isLoading: isLoadingRulerGroup, - error: rulerRuleGroupError, - isUninitialized: rulerRuleGroupUninitialized, - }, + { currentData: rulerRuleGroup, isLoading: isLoadingRulerGroup, error: rulerRuleGroupError }, ] = alertRuleApi.endpoints.rulerRuleGroup.useLazyQuery(); useEffect(() => { @@ -251,7 +246,7 @@ export function useCombinedRule({ ruleIdentifier }: { ruleIdentifier: RuleIdenti }, [ruleIdentifier, ruleSourceName, promRuleNs, rulerRuleGroup, ruleSource]); return { - loading: isLoadingDsFeatures || isLoadingPromRules || isLoadingRulerGroup || rulerRuleGroupUninitialized, + loading: isLoadingDsFeatures || isLoadingPromRules || isLoadingRulerGroup, error: ruleLocationError ?? promRuleNsError ?? rulerRuleGroupError, result: rule, };