From f0bbfc8422d79a6dce2e8f4a0191ae51fa8100e9 Mon Sep 17 00:00:00 2001 From: Kyle Cunningham Date: Sat, 10 Feb 2024 07:24:08 +0700 Subject: [PATCH] Chore: Move BI feature flags to Dataviz (#82224) --- pkg/services/featuremgmt/codeowners.go | 1 - pkg/services/featuremgmt/registry.go | 18 ++--- pkg/services/featuremgmt/toggles_gen.csv | 18 ++--- pkg/services/featuremgmt/toggles_gen.json | 81 +++++++++++++++-------- 4 files changed, 72 insertions(+), 46 deletions(-) diff --git a/pkg/services/featuremgmt/codeowners.go b/pkg/services/featuremgmt/codeowners.go index 42e0c139623..a303f74f9b2 100644 --- a/pkg/services/featuremgmt/codeowners.go +++ b/pkg/services/featuremgmt/codeowners.go @@ -8,7 +8,6 @@ const ( grafanaAppPlatformSquad codeowner = "@grafana/grafana-app-platform-squad" grafanaDashboardsSquad codeowner = "@grafana/dashboards-squad" grafanaExploreSquad codeowner = "@grafana/explore-squad" - grafanaBiSquad codeowner = "@grafana/grafana-bi-squad" grafanaDatavizSquad codeowner = "@grafana/dataviz-squad" grafanaFrontendPlatformSquad codeowner = "@grafana/grafana-frontend-platform" grafanaBackendPlatformSquad codeowner = "@grafana/backend-platform" diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 6d13d0bf0a0..83b7c1d919f 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -282,7 +282,7 @@ var ( Description: "Enables drag and drop for CSV and Excel files", FrontendOnly: true, Stage: FeatureStageExperimental, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "alertingNoNormalState", @@ -464,7 +464,7 @@ var ( Description: "Enables the edit functionality in the datagrid panel", FrontendOnly: true, Stage: FeatureStagePublicPreview, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "extraThemes", @@ -506,7 +506,7 @@ var ( Description: "Enables previous SQL data source dataset dropdown behavior", FrontendOnly: true, Stage: FeatureStagePublicPreview, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, HideFromAdminPage: true, }, { @@ -800,14 +800,14 @@ var ( Description: "Enable format string transformer", Stage: FeatureStagePublicPreview, FrontendOnly: true, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "transformationsVariableSupport", Description: "Allows using variables in transformations", FrontendOnly: true, Stage: FeatureStagePublicPreview, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "kubernetesPlaylists", @@ -907,7 +907,7 @@ var ( Description: "Add cumulative and window functions to the add field from calculation transformation", Stage: FeatureStagePublicPreview, FrontendOnly: true, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "alertmanagerRemoteSecondary", @@ -939,7 +939,7 @@ var ( Description: "Make sure extracted field names are unique in the dataframe", Stage: FeatureStageExperimental, FrontendOnly: true, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "dashboardSceneForViewers", @@ -1042,14 +1042,14 @@ var ( Description: "Enables shared crosshair in table panel", FrontendOnly: true, Stage: FeatureStageExperimental, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "regressionTransformation", Description: "Enables regression analysis transformation", Stage: FeatureStagePublicPreview, FrontendOnly: true, - Owner: grafanaBiSquad, + Owner: grafanaDatavizSquad, }, { Name: "displayAnonymousStats", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index c88be17ca78..b6414f26aa7 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -35,7 +35,7 @@ accessControlOnCall,preview,@grafana/identity-access-team,false,false,false nestedFolders,preview,@grafana/backend-platform,false,false,false nestedFolderPicker,GA,@grafana/grafana-frontend-platform,false,false,true alertingBacktesting,experimental,@grafana/alerting-squad,false,false,false -editPanelCSVDragAndDrop,experimental,@grafana/grafana-bi-squad,false,false,true +editPanelCSVDragAndDrop,experimental,@grafana/dataviz-squad,false,false,true alertingNoNormalState,preview,@grafana/alerting-squad,false,false,false logsContextDatasourceUi,GA,@grafana/observability-logs,false,false,true lokiQuerySplitting,GA,@grafana/observability-logs,false,false,true @@ -60,13 +60,13 @@ externalServiceAuth,experimental,@grafana/identity-access-team,true,false,false refactorVariablesTimeRange,preview,@grafana/dashboards-squad,false,false,false enableElasticsearchBackendQuerying,GA,@grafana/observability-logs,false,false,false faroDatasourceSelector,preview,@grafana/app-o11y,false,false,true -enableDatagridEditing,preview,@grafana/grafana-bi-squad,false,false,true +enableDatagridEditing,preview,@grafana/dataviz-squad,false,false,true extraThemes,experimental,@grafana/grafana-frontend-platform,false,false,true lokiPredefinedOperations,experimental,@grafana/observability-logs,false,false,true pluginsFrontendSandbox,experimental,@grafana/plugins-platform-backend,false,false,true dashboardEmbed,experimental,@grafana/grafana-as-code,false,false,true frontendSandboxMonitorOnly,experimental,@grafana/plugins-platform-backend,false,false,true -sqlDatasourceDatabaseSelection,preview,@grafana/grafana-bi-squad,false,false,true +sqlDatasourceDatabaseSelection,preview,@grafana/dataviz-squad,false,false,true lokiFormatQuery,experimental,@grafana/observability-logs,false,false,true cloudWatchLogsMonacoEditor,GA,@grafana/aws-datasources,false,false,true exploreScrollableLogsContainer,experimental,@grafana/observability-logs,false,false,true @@ -105,8 +105,8 @@ cloudWatchWildCardDimensionValues,GA,@grafana/aws-datasources,false,false,false externalServiceAccounts,preview,@grafana/identity-access-team,false,false,false panelMonitoring,experimental,@grafana/dataviz-squad,false,false,true enableNativeHTTPHistogram,experimental,@grafana/hosted-grafana-team,false,false,false -formatString,preview,@grafana/grafana-bi-squad,false,false,true -transformationsVariableSupport,preview,@grafana/grafana-bi-squad,false,false,true +formatString,preview,@grafana/dataviz-squad,false,false,true +transformationsVariableSupport,preview,@grafana/dataviz-squad,false,false,true kubernetesPlaylists,experimental,@grafana/grafana-app-platform-squad,false,true,false kubernetesSnapshots,experimental,@grafana/grafana-app-platform-squad,false,true,false kubernetesQueryServiceRewrite,experimental,@grafana/grafana-app-platform-squad,true,true,false @@ -120,12 +120,12 @@ panelTitleSearchInV1,experimental,@grafana/backend-platform,true,false,false pluginsInstrumentationStatusSource,experimental,@grafana/plugins-platform-backend,false,false,false managedPluginsInstall,preview,@grafana/plugins-platform-backend,false,false,false prometheusPromQAIL,experimental,@grafana/observability-metrics,false,false,true -addFieldFromCalculationStatFunctions,preview,@grafana/grafana-bi-squad,false,false,true +addFieldFromCalculationStatFunctions,preview,@grafana/dataviz-squad,false,false,true alertmanagerRemoteSecondary,experimental,@grafana/alerting-squad,false,false,false alertmanagerRemotePrimary,experimental,@grafana/alerting-squad,false,false,false alertmanagerRemoteOnly,experimental,@grafana/alerting-squad,false,false,false annotationPermissionUpdate,experimental,@grafana/identity-access-team,false,false,false -extractFieldsNameDeduplication,experimental,@grafana/grafana-bi-squad,false,false,true +extractFieldsNameDeduplication,experimental,@grafana/dataviz-squad,false,false,true dashboardSceneForViewers,experimental,@grafana/dashboards-squad,false,false,true dashboardScene,experimental,@grafana/dashboards-squad,false,false,true panelFilterVariable,experimental,@grafana/dashboards-squad,false,false,true @@ -139,8 +139,8 @@ datatrails,experimental,@grafana/dashboards-squad,false,false,true alertingSimplifiedRouting,experimental,@grafana/alerting-squad,false,false,false logRowsPopoverMenu,GA,@grafana/observability-logs,false,false,true pluginsSkipHostEnvVars,experimental,@grafana/plugins-platform-backend,false,false,false -tableSharedCrosshair,experimental,@grafana/grafana-bi-squad,false,false,true -regressionTransformation,preview,@grafana/grafana-bi-squad,false,false,true +tableSharedCrosshair,experimental,@grafana/dataviz-squad,false,false,true +regressionTransformation,preview,@grafana/dataviz-squad,false,false,true displayAnonymousStats,GA,@grafana/identity-access-team,false,false,true lokiQueryHints,GA,@grafana/observability-logs,false,false,true kubernetesFeatureToggles,experimental,@grafana/grafana-operator-experience-squad,false,false,true diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 2d16608d938..08f37910cda 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -456,13 +456,16 @@ { "metadata": { "name": "editPanelCSVDragAndDrop", - "resourceVersion": "1671537600000", - "creationTimestamp": "2022-12-20T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2022-12-20T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Enables drag and drop for CSV and Excel files", "stage": "experimental", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } }, @@ -775,13 +778,16 @@ { "metadata": { "name": "enableDatagridEditing", - "resourceVersion": "1682337600000", - "creationTimestamp": "2023-04-24T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-04-24T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Enables the edit functionality in the datagrid panel", "stage": "preview", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } }, @@ -853,13 +859,16 @@ { "metadata": { "name": "sqlDatasourceDatabaseSelection", - "resourceVersion": "1686052800000", - "creationTimestamp": "2023-06-06T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-06-06T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Enables previous SQL data source dataset dropdown behavior", "stage": "preview", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true, "hideFromAdminPage": true } @@ -1356,26 +1365,32 @@ { "metadata": { "name": "formatString", - "resourceVersion": "1697198400000", - "creationTimestamp": "2023-10-13T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-10-13T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Enable format string transformer", "stage": "preview", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } }, { "metadata": { "name": "transformationsVariableSupport", - "resourceVersion": "1696420800000", - "creationTimestamp": "2023-10-04T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-10-04T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Allows using variables in transformations", "stage": "preview", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } }, @@ -1549,13 +1564,16 @@ { "metadata": { "name": "addFieldFromCalculationStatFunctions", - "resourceVersion": "1699012800000", - "creationTimestamp": "2023-11-03T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-11-03T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Add cumulative and window functions to the add field from calculation transformation", "stage": "preview", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } }, @@ -1610,13 +1628,16 @@ { "metadata": { "name": "extractFieldsNameDeduplication", - "resourceVersion": "1698926400000", - "creationTimestamp": "2023-11-02T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-11-02T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Make sure extracted field names are unique in the dataframe", "stage": "experimental", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } }, @@ -1792,26 +1813,32 @@ { "metadata": { "name": "tableSharedCrosshair", - "resourceVersion": "1702382400000", - "creationTimestamp": "2023-12-12T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-12-12T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Enables shared crosshair in table panel", "stage": "experimental", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } }, { "metadata": { "name": "regressionTransformation", - "resourceVersion": "1700827200000", - "creationTimestamp": "2023-11-24T12:00:00Z" + "resourceVersion": "1707523537136", + "creationTimestamp": "2023-11-24T12:00:00Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-02-10 00:05:37.1362 +0000 UTC" + } }, "spec": { "description": "Enables regression analysis transformation", "stage": "preview", - "codeowner": "@grafana/grafana-bi-squad", + "codeowner": "@grafana/dataviz-squad", "frontend": true } },