From f1d47d18a8a621a3811586e55032d38c1b1c1df9 Mon Sep 17 00:00:00 2001 From: Yuri Tseretyan Date: Thu, 15 Jun 2023 17:37:30 -0400 Subject: [PATCH] Alerting: Sort RefIDs in error message returned by api.validateCondition (#70198) sort RefIDs in error message --- pkg/services/ngalert/api/api_ruler_validation.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/services/ngalert/api/api_ruler_validation.go b/pkg/services/ngalert/api/api_ruler_validation.go index aaed3f3faf7..583a39718bc 100644 --- a/pkg/services/ngalert/api/api_ruler_validation.go +++ b/pkg/services/ngalert/api/api_ruler_validation.go @@ -3,6 +3,7 @@ package api import ( "errors" "fmt" + "sort" "strings" "time" @@ -135,6 +136,7 @@ func validateCondition(condition string, queries []apimodels.AlertQuery) error { for id := range refIDs { ids = append(ids, id) } + sort.Strings(ids) return fmt.Errorf("condition %s does not exist, must be one of [%s]", condition, strings.Join(ids, ",")) } return nil