From f2c7023fe6946dd810f22b6a29eb54f6e1369a12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Philippe=20Qu=C3=A9m=C3=A9ner?= Date: Fri, 22 Mar 2024 15:26:09 +0100 Subject: [PATCH] fix(alerting): use uid and not rand() in tests for title (#85001) --- pkg/services/ngalert/api/api_ruler_validation_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/services/ngalert/api/api_ruler_validation_test.go b/pkg/services/ngalert/api/api_ruler_validation_test.go index 0530e2378e4..31fd3bc210f 100644 --- a/pkg/services/ngalert/api/api_ruler_validation_test.go +++ b/pkg/services/ngalert/api/api_ruler_validation_test.go @@ -44,6 +44,7 @@ func config(t *testing.T) *setting.UnifiedAlertingSettings { func validRule() apimodels.PostableExtendedRuleNode { forDuration := model.Duration(rand.Int63n(1000)) + uid := util.GenerateShortUID() return apimodels.PostableExtendedRuleNode{ ApiRuleNode: &apimodels.ApiRuleNode{ For: &forDuration, @@ -55,7 +56,7 @@ func validRule() apimodels.PostableExtendedRuleNode { }, }, GrafanaManagedAlert: &apimodels.PostableGrafanaRule{ - Title: fmt.Sprintf("TEST-ALERT-%d", rand.Int63()), + Title: fmt.Sprintf("TEST-ALERT-%s", uid), Condition: "A", Data: []apimodels.AlertQuery{ { @@ -69,7 +70,7 @@ func validRule() apimodels.PostableExtendedRuleNode { Model: nil, }, }, - UID: util.GenerateShortUID(), + UID: uid, NoDataState: allNoData[rand.Intn(len(allNoData))], ExecErrState: allExecError[rand.Intn(len(allExecError))], },