Pass BOOL values as real types (int/bool) instead of strings to SQL parameters. (#101961)
* Pass BOOL values as real types (int/bool) instead of strings to SQL parameters.
Fixes following integration tests when running with Spanner:
* TestIntegrationDataAccess
* GetDataSourcesByType/Get_prunable_data_sources
* TestIntegrationUserAuthToken:
* expires_correctly
* can_properly_rotate_tokens
* keeps_prev_token_valid_for_1_minute_after_it_is_confirmed
* Fix more places where "true" or "false" string was passed as query parameter instead of bool value.
* Removed unit test because it brought unwanted dependencies on xorm into multiple modules.
This commit is contained in:
@@ -40,7 +40,7 @@ func (m *FolderUIDMigration) Exec(sess *xorm.Session, mgrtr *migrator.Migrator)
|
||||
WHERE d.is_folder = ?`
|
||||
}
|
||||
|
||||
r, err := sess.Exec(q, mgrtr.Dialect.BooleanStr(false))
|
||||
r, err := sess.Exec(q, mgrtr.Dialect.BooleanValue(false))
|
||||
if err != nil {
|
||||
mgrtr.Logger.Error("Failed to migrate dashboard folder_uid for dashboards", "error", err)
|
||||
return err
|
||||
@@ -68,7 +68,7 @@ func (m *FolderUIDMigration) Exec(sess *xorm.Session, mgrtr *migrator.Migrator)
|
||||
)
|
||||
WHERE is_folder = ?`
|
||||
}
|
||||
r, err = sess.Exec(q, mgrtr.Dialect.BooleanStr(true))
|
||||
r, err = sess.Exec(q, mgrtr.Dialect.BooleanValue(true))
|
||||
if err != nil {
|
||||
mgrtr.Logger.Error("Failed to migrate dashboard folder_uid for folders", "error", err)
|
||||
return err
|
||||
|
||||
Reference in New Issue
Block a user