From f3e5ad00d6d98c606b685548be0495dd5c17128a Mon Sep 17 00:00:00 2001 From: George Robinson Date: Wed, 20 Mar 2024 07:13:16 +0000 Subject: [PATCH] Remove extra defers in screenshot sevice (#84697) --- pkg/services/screenshot/screenshot.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/services/screenshot/screenshot.go b/pkg/services/screenshot/screenshot.go index 47e29fdccdb..58241961106 100644 --- a/pkg/services/screenshot/screenshot.go +++ b/pkg/services/screenshot/screenshot.go @@ -132,22 +132,22 @@ func (s *HeadlessScreenshotService) Take(ctx context.Context, opts ScreenshotOpt return nil, fmt.Errorf("failed to take screenshot: %w", err) } - defer s.successes.Inc() + s.successes.Inc() screenshot := Screenshot{Path: result.FilePath} return &screenshot, nil } func (s *HeadlessScreenshotService) instrumentError(err error) { if errors.Is(err, dashboards.ErrDashboardNotFound) { - defer s.failures.With(prometheus.Labels{ + s.failures.With(prometheus.Labels{ "reason": "dashboard_not_found", }).Inc() } else if errors.Is(err, context.Canceled) { - defer s.failures.With(prometheus.Labels{ + s.failures.With(prometheus.Labels{ "reason": "context_canceled", }).Inc() } else { - defer s.failures.With(prometheus.Labels{ + s.failures.With(prometheus.Labels{ "reason": "error", }).Inc() }