From f421c713734cb6699e07f34f3268bd7232e52160 Mon Sep 17 00:00:00 2001 From: Marco de Abreu Date: Tue, 15 Apr 2025 21:44:27 +0200 Subject: [PATCH] Provisioning: Fix flaky test CreatingGitHubRepository (#104068) Fix flaky CreatingGitHubRepository Co-authored-by: Marco de Abreu <18629099+marcoabreu@users.noreply.github.com> --- pkg/tests/apis/provisioning/provisioning_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/tests/apis/provisioning/provisioning_test.go b/pkg/tests/apis/provisioning/provisioning_test.go index b346ed58cc5..a2523018980 100644 --- a/pkg/tests/apis/provisioning/provisioning_test.go +++ b/pkg/tests/apis/provisioning/provisioning_test.go @@ -285,6 +285,12 @@ func TestIntegrationProvisioning_CreatingGitHubRepository(t *testing.T) { err = helper.Repositories.Resource.Delete(ctx, repo, metav1.DeleteOptions{}) require.NoError(t, err, "should delete values") + assert.EventuallyWithT(t, func(collect *assert.CollectT) { + found, err := helper.Dashboards.Resource.List(ctx, metav1.ListOptions{}) + require.NoError(t, err, "can list values") + require.Equal(collect, 0, len(found.Items), "expected dashboards to be deleted") + }, time.Second*10, time.Millisecond*10, "Expected dashboards to be deleted") + t.Run("github url cleanup", func(t *testing.T) { tests := []struct { name string