From f458e5752396c90f7d453339b5bc1202fbca271b Mon Sep 17 00:00:00 2001
From: ismail simsek <ismailsimsek09@gmail.com>
Date: Mon, 3 Jun 2024 22:47:27 +0200
Subject: [PATCH] InfluxDB: Fix custom variable support (#88642)

* fix variable support

* prettier
---
 .../components/editor/variable/VariableQueryEditor.tsx | 10 +++++-----
 public/app/plugins/datasource/influxdb/variables.ts    |  4 +++-
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/public/app/plugins/datasource/influxdb/components/editor/variable/VariableQueryEditor.tsx b/public/app/plugins/datasource/influxdb/components/editor/variable/VariableQueryEditor.tsx
index 9de9f8f216f..5cab87fe886 100644
--- a/public/app/plugins/datasource/influxdb/components/editor/variable/VariableQueryEditor.tsx
+++ b/public/app/plugins/datasource/influxdb/components/editor/variable/VariableQueryEditor.tsx
@@ -13,7 +13,7 @@ type Props = QueryEditorProps<InfluxDatasource, InfluxQuery, InfluxOptions, Infl
 const refId = 'InfluxVariableQueryEditor-VariableQuery';
 
 export const InfluxVariableEditor = ({ onChange, datasource, query }: Props) => {
-  const getFluxVariableQuery = (q: InfluxVariableQuery | string) => {
+  const getVariableQuery = (q: InfluxVariableQuery | string) => {
     // in legacy variable support query can be only a string
     // in new variable support query can be an object and hold more information
     // to be able to support old version we check the query here
@@ -24,7 +24,7 @@ export const InfluxVariableEditor = ({ onChange, datasource, query }: Props) =>
     return {
       refId,
       query: q,
-      maxDataPoints: 1000,
+      ...(datasource.version === InfluxVersion.Flux ? { maxDataPoints: 1000 } : {}),
     };
   };
 
@@ -34,7 +34,7 @@ export const InfluxVariableEditor = ({ onChange, datasource, query }: Props) =>
         <>
           <FluxQueryEditor
             datasource={datasource}
-            query={getFluxVariableQuery(query)}
+            query={getVariableQuery(query)}
             onChange={(q) => {
               onChange({ ...query, query: q.query ?? '' });
             }}
@@ -72,11 +72,11 @@ export const InfluxVariableEditor = ({ onChange, datasource, query }: Props) =>
           <InlineField label="Query" labelWidth={20} required grow aria-labelledby="influx-variable-query">
             <TextArea
               aria-label="influx-variable-query"
-              defaultValue={query.query}
+              defaultValue={getVariableQuery(query).query}
               placeholder="metric name or tags query"
               rows={1}
               onBlur={(e) => {
-                onChange({ refId, query: query.query ?? '' });
+                onChange({ refId, query: e.currentTarget.value ?? '' });
               }}
             />
           </InlineField>
diff --git a/public/app/plugins/datasource/influxdb/variables.ts b/public/app/plugins/datasource/influxdb/variables.ts
index 178fc6b3204..a51430f62bd 100644
--- a/public/app/plugins/datasource/influxdb/variables.ts
+++ b/public/app/plugins/datasource/influxdb/variables.ts
@@ -30,7 +30,9 @@ export class InfluxVariableSupport extends CustomVariableSupport<InfluxDatasourc
       return of({ data: [] });
     }
 
-    const interpolated = this.templateSrv.replace(query, request.scopedVars, this.datasource.interpolateQueryExpr);
+    const q = this.templateSrv.replace(query, request.scopedVars, this.datasource.interpolateQueryExpr);
+    const timeFilter = this.datasource.getTimeFilter({ rangeRaw: request.range.raw, timezone: request.timezone });
+    const interpolated = q.replace('$timeFilter', timeFilter);
     const metricFindStream = from(
       this.datasource.metricFindQuery(
         {