From f5a0b0044aebaa5baddb36e5e442ceddd8e82384 Mon Sep 17 00:00:00 2001 From: Alexander Zobnin Date: Wed, 24 Oct 2018 16:57:44 +0300 Subject: [PATCH] graph legend: minor refactor --- public/app/plugins/panel/graph/Legend/Legend.tsx | 12 ++++++------ .../plugins/panel/graph/Legend/LegendSeriesItem.tsx | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/public/app/plugins/panel/graph/Legend/Legend.tsx b/public/app/plugins/panel/graph/Legend/Legend.tsx index b46de63db04..c366004cd9f 100644 --- a/public/app/plugins/panel/graph/Legend/Legend.tsx +++ b/public/app/plugins/panel/graph/Legend/Legend.tsx @@ -1,5 +1,5 @@ import _ from 'lodash'; -import React from 'react'; +import React, { PureComponent } from 'react'; import { TimeSeries } from 'app/core/core'; import CustomScrollbar from 'app/core/components/CustomScrollbar/CustomScrollbar'; import { LegendItem, LEGEND_STATS } from './LegendSeriesItem'; @@ -61,7 +61,7 @@ interface LegendState { hiddenSeries: { [seriesAlias: string]: boolean }; } -export class GraphLegend extends React.PureComponent { +export class GraphLegend extends PureComponent { static defaultProps: Partial = { values: false, min: false, @@ -205,7 +205,7 @@ export class GraphLegend extends React.PureComponent { +class LegendSeriesList extends PureComponent { render() { const { seriesList, hiddenSeries, values, min, max, avg, current, total } = this.props; const seriesValuesProps = { values, min, max, avg, current, total }; @@ -225,7 +225,7 @@ class LegendSeriesList extends React.PureComponent { } } -class LegendTable extends React.PureComponent> { +class LegendTable extends PureComponent> { onToggleSort = stat => { let sortDesc = this.props.sortDesc; let sortBy = this.props.sort; @@ -289,7 +289,7 @@ interface LegendTableHeaderProps { onClick?: (statName: string) => void; } -class LegendTableHeaderItem extends React.PureComponent { +class LegendTableHeaderItem extends PureComponent { onClick = () => this.props.onClick(this.props.statName); render() { @@ -303,7 +303,7 @@ class LegendTableHeaderItem extends React.PureComponent { +export class Legend extends PureComponent { render() { return ( diff --git a/public/app/plugins/panel/graph/Legend/LegendSeriesItem.tsx b/public/app/plugins/panel/graph/Legend/LegendSeriesItem.tsx index ecf7d477edf..2105687d8e1 100644 --- a/public/app/plugins/panel/graph/Legend/LegendSeriesItem.tsx +++ b/public/app/plugins/panel/graph/Legend/LegendSeriesItem.tsx @@ -1,4 +1,4 @@ -import React from 'react'; +import React, { PureComponent } from 'react'; import classNames from 'classnames'; import { TimeSeries } from 'app/core/core'; import { SeriesColorPicker } from 'app/core/components/colorpicker/SeriesColorPicker'; @@ -29,7 +29,7 @@ interface LegendItemState { yaxis: number; } -export class LegendItem extends React.PureComponent { +export class LegendItem extends PureComponent { static defaultProps = { asTable: false, hidden: false, @@ -119,7 +119,7 @@ interface LegendSeriesLabelProps { onLabelClick?: (event) => void; } -class LegendSeriesLabel extends React.PureComponent { +class LegendSeriesLabel extends PureComponent { static defaultProps = { yaxis: undefined, onLabelClick: () => {}, @@ -158,7 +158,7 @@ function SeriesIcon(props) { return ; } -class LegendSeriesIcon extends React.PureComponent { +class LegendSeriesIcon extends PureComponent { static defaultProps = { yaxis: undefined, onColorChange: () => {},