From f8f21a08d6938ce3b6d905796712337aca3aabbf Mon Sep 17 00:00:00 2001 From: Giuseppe Guerra Date: Thu, 8 May 2025 10:05:44 +0200 Subject: [PATCH] Plugins repo: Ensure normalized versions are used to select compatible plugin versions (#105065) --- pkg/plugins/repo/version.go | 2 +- pkg/plugins/repo/version_test.go | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/pkg/plugins/repo/version.go b/pkg/plugins/repo/version.go index b589288019b..b0d5092906d 100644 --- a/pkg/plugins/repo/version.go +++ b/pkg/plugins/repo/version.go @@ -44,7 +44,7 @@ func SelectSystemCompatibleVersion(log log.PrettyLogger, versions []Version, plu }, nil } for _, v := range versions { - if v.Version == version { + if normalizeVersion(v.Version) == version { ver = v break } diff --git a/pkg/plugins/repo/version_test.go b/pkg/plugins/repo/version_test.go index d62671e3b88..ff5060dc199 100644 --- a/pkg/plugins/repo/version_test.go +++ b/pkg/plugins/repo/version_test.go @@ -73,4 +73,12 @@ func TestSelectSystemCompatibleVersion(t *testing.T) { ) require.ErrorContains(t, err, "not compatible") }) + + t.Run("Should handle v prefix correctly", func(t *testing.T) { + _, err := SelectSystemCompatibleVersion(logger, + createPluginVersions(versionArg{version: "v2.0.0"}), + "test", "2.0.0", fakeCompatOpts(), + ) + require.NoError(t, err) + }) }