From f910238185657975839fb142ca3fbee04630d076 Mon Sep 17 00:00:00 2001 From: Bogdan Matei Date: Wed, 12 Mar 2025 18:41:39 +0200 Subject: [PATCH] Dashboards: Fix crashing dashboards after save (#102048) --- .../dashboard-scene/edit-pane/DashboardEditPaneSplitter.tsx | 6 ++++-- public/app/features/dashboard/api/v1.ts | 2 +- public/app/features/dashboard/api/v2.ts | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/public/app/features/dashboard-scene/edit-pane/DashboardEditPaneSplitter.tsx b/public/app/features/dashboard-scene/edit-pane/DashboardEditPaneSplitter.tsx index f51540115c5..48d3ab22af2 100644 --- a/public/app/features/dashboard-scene/edit-pane/DashboardEditPaneSplitter.tsx +++ b/public/app/features/dashboard-scene/edit-pane/DashboardEditPaneSplitter.tsx @@ -67,8 +67,10 @@ export function DashboardEditPaneSplitter({ dashboard, isEditing, body, controls containerStyle.overflow = 'unset'; } - const onBodyRef = (ref: HTMLDivElement) => { - dashboard.onSetScrollRef(new DivScrollElement(ref)); + const onBodyRef = (ref: HTMLDivElement | null) => { + if (ref) { + dashboard.onSetScrollRef(new DivScrollElement(ref)); + } }; return ( diff --git a/public/app/features/dashboard/api/v1.ts b/public/app/features/dashboard/api/v1.ts index b3383928bc9..53e4095f134 100644 --- a/public/app/features/dashboard/api/v1.ts +++ b/public/app/features/dashboard/api/v1.ts @@ -70,7 +70,7 @@ export class K8sDashboardAPI implements DashboardAPI { getDashboardUrl({ uid: v.metadata.name, currentQueryParams: '', - slug: kbn.slugifyForUrl(v.spec.title), + slug: kbn.slugifyForUrl(v.spec.title.trim()), }) ); diff --git a/public/app/features/dashboard/api/v2.ts b/public/app/features/dashboard/api/v2.ts index 2913f313144..d43228f82e4 100644 --- a/public/app/features/dashboard/api/v2.ts +++ b/public/app/features/dashboard/api/v2.ts @@ -143,7 +143,7 @@ export class K8sDashboardV2API getDashboardUrl({ uid: v.metadata.name, currentQueryParams: '', - slug: kbn.slugifyForUrl(v.spec.title), + slug: kbn.slugifyForUrl(v.spec.title.trim()), }) );