From f93a9c794d1c498eff107debe04a3333e3145796 Mon Sep 17 00:00:00 2001 From: George Robinson Date: Tue, 21 Feb 2023 15:42:04 +0000 Subject: [PATCH] Alerting: Fix incorrect comment in eval.go (#63510) This commit fixes an incorrect comment in the Result struct in eval.go that I had written some time ago. The comment now documents the actual behaviour and content of this field. --- pkg/services/ngalert/eval/eval.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/services/ngalert/eval/eval.go b/pkg/services/ngalert/eval/eval.go index 8542c59798c..c08bbec75e0 100644 --- a/pkg/services/ngalert/eval/eval.go +++ b/pkg/services/ngalert/eval/eval.go @@ -163,9 +163,10 @@ type Result struct { // Results contains the results of all queries, reduce and math expressions Results map[string]data.Frames - // Values contains the RefID and value of reduce and math expressions. - // It does not contain values for classic conditions as the values - // in classic conditions do not have a RefID. + // Values contains the labels and values for all Threshold, Reduce and Math expressions, + // and all conditions of a Classic Condition that are firing. Threshold, Reduce and Math + // expressions are indexed by their Ref ID, while conditions in a Classic Condition are + // indexed by their Ref ID and the index of the condition. For example, B0, B1, etc. Values map[string]NumberValueCapture EvaluatedAt time.Time