From f9c70dc83430d8b331bbb1ac76b66667a86b0ee5 Mon Sep 17 00:00:00 2001
From: "Grot (@grafanabot)" <43478413+grafanabot@users.noreply.github.com>
Date: Thu, 17 Jun 2021 05:38:11 -0400
Subject: [PATCH] AzureMonitor: Avoid instantiating appInsights for AppInsights
 for gov cloud (#35772) (#35867)

(cherry picked from commit 4ac2ed5de63cdf069f5a454161aac1f82a125c23)

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
---
 .../datasource.ts                             | 30 ++++++++++++-------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/public/app/plugins/datasource/grafana-azure-monitor-datasource/datasource.ts b/public/app/plugins/datasource/grafana-azure-monitor-datasource/datasource.ts
index 7ca7a041022..a9fa695ba48 100644
--- a/public/app/plugins/datasource/grafana-azure-monitor-datasource/datasource.ts
+++ b/public/app/plugins/datasource/grafana-azure-monitor-datasource/datasource.ts
@@ -25,14 +25,17 @@ import InsightsAnalyticsDatasource from './insights_analytics/insights_analytics
 import { migrateMetricsDimensionFilters } from './query_ctrl';
 import { map } from 'rxjs/operators';
 import AzureResourceGraphDatasource from './azure_resource_graph/azure_resource_graph_datasource';
+import { getAzureCloud } from './credentials';
 
 export default class Datasource extends DataSourceApi<AzureMonitorQuery, AzureDataSourceJsonData> {
   azureMonitorDatasource: AzureMonitorDatasource;
-  appInsightsDatasource: AppInsightsDatasource;
   azureLogAnalyticsDatasource: AzureLogAnalyticsDatasource;
-  insightsAnalyticsDatasource: InsightsAnalyticsDatasource;
   resourcePickerData: ResourcePickerData;
   azureResourceGraphDatasource: AzureResourceGraphDatasource;
+  /** @deprecated */
+  appInsightsDatasource?: AppInsightsDatasource;
+  /** @deprecated */
+  insightsAnalyticsDatasource?: InsightsAnalyticsDatasource;
 
   pseudoDatasource: Record<AzureQueryType, DataSourceWithBackend>;
   optionsKey: Record<AzureQueryType, string>;
@@ -43,18 +46,23 @@ export default class Datasource extends DataSourceApi<AzureMonitorQuery, AzureDa
   ) {
     super(instanceSettings);
     this.azureMonitorDatasource = new AzureMonitorDatasource(instanceSettings);
-    this.appInsightsDatasource = new AppInsightsDatasource(instanceSettings);
     this.azureLogAnalyticsDatasource = new AzureLogAnalyticsDatasource(instanceSettings);
-    this.insightsAnalyticsDatasource = new InsightsAnalyticsDatasource(instanceSettings);
     this.azureResourceGraphDatasource = new AzureResourceGraphDatasource(instanceSettings);
     this.resourcePickerData = new ResourcePickerData(instanceSettings);
 
     const pseudoDatasource: any = {};
-    pseudoDatasource[AzureQueryType.ApplicationInsights] = this.appInsightsDatasource;
     pseudoDatasource[AzureQueryType.AzureMonitor] = this.azureMonitorDatasource;
-    pseudoDatasource[AzureQueryType.InsightsAnalytics] = this.insightsAnalyticsDatasource;
     pseudoDatasource[AzureQueryType.LogAnalytics] = this.azureLogAnalyticsDatasource;
     pseudoDatasource[AzureQueryType.AzureResourceGraph] = this.azureResourceGraphDatasource;
+
+    const cloud = getAzureCloud(instanceSettings);
+    if (cloud === 'azuremonitor' || cloud === 'chinaazuremonitor') {
+      // AppInsights and InsightAnalytics are only supported for Public and Azure China clouds
+      this.appInsightsDatasource = new AppInsightsDatasource(instanceSettings);
+      this.insightsAnalyticsDatasource = new InsightsAnalyticsDatasource(instanceSettings);
+      pseudoDatasource[AzureQueryType.ApplicationInsights] = this.appInsightsDatasource;
+      pseudoDatasource[AzureQueryType.InsightsAnalytics] = this.insightsAnalyticsDatasource;
+    }
     this.pseudoDatasource = pseudoDatasource;
 
     const optionsKey: any = {};
@@ -129,7 +137,7 @@ export default class Datasource extends DataSourceApi<AzureMonitorQuery, AzureDa
       return Promise.resolve([]);
     }
 
-    const aiResult = this.appInsightsDatasource.metricFindQueryInternal(query);
+    const aiResult = this.appInsightsDatasource?.metricFindQueryInternal(query);
     if (aiResult) {
       return aiResult;
     }
@@ -153,7 +161,7 @@ export default class Datasource extends DataSourceApi<AzureMonitorQuery, AzureDa
     promises.push(this.azureMonitorDatasource.testDatasource());
     promises.push(this.azureLogAnalyticsDatasource.testDatasource());
 
-    if (this.appInsightsDatasource.isConfigured()) {
+    if (this.appInsightsDatasource?.isConfigured()) {
       promises.push(this.appInsightsDatasource.testDatasource());
     }
 
@@ -241,15 +249,15 @@ export default class Datasource extends DataSourceApi<AzureMonitorQuery, AzureDa
 
   /* Application Insights API method */
   getAppInsightsMetricNames() {
-    return this.appInsightsDatasource.getMetricNames();
+    return this.appInsightsDatasource?.getMetricNames();
   }
 
   getAppInsightsMetricMetadata(metricName: string) {
-    return this.appInsightsDatasource.getMetricMetadata(metricName);
+    return this.appInsightsDatasource?.getMetricMetadata(metricName);
   }
 
   getAppInsightsColumns(refId: string | number) {
-    return this.appInsightsDatasource.logAnalyticsColumns[refId];
+    return this.appInsightsDatasource?.logAnalyticsColumns[refId];
   }
 
   /*Azure Log Analytics */