From fb21492eaec2a27dd6dad50cf5a11640650e629f Mon Sep 17 00:00:00 2001
From: David <david.kaltschmidt@gmail.com>
Date: Thu, 18 Jul 2019 15:36:03 +0200
Subject: [PATCH] E2E: saving a dashboard should wait for success (#18171)

- navigating right away triggered the unsaved warning on slower machines
- this change makes sure we see a success message first
---
 public/e2e-test/pages/dashboards/saveDashboardModal.ts | 3 +++
 public/e2e-test/scenarios/smoke.test.ts                | 1 +
 2 files changed, 4 insertions(+)

diff --git a/public/e2e-test/pages/dashboards/saveDashboardModal.ts b/public/e2e-test/pages/dashboards/saveDashboardModal.ts
index 3340ca5c708..d69bbe1a8cd 100644
--- a/public/e2e-test/pages/dashboards/saveDashboardModal.ts
+++ b/public/e2e-test/pages/dashboards/saveDashboardModal.ts
@@ -4,17 +4,20 @@ import {
   Selector,
   InputPageObjectType,
   InputPageObject,
+  PageObject,
 } from 'e2e-test/core/pageObjects';
 import { TestPage } from 'e2e-test/core/pages';
 
 export interface SaveDashboardModal {
   name: InputPageObjectType;
   save: ClickablePageObjectType;
+  success: PageObject;
 }
 
 export const saveDashboardModal = new TestPage<SaveDashboardModal>({
   pageObjects: {
     name: new InputPageObject(Selector.fromAriaLabel('Save dashboard title field')),
     save: new ClickablePageObject(Selector.fromAriaLabel('Save dashboard button')),
+    success: new PageObject(Selector.fromSelector('.alert-success')),
   },
 });
diff --git a/public/e2e-test/scenarios/smoke.test.ts b/public/e2e-test/scenarios/smoke.test.ts
index 1fb4aa10d29..ff28bfafb5f 100644
--- a/public/e2e-test/scenarios/smoke.test.ts
+++ b/public/e2e-test/scenarios/smoke.test.ts
@@ -57,6 +57,7 @@ e2eScenario(
     const dashboardTitle = new Date().toISOString();
     await saveDashboardModal.pageObjects.name.enter(dashboardTitle);
     await saveDashboardModal.pageObjects.save.click();
+    await saveDashboardModal.pageObjects.success.exists();
 
     // Share the dashboard
     const dashboardsPage = dashboardsPageFactory(dashboardTitle);