From fbb0dcb0caee1bd4c45369bb9e85dc5b24c57db1 Mon Sep 17 00:00:00 2001 From: Mitch Seaman Date: Mon, 20 Mar 2023 10:36:22 -0600 Subject: [PATCH] Add DoD review tasks to pr template (#64726) * add dod review tasks to pr template * remove big-feature content --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d7653e17eca..910eed9b084 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -42,5 +42,11 @@ Usage: "Fixes #", or "Fixes (paste link of issue)" Fixes # -**Special notes for your reviewer**: +**Special notes for your reviewer:** +Please check that: +- [ ] It works as expected from a user's perspective. +- [ ] If this is a pre-GA feature, it is behind a feature toggle. +- [ ] The docs are updated, and if this is a [notable improvement](https://grafana.com/docs/writers-toolkit/writing-guide/contribute-release-notes/#how-to-determine-if-content-belongs-in-a-whats-new-document), it's added to our [What's New](https://grafana.com/docs/writers-toolkit/writing-guide/contribute-release-notes/) doc. +- [ ] There are no known compatibility issues with older supported versions of Grafana, or plugins. +- [ ] It passes the [Hosted Grafana feature readiness review](https://docs.google.com/document/d/1QL9Ly8KnXzpb6ISbg49pTODRO5mhA5tkkfIZVX6pqQU/edit) for observability, scalability, performance, and security. \ No newline at end of file