From fc37bb4355daeff75b23db98b1996b861742e6bd Mon Sep 17 00:00:00 2001 From: Joey <90795735+joey-grafana@users.noreply.github.com> Date: Tue, 8 Apr 2025 15:37:17 +0100 Subject: [PATCH] Remove nodeGraphDotLayout feature toggle (#103541) --- .../configure-grafana/feature-toggles/index.md | 1 - packages/grafana-data/src/types/featureToggles.gen.ts | 4 ---- pkg/services/featuremgmt/registry.go | 7 ------- pkg/services/featuremgmt/toggles_gen.csv | 1 - pkg/services/featuremgmt/toggles_gen.go | 4 ---- pkg/services/featuremgmt/toggles_gen.json | 3 ++- 6 files changed, 2 insertions(+), 18 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index dfe52db3d81..54453fa6e67 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -175,7 +175,6 @@ Experimental features might be changed or removed without prior notice. | `secretsManagementAppPlatform` | Enable the secrets management API and services under app platform | | `scopeApi` | In-development feature flag for the scope api using the app platform. | | `sqlExpressions` | Enables SQL Expressions, which can execute SQL queries against data source results. | -| `nodeGraphDotLayout` | Changed the layout algorithm for the node graph | | `kubernetesAggregator` | Enable grafana's embedded kube-aggregator | | `expressionParser` | Enable new expression parser | | `disableNumericMetricsSortingInExpressions` | In server-side expressions, disable the sorting of numeric-kind metrics by their metric name or labels. | diff --git a/packages/grafana-data/src/types/featureToggles.gen.ts b/packages/grafana-data/src/types/featureToggles.gen.ts index afaabea3c96..93d2201e076 100644 --- a/packages/grafana-data/src/types/featureToggles.gen.ts +++ b/packages/grafana-data/src/types/featureToggles.gen.ts @@ -543,10 +543,6 @@ export interface FeatureToggles { */ sqlExpressions?: boolean; /** - * Changed the layout algorithm for the node graph - */ - nodeGraphDotLayout?: boolean; - /** * Enables the group to nested table transformation * @default true */ diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 548e97d2838..2471e77f5bd 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -919,13 +919,6 @@ var ( FrontendOnly: false, Owner: grafanaDatasourcesCoreServicesSquad, }, - { - Name: "nodeGraphDotLayout", - Description: "Changed the layout algorithm for the node graph", - Stage: FeatureStageExperimental, - FrontendOnly: true, - Owner: grafanaObservabilityTracesAndProfilingSquad, - }, { Name: "groupToNestedTableTransformation", Description: "Enables the group to nested table transformation", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index ee68232fc9e..e53cf9603c5 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -119,7 +119,6 @@ scopeApi,experimental,@grafana/grafana-app-platform-squad,false,false,false promQLScope,GA,@grafana/oss-big-tent,false,false,false logQLScope,privatePreview,@grafana/observability-logs,false,false,false sqlExpressions,experimental,@grafana/grafana-datasources-core-services,false,false,false -nodeGraphDotLayout,experimental,@grafana/observability-traces-and-profiling,false,false,true groupToNestedTableTransformation,GA,@grafana/dataviz-squad,false,false,true newPDFRendering,GA,@grafana/sharing-squad,false,false,false tlsMemcached,GA,@grafana/grafana-operator-experience-squad,false,false,false diff --git a/pkg/services/featuremgmt/toggles_gen.go b/pkg/services/featuremgmt/toggles_gen.go index 9da3b939f04..512306a266c 100644 --- a/pkg/services/featuremgmt/toggles_gen.go +++ b/pkg/services/featuremgmt/toggles_gen.go @@ -487,10 +487,6 @@ const ( // Enables SQL Expressions, which can execute SQL queries against data source results. FlagSqlExpressions = "sqlExpressions" - // FlagNodeGraphDotLayout - // Changed the layout algorithm for the node graph - FlagNodeGraphDotLayout = "nodeGraphDotLayout" - // FlagGroupToNestedTableTransformation // Enables the group to nested table transformation FlagGroupToNestedTableTransformation = "groupToNestedTableTransformation" diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index c1851bad562..4cb98fea89d 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -2199,7 +2199,8 @@ "metadata": { "name": "nodeGraphDotLayout", "resourceVersion": "1743693517832", - "creationTimestamp": "2024-01-31T16:26:12Z" + "creationTimestamp": "2024-01-31T16:26:12Z", + "deletionTimestamp": "2025-04-07T10:13:50Z" }, "spec": { "description": "Changed the layout algorithm for the node graph",