public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SQLStore: Add deprecation comments for breaking migrations (#49740) (#50183)

Browse Source 
* Migrator: Extend support to rename columns

* SQLStore: Add deprecation comments for breaking migrations

(cherry picked from commit 5f1305d280)

Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>
This commit is contained in:
Grot (@grafanabot)
2022-06-03 18:02:27 +02:00
committed by GitHub
co-authored by Joan López de la Franca Beltran
parent 78d5e3e0dd
commit fc4018048e
5 changed files with 35 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/sqlstore/migrator/mysql_dialect.go
+5 -11
View File
@@ -118,18 +118,12 @@ func (db *MySQLDialect) ColumnCheckSQL(tableName, columnName string) (string, []
return sql, args
}
func (db *MySQLDialect) RenameColumn(table Table, oldName, newName string) string {
var colType string
for _, col := range table.Columns {
if col.Name == oldName {
colType = db.SQLType(col)
break
}
}
func (db *MySQLDialect) RenameColumn(table Table, column *Column, newName string) string {
quote := db.dialect.Quote
return fmt.Sprintf("ALTER TABLE %s CHANGE %s %s %s", quote(table.Name), quote(oldName), quote(newName), colType)
return fmt.Sprintf(
"ALTER TABLE %s CHANGE %s %s %s",
quote(table.Name), quote(column.Name), quote(newName), db.SQLType(column),
)
}
func (db *MySQLDialect) CleanDB() error {