Init dualwriter metrics (#89003)

* Pass prometheus registerer to the dual writer

* Fix tests

* Remove unused var

* Fix tests

* Uncomment test

* Remove leading line

* Fix tests. Reuse registerer if there's already one

* Lint

* Improve double registering logic

* Rebase main

pkg/services/apiserver/standalone/options/metrics.go

@@ -15,7 +15,7 @@ type MetricsOptions struct {
 	MetricsRegisterer prometheus.Registerer
 }
 
-func NewMetrcicsOptions(logger log.Logger) *MetricsOptions {
+func NewMetricsOptions(logger log.Logger) *MetricsOptions {
 	return &MetricsOptions{
 		logger: logger,
 	}

pkg/services/apiserver/standalone/options/options.go

@@ -25,7 +25,7 @@ func New(logger log.Logger, codec runtime.Codec) *Options {
 		ExtraOptions:       options.NewExtraOptions(),
 		RecommendedOptions: options.NewRecommendedOptions(codec),
 		TracingOptions:     NewTracingOptions(logger),
-		MetricsOptions:     NewMetrcicsOptions(logger),
+		MetricsOptions:     NewMetricsOptions(logger),
 		ServerRunOptions:   genericoptions.NewServerRunOptions(),
 		StorageOptions:     options.NewStorageOptions(),
 	}