public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Provisining: Fix flake in Github URL tests (#110333)

Browse Source 
Remove unnecessary repository deletion in provisioning integration tests
This commit is contained in:
Roberto Jiménez Sánchez
2025-08-29 09:48:52 +00:00
committed by GitHub
parent e5d91fd461
commit fd9d41fe4f
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tests/apis/provisioning/repository_test.go
-9
View File
@@ -338,15 +338,6 @@ func TestIntegrationProvisioning_CreatingGitHubRepository(t *testing.T) {
url, _, err := unstructured.NestedString(obj.Object, "spec", "github", "url") url, _, err := unstructured.NestedString(obj.Object, "spec", "github", "url")
require.NoError(t, err, "failed to read URL") require.NoError(t, err, "failed to read URL")
require.Equal(t, test.output, url) require.Equal(t, test.output, url)
err = helper.Repositories.Resource.Delete(ctx, test.name, metav1.DeleteOptions{})
require.NoError(t, err, "failed to delete")
// Wait for repository to be fully deleted before next test
require.EventuallyWithT(t, func(collect *assert.CollectT) {
_, err := helper.Repositories.Resource.Get(ctx, test.name, metav1.GetOptions{})
assert.True(collect, apierrors.IsNotFound(err), "repository should be deleted")
}, time.Second*5, time.Millisecond*50, "repository should be deleted")
}) })
} }
}) })