ShortURL: Avoid teris-io/shortid (#110456)

pkg/util/shortid_generator_test.go

@@ -6,7 +6,6 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
-	"github.com/teris-io/shortid"
 	"k8s.io/apimachinery/pkg/util/validation"
 )
 
@@ -33,11 +32,8 @@ func TestRandomUIDs(t *testing.T) {
 
 func TestCaseInsensitiveCollisionsUIDs(t *testing.T) {
 	history := make(map[string]bool, 0)
-	for i := 0; i < 100000; i++ {
+	for i := range 100000 {
 		v := GenerateShortUID()
-		if false {
-			v, _ = shortid.Generate() // collides in less then 500 iterations
-		}
 
 		lower := strings.ToLower(v)
 		_, exists := history[lower]