From fe620d8e443b01e97118c7f9b6e6ac96482faf0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Wed, 15 Oct 2014 11:07:51 -0400 Subject: [PATCH] Graph: fill below to series override option not automatically adds lines=false, as overrides, if you want lines just for the fill below series just remove the overrides, #940 --- src/app/panels/graph/module.js | 4 ++-- src/app/panels/graph/seriesOverridesCtrl.js | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/app/panels/graph/module.js b/src/app/panels/graph/module.js index cea1d824f2c..a1dbc942553 100644 --- a/src/app/panels/graph/module.js +++ b/src/app/panels/graph/module.js @@ -342,8 +342,8 @@ function (angular, app, $, _, kbn, moment, TimeSeries) { $scope.render(); }; - $scope.addSeriesOverride = function() { - $scope.panel.seriesOverrides.push({}); + $scope.addSeriesOverride = function(override) { + $scope.panel.seriesOverrides.push(override || {}); }; $scope.removeSeriesOverride = function(override) { diff --git a/src/app/panels/graph/seriesOverridesCtrl.js b/src/app/panels/graph/seriesOverridesCtrl.js index d9681241ad3..bf46b086bea 100644 --- a/src/app/panels/graph/seriesOverridesCtrl.js +++ b/src/app/panels/graph/seriesOverridesCtrl.js @@ -34,6 +34,14 @@ define([ var option = $scope.overrideMenu[optionIndex]; var value = option.values[valueIndex]; $scope.override[option.propertyName] = value; + + // automatically disable lines for this series and the fill bellow to series + // can be removed by the user if they still want lines + if (option.propertyName === 'fillBelowTo') { + $scope.override['lines'] = false; + $scope.addSeriesOverride({ alias: value, lines: false }); + } + $scope.updateCurrentOverrides(); $scope.render(); };