Commit Graph
64847 Commits
Author SHA1 Message Date
Gabriel MABILLE 1e82f99b12 grafana-iam: use apiserver errors (#114850)
* `grafana-iam`: Use api server errors

* A bit more verbose
2025-12-04 16:47:06 +01:00
Levente Balogh e2bef6bf60 Panel Menu: Allow using icons for link extensions (#114836)
* feat: allow using icons for panel menu link extensions

* tests: add a test for checking if the icon is added to the panel menu item
2025-12-04 15:41:49 +00:00
Jacob Valdez a65cf639f4 Adds workflow that comments on PRs that change defaults.ini with docs reminder (#114739) 2025-12-04 09:28:23 -06:00
Levente Balogh 32a58c56ed Dashboard Controls: Add UI for displaying under menu (#113517)
* feat: add options to render under the controls menu

* fix: filter out hidden annotation layers from the dashboard-controls menu

* fix: adjust spacing between annotation controls in the dashboard-controls menu

* fix: e2e test for variables

* feat: move the menu button next to the variables

* fix: remove duplicate link controls

* fix: show dashboard controls when the dashboard is not saved
2025-12-04 16:22:41 +01:00
Mustafa Sencer Özcan 4c5d9cb95f feat: add unified storage data migration step for playlists (#114582)
* fix: add type

* feat: register step

* feat: add playlist support

* test: add test case

* fix: gen mock

* fix: go gen

* fix: lint

* fix: lint

* fix: tests

* fix: add resource

* fix: readd

* fix: address comments

* fix: independent playlist query for migrations

* fix: remove lock logic for sqlite

* fix: handle creation and update datetimes

* fix: query templating

* fix: simply resources and address comments
2025-12-04 15:15:00 +00:00
Roberto Jiménez Sánchez e5259c2ad4 Dashboards: Prevent memory leak in CUE validation by reusing context only for 100 validations (#114818)
* fix(dashboard): prevent memory leak in CUE validation by using fresh contexts

Fixes #114344

The CUE validation was reusing a single cue.Context across all
validations, which caused unbounded memory growth due to CUE's internal
caching of intermediate computation results (disjunctions, unifications,
etc.).

Root Cause:
- A single cue.Context was created and reused via getValidator()
- Each validation added entries to the context's internal caches
- These caches grew unboundedly over time
- Memory could not be garbage collected because the context held references

Solution:
- Store the schema source string instead of a compiled cue.Value
- Create a fresh cuecontext.New() for each validation
- This allows the context and its caches to be garbage collected after
  each validation completes

Performance Impact:
- ~2x slower due to schema recompilation per validation
- Acceptable trade-off to prevent memory leaks
- Memory usage stays bounded instead of growing unboundedly

* fix(dashboard): use periodic context recreation to prevent CUE memory leaks

Replace fresh context creation with periodic context recreation approach.
The context is reused for up to 100 validations, then recreated to allow
garbage collection of cached values while maintaining good performance.

This balances performance (only 19% slower than leaky approach) with memory
safety (stable at ~5 MB vs ~2 GB leak).

See https://github.com/grafana/grafana/issues/114344#issuecomment-3605562491

* refactor(cuevalidator): simplify to use mutex instead of atomic counter

Since CUE is not thread-safe, we need the mutex for the entire validation
operation anyway. Using a regular int counter protected by the mutex is
simpler and cleaner than using atomic operations.
2025-12-04 16:05:15 +01:00
mohammad-hamid 3c5d905e0f AuthZ: Redirect legacy resource permissions handler to k8s (part I) (#114199)
* Add K8s API redirect for GET resource permissions

* wire

* move restconfig to options

* address comments

* fix helper after adding RestConfigProvider

* Revert K8s redirect changes for service accounts, teams, and receivers

Keep only dashboard and folder redirect functionality for this PR.
Service accounts, teams, and receivers will be handled in a separate PR.

* address comments

* lint
2025-12-04 10:04:23 -05:00
Will Assis ae4d2324d6 Unified storage kvstore bulk import support (#113791)
* implement batchdelete in datastore

* implement bulkprocess in kv storage_backend

* convert bulkRVs to snowflake
2025-12-04 09:26:50 -05:00
Mariell Hoversholm 64a3c298cf docs: use clearly invalid tokens (#114842) 2025-12-04 15:25:59 +01:00
Will Assis 994e1dd58f unified-storage: sqlkv migrations (#114790)
* unified-storage: create resource_events table and add key_path column to resource_history

* Update resource_history_insert template

* update test snapshots

* use latin encoding for key_path and bump size to 2048
2025-12-04 09:21:17 -05:00
Irene Rodríguez c88314296b Add Zabbix to the list of unsupported data sources (#114823)
Fixes: https://github.com/grafana/support-escalations/issues/19739
2025-12-04 14:51:59 +01:00
Andreas Christou ff4228bd58 Azure: Improved column handling in logs query builder (#114667)
* Add parameter type field

* Use parameterType to filter columns for aggregation funcs

* Add tests for aggregate components
2025-12-04 12:48:55 +00:00
Gareth d92898888c OpenTSDB: Fix metric dropdown autocomplete (#114825) 2025-12-04 21:34:52 +09:00
Steve Simpson 7aa77af7c4 Alerting: Implement notification history query endpoint. (#114736)
Implements the /notification/query endpoint on the historian app. Note that it
does not apply any RBAC right now, that will be a follow up commit.

We have to use a go-kit logger in grafana/alerting, so an adapter is needed.
Going from go-kit to slog is a bit hairy but works well enough.
2025-12-04 13:26:09 +01:00
Andreas Christou 94b7d6f7b8 Azure: Include aggregate columns in logs builder (#114684)
* Include groupBy and aggregate columns

* Order by tests
2025-12-04 12:22:23 +00:00
Steve Simpson b71ed229f1 Alerting: Minor refactor to historan app RegisterAppInstaller. (#114828)
Splits the function in two so that NewAppInstaller can be used stanalone.
2025-12-04 11:52:24 +00:00
David Harris 45cc410ab8 feat: add new feature highlights for tempo and pyroscope (#114761)
* add new ds feature highlights

* fix translation

* fix translation again
2025-12-04 11:08:57 +00:00
Samarth BaggaandPiotr Jamróz 7f4a94a6bd Explore: Use new Table component (#111463)
* Update TableContainer.tsx

Use PanelRenderer in TableContainer instead of Table

* Passing OnCellFilterAdded

* Fix lint

* Fix

* Update tests

* Update tests

---------

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
2025-12-04 12:00:44 +01:00
Alexander Zobnin 5c49dbf4c4 Zanzana: Non-blocking shadow compile (#114774) 2025-12-04 11:28:09 +01:00
Alexander Zobnin ed91ada3c0 Zanzana: Allow resources to derive permissions from folders by default (#114820) 2025-12-04 11:27:59 +01:00
SantiagoandSonia Aguilar 73b9a8c3af Alerting: Add datasource_uid query param to search for rules (#114697)
* Alerting: Add datasource param to BE search

* use array for param, datasource -> datasources

* tests

* remove comments

* tests, short-circuit request if all data source names are invalid

* rephrase comment

* update some tests...

* make linter happy

* datasource_uid -> datasource_uids

* added test

* datasource_uids -> datasource_uid

---------

Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>
2025-12-04 09:01:12 +00:00
Alexander Zobnin f4fbbcc4f4 Zanzana: Fix dashboard access evaluation in folders (#114718)
* Zanzana: Fix dashboard access evaluation in folders

* add negative test

* Fix listing
2025-12-04 09:36:03 +01:00
Dominik Prokop 1ba57a505a v1 to v2 conversion: Fix issue when Grafana datasource wouldn't be resolved correctly (#114779)
* Reapply "v1 to v2 conversion: Fix issue when Grafana datasource wouldn't be resolved correctly (#114555)"

This reverts commit db9cff8e2d.

* Update input and fix the failing test
2025-12-04 09:23:45 +01:00
Gareth dc8bb66a45 OpenTSDB: Move health check to the backend (#114082)
* add feature toggle

* move health check to backend

* add tests
2025-12-04 17:11:33 +09:00
Ivan Ortega AlbaandStephanie Hingtgen c8853f50cf Dashboard migration: Implement v2 to v0 conversions (#114812)
* Update docs

* Remove 406 response since now it is converted

* fix linter

---------

Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com>
2025-12-04 05:08:03 +00:00
Hugo Häggmark dcd2086212 chore: reduce cloudwatch barrel files (#114568) 2025-12-04 06:06:41 +01:00
Hugo Häggmark 36ded11aa4 chore: reduce barrel files (#114566) 2025-12-04 06:06:16 +01:00
Johnny KartheiserandYuri Tseretyan 0aeb4feef3 update documentation to mention protected fields (#114809)
* update documentation to mention protected fields

* alerting docs: add protected field info for grafana cloud

add protected field info for grafana cloud

* prettier

* link fix

---------

Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
2025-12-03 19:47:23 -05:00
grafana-pr-automation[bot]andgithub-actions[bot] 2d2a1da87f I18n: Download translations from Crowdin (#114815)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-12-04 00:41:38 +00:00
Gabriel MABILLE e3afb0daf9 grafana-iam: Use the K8sStorage interface (#114799) 2025-12-03 21:41:05 +00:00
Gabriel MABILLE f7d9d22963 grafana-iam: standalone rely on storage layer resource permissions authorization (#114785)
* : standalone resource permissions authorization done at storage layer

* instantiate the accessclient
2025-12-03 19:16:37 +01:00
Liza Detrick 29cf10f1fb Logs: table add action buttons and deeplink to log line (#114330) 2025-12-03 09:26:41 -08:00
Gabriel MABILLE 8998b1fde4 grafana-iam: Implement api level user authorization (#114498)
* OnGoing

comment

* WIP on the wrapper

* Get before Delete

* WIP: add an unimplemented storage authorizer

* WIP implementing the resource permission authorize

* Implement beforeCreate

* Create, Delete, Update

* List

* Use a resource permissions wrapper

* Switch the main authorizer to service

* Add namespace

* Use compile for list

* Comment

* Remove unecessary comments

* fix bug with folder permissions

* Implement tests for List

* Test get

* List test small refactor

* Delete test

* Reorganize code

* imports

* Start splitting the tests

* test AfterDelete

* actually test beforeWrite

* Implement tests for wrapper create

* Test delete

* Test List and Get

* Fix List

* Remaining tests

* simplify

* Remove comments

* Reorder

* Change authorizer to allow access
2025-12-03 17:06:26 +01:00
Austin Pond 0f698d08d3 appinstaller: Use grafana-app-sdk apiserver.KubernetesGenericAPIServer to wrap the generic API server (#114654)
[App Platform] Use the app-sdk's apiserver.KubernetesGenericAPIServer in the serverWrapper to ensure that any extra logic for handling WebServices is used.
2025-12-03 11:05:00 -05:00
Liza Detrick c847f1fa4b Logs in Explore: Persist table sorting in the url (#114060) 2025-12-03 08:03:36 -08:00
Todd Treece 157cab192c Plugins API: Add authlib authorizer (#114773) 2025-12-03 11:01:55 -05:00
Dominik Prokop dbb4eb7e12 v2 conversion error: Throw DashboardVersionError correctly to redirecr to v1 API (#114772)
v2 conversion error: Throw DashboardVersionError correctly
2025-12-03 16:28:14 +01:00
Torkel Ödegaard c9fe5c3669 Page: Background prop to support canvas background for standard layout pages (#111174)
* Page canvas

* Working

* remove isOnCanvas prop on card, leave for different PR

* Update

* remove leftover

* Remvoe Card changes

* Fix

* Update
2025-12-03 16:10:25 +01:00
Torkel Ödegaard e89efd7068 Dashboard: Simplify layout categories (#114682)
* Dashboard: Simplify layout categories

* update

* fixing e2e
2025-12-03 16:07:10 +01:00
Renato Costa 3cb03b888f fix: apply appropriate labels and annotations when creating provisioned folders (#114669)
fix: labels and anotations when creating provisioned folders
2025-12-03 09:18:18 -05:00
Sanket KalekarandMihaly Gyongyosi d04f51f7ed Auth: Fix inconsistent symbol validation by allowing underscore "_" in strong password policy (#114571)
* Update validation regex for symbol requirement

Fixes #114544 
frontend: accept underscore as valid symbol in password validation

* test: add underscore symbol test for strong password policy

* chore(changelog): add changelog for #114571

* Delete changelog/114571.md

* fix: correct indentation in password test

* chore(workflows): skip OIDC steps for fork PRs

* chore(workflows): pass fork status to reusable workflow

* revert: remove workflow changes for fork detection

* revert: remove fork status parameter from workflow caller

* Fix formatting issues in PR patch check workflow

---------

Co-authored-by: Mihaly Gyongyosi <mgyongyosi@users.noreply.github.com>
2025-12-03 14:32:28 +01:00
Sonia Aguilar b74465e428 Alerting: Fix 'Rule group does not exist' error toast (#101949) (#114766)
Alerting: Fix "Rule group does not exist" error toast (#101949)
2025-12-03 12:33:48 +01:00
f3ed3a999d Dashboard Schema V2: Preserve ds refs that only have type (#114734)
Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2025-12-03 11:29:52 +00:00
Ryan McKinley 612af5ef55 Search: improve openapi operation ids (#114754) 2025-12-03 10:28:59 +00:00
Steve Simpson 34ac5059c1 Alerting: Allow missing NGAlert in historian.alerting app (#114750) 2025-12-03 09:39:54 +00:00
Dominik ProkopandHaris Rozajac bb787a2637 Schema v2: Move annotation mappings out of legacyOptions (#114721)
* Add mappings property to v2(alpha/beta)1

* Mappings convetions

* OpenAPI spec

* fe annotaations mapping

* Update snapshots

* v2->v1 conversion

* fix tests

---------

Co-authored-by: Haris Rozajac <haris.rozajac12@gmail.com>
2025-12-03 10:19:21 +01:00
Matheus Macabu 3e50bfced8 Dependencies: Bump Go to v1.25.5 (#114749) 2025-12-03 10:18:31 +01:00
Alex KhomenkoandIsabel Matwawana 553d14ba8e Restore dashboards: Add limitations to the docs (#112848)
* Restore dashboards: Document limitations

* Update settings modal text

* Add version history limits

* Update docs/sources/visualizations/dashboards/manage-dashboards/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Apply suggestion from @imatwawana

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Update public/app/features/dashboard-scene/settings/DeleteDashboardButton.tsx

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Update docs/sources/visualizations/dashboards/manage-dashboards/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Feedback

---------

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
2025-12-03 06:34:02 +00:00
grafana-pr-automation[bot]andgithub-actions[bot] 89d8198154 I18n: Download translations from Crowdin (#114740)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-12-03 00:40:14 +00:00
Steve Simpson 2673da03d9 Alerting: Update grafana/alerting (#114733) 2025-12-03 00:18:51 +01:00