* Add no-useless-fragment rule for alerting code
* Auto-fix most no-useless-fragment cases
* Manually fix remaining no-useless-fragment cases
* Fix `invalid` passing to Field component
* Allow AlertingPageWrapper to have optional children
When creating Grafana-managed alerts from Prometheus rule definitions with mimirtool or cortextool, the rules are marked as "provisioned" and are not editable in the Grafana UI. This PR allows changing this by providing an extra header: --extra-header="X-Disable-Provenance=true".
When provenance is disabled, we do not keep the original rule definition in YAML, so it is impossible to read it back using the Prometheus conversion API (mimirtool/cortextool). This is intentional because if we did keep it and the rule was later changed in the UI, its Prometheus YAML definition would no longer reflect the latest version of the alert rule, as it would be unchanged.
* expr: Add row limit to SQL expressions
Adds a configurable row limit to SQL expressions to prevent memory issues with large
result sets. The limit is configured via the `sql_expression_row_limit` setting in
the `[expressions]` section of grafana.ini, with a default of 100,000 rows.
The limit is enforced by checking the total number of rows across all input tables
before executing the SQL query. If the total exceeds the limit, the query fails
with an error message indicating the limit was exceeded.
* revert addition of newline
* Switch to table-driven tests
* Remove single-frame test-cases.
We only need to test for the multi frame case. Single frame is a subset
of the multi-frame case
* Add helper function
Simplify the way tests are set up and written
* Support convention, that limit: 0 is no limit
* Set the row-limit in one place only
* Update default limit to 20k rows
As per some discussion here:
https://raintank-corp.slack.com/archives/C071A5XCFST/p1741611647001369?thread_ts=1740047619.804869&cid=C071A5XCFST
* Test row-limit is applied from config
Make sure we protect this from regressions
This is perhaps a brittle test, somewhat coupled to the code here. But
it's good enough to prevent regressions at least.
* Add public documentation for the limit
* Limit total number of cells instead of rows
* Use named-return for totalRows
As @kylebrandt requested during review of #101700
* Leave DF cells as zero values during limits tests
When testing the cell limit we don't interact with the cell values at
all, so we leave them at their zero values both to speed up tests, and
to simplify and clarify that their values aren't used.
* Set SQLCmd limit at object creation - don't mutate
* Test that SQL node receives limit when built
And that it receives it from the Grafana config
* Improve TODO message for new Expression Parser
* Fix failing test by always creating config on the Service
* Add description below group and namespace fields to make creation clearer
* Make DS managed recording rules clearer
* Change link for recording rule on empty state to Grafana managed
* Tweak empty state
* Tidy up logic for display of recording rule buttons
* Update .betterer.results
* feat: Instrument Tempo query latency measurements
Add comprehensive latency tracking and reporting for Tempo
queries using reportInteraction:
- Add latency measurements for TraceQL metrics queries
- Add latency measurements for TraceID queries
- Add latency measurements for TraceQL search queries
- Track both streaming and non-streaming query performance
- Include success/error states and relevant metadata in reports
- Measure latency in milliseconds for more precise tracking
This instrumentation will help monitor query performance and
identify potential bottlenecks in trace queries.
Signed-off-by: Alex Bikfalvi <alex.bikfalvi@grafana.com>
* fixup! feat: Instrument Tempo query latency measurements
Signed-off-by: Alex Bikfalvi <alex.bikfalvi@grafana.com>
* prettier fix
---------
Signed-off-by: Alex Bikfalvi <alex.bikfalvi@grafana.com>
Co-authored-by: André Pereira <adrapereira@gmail.com>
The remote write path differs based on whether the data source is actually
Prometheus, Mimir, Cortex, or an older version of Cortex. We do not want
users to have to specify the path, so this change determines the path as
best it can.
It may be in the future we have to make this configurable per-datasource
to cater for setups where it's impossible to determine the correct path.
* Authz: Test List
* Anonymous case
* Cover rendering
* Authz: Check namespace is set in the context
* Explicitly request a namespace check in the storage functions
* Revert logic
* Add newLanguages feature toggle
* add additional languages behind feature toggle
* be more forgiving of what config looks like in tests
* tweak regex
* put pt-br back
* restore order of pt-BR and cn-Hans, rename EXTRA_LANGUAGES to NEW_LANGUAGES
* stricter test regex
* Added enterprise only note
* Fixed wording
* Added availability to share panel internally and removed invite new member
* Fixed wording for consistency
* Removed link to invite new members section
* Discarded change
Yuri Tseretyan
Tom Ratcliffe
Isabella SiuandLarissa Wandzura
Alexander Akhmetov
Ashley Harrison
Denis Vodopianov
Sam Jewell
Will Assis
owensmallwood
Esteban Beltran
Alexander Zobnin
Pepe Cano
Laura Fernández
Will Browne
Yulia Shanyrova
Matthew Thorning
Ed Poole
Alex BikfalviandAndré Pereira
Steve Simpson
Joey
Gilles De Mey
maicon
Mike Nolta
Victor Marin
Gabriel MABILLE
Torkel Ödegaard
Igor SuleymanovandRyan McKinley
Josh Hunt
Carl Bergquist
Peter Štibraný
renovate[bot]
Isabel Matwawana
Jacob Valdez
grafana-pr-automation[bot]andgithub-actions[bot]
Andres Martinez Gotor
Tito Lins
Ieva