public/grafana
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
62,801 Commits 655 Branches 650 Tags
121663aa1682df85f86bb0137dfd63e18741417a
Commit Graph
17529 Commits
Author SHA1 Message Date
George Robinson f3e5ad00d6 Remove extra defers in screenshot sevice (#84697) 2024-03-20 07:13:16 +00:00
Yuri TseretyanandWilliam Wernert e593d36ed8 Alerting: Update rule access control to explicitly check for permissions "alert.rules:read" and "folders:read" (#78289) 
* require "folders:read" and "alert.rules:read"  in all rules API requests (write and read). 

* add check for permissions "folders:read" and "alert.rules:read" to AuthorizeAccessToRuleGroup and HasAccessToRuleGroup

* check only access to datasource in rule testing API

---------

Co-authored-by: William Wernert <william.wernert@grafana.com>
 2024-03-19 22:20:30 -04:00
Andreas ChristouLarissa WandzuraChristopher MoyerAndrew Hackmann
 		6bb7ab261a AzureMonitor: User authentication support (#81918) 
* Stub out frontend user auth

* Stub out backend user auth

* Add context

* Reorganise files

* Refactor app registration form

* Alert for user auth service principal credentials

* AzureMonitor: Add flag for enabling/disabling fallback credentials for current user authentication (#82332)

* Rename field

* Add fallback setting

* Update tests and mock

* Remove duplicate setting line

* Update name of property

* Update frontend settings

* Update docs and default config files

* Update azure-sdk

* Fix lint

* Update test

* Bump dependency

* Update configuration

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* Docs review

* AzureMonitor: User authentication frontend updates (#83107)

* Rename field

* Add fallback setting

* Update tests and mock

* Remove duplicate setting line

* Update name of property

* Update frontend settings

* Update docs and default config files

* Add alerts to query editor

- Add authenticatedBy property to grafana/data
- Update mocks
- Update query editor to disable it under certain circumstances
- Update tests

* Add separate FallbackCredentials component

- Reset AppRegistrationCredentials component to only handle clientsecret credentials
- Update AzureCredentialsForm
- Update selectors
- Update tests
- Update credentials utility functions logic

* Alert when fallback credentials disabled

* Update condition

* Update azure-sdk

* Fix lint

* Update test

* Remove unneeded conditions

* Set auth type correctly

* Legacy cloud options

* Fix client secret

* Remove accidental import

* Bump dependency

* Add tests

* Don't use VerticalGroup component

* Remove unused import

* Fix lint

* Appropriately set oAuthPassThru and disableGrafanaCache properties

* Clear azureCredentials on authType change

* Correctly retrieve secret

* Fix bug in authTypeOptions

* Update public/app/plugins/datasource/azuremonitor/components/ConfigEditor/CurrentUserFallbackCredentials.tsx

Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>

* Update public/app/plugins/datasource/azuremonitor/components/QueryEditor/QueryEditor.tsx

Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>

* Update public/app/plugins/datasource/azuremonitor/components/ConfigEditor/CurrentUserFallbackCredentials.tsx

Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>

* Add documentation links

* Fix broken link

---------

Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>

* AzureMonitor: Update docs for current user authentication (#83440)

* Rename field

* Add fallback setting

* Update tests and mock

* Remove duplicate setting line

* Update name of property

* Update frontend settings

* Update docs and default config files

* Add alerts to query editor

- Add authenticatedBy property to grafana/data
- Update mocks
- Update query editor to disable it under certain circumstances
- Update tests

* Add separate FallbackCredentials component

- Reset AppRegistrationCredentials component to only handle clientsecret credentials
- Update AzureCredentialsForm
- Update selectors
- Update tests
- Update credentials utility functions logic

* Alert when fallback credentials disabled

* Update condition

* Update azure-sdk

* Fix lint

* Update test

* Remove unneeded conditions

* Set auth type correctly

* Legacy cloud options

* Fix client secret

* Remove accidental import

* Bump dependency

* Add tests

* Don't use VerticalGroup component

* Remove unused import

* Update docs

* Fix lint

* Appropriately set oAuthPassThru and disableGrafanaCache properties

* Clear azureCredentials on authType change

* Correctly retrieve secret

* Feedback

* Spelling

* Update docs/sources/datasources/azure-monitor/_index.md

Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>

* Update docs/sources/datasources/azure-monitor/_index.md

Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>

* Update docs/sources/datasources/azure-monitor/_index.md

Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>

* Update docs/sources/datasources/azure-monitor/_index.md

Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>

---------

Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>

* Docs review

* Update docs with additional configuration information

* Fix to appropriately hide the query editor

* Typo

* Update isCredentialsComplete

* Update test

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Andrew Hackmann <5140848+bossinc@users.noreply.github.com>
Co-authored-by: Larissa Wandzura <126723338+lwandz13@users.noreply.github.com>
 2024-03-19 16:32:24 +00:00
Hugo Kiyodi Oshiro b1c4ebe6e8 Plugins: Enable managedPluginsInstall by default (#84721) 
Plugins: enable managedPluginsInstall by default
 2024-03-19 16:34:46 +01:00
Andreas Christou 7c3f621688 Chore: Update grafana-azure-sdk-go (#84741) 
* Update grafana-azure-sdk-go

* Update test
 2024-03-19 14:56:40 +00:00
Yuri Tseretyan 9dc4221508 Alerting: Log expression command types during evaluation (#84614) 2024-03-19 10:00:03 -04:00
Ryan McKinley e27c08cfa9 QueryService: Return application/json and better errors (#84234) 2024-03-19 15:52:15 +02:00
Fabrizio d1f791cf1f Jaeger: Decouple Jaeger plugin (#81377) 2024-03-19 15:39:31 +02:00
Santiago 4ad6d66479 Alerting: Remove ID from UserGrafanaConfig struct (#84602) 
* Alerting: Remove ID from UserGrafanaConfig struct

* user custom mimir image withoud id in grafana config

* change mimir image name
 2024-03-19 12:47:13 +01:00
Santiago c9bb18101c Alerting: Decrypt secrets before sending configuration to the remote Alertmanager (#83640) 
* (WIP) Alerting: Decrypt secrets before sending configuration to the remote Alertmanager

* refactor, fix tests

* test decrypting secrets

* tidy up

* test SendConfiguration, quote keys, refactor tests

* make linter happy

* decrypt configuration before comparing

* copy configuration struct before decrypting

* reduce diff in TestCompareAndSendConfiguration

* clean up remote/alertmanager.go

* make linter happy

* avoid serializing into JSON to copy struct

* codeowners
 2024-03-19 12:12:03 +01:00
Fabrizio c1c9ccb8e8 Loki: Replace imports of infra/httpclient with SDK (#84337) 2024-03-19 10:59:53 +01:00
Andres Martinez Gotor abb8ba3885 Update comment in service.go (#84674) 2024-03-19 09:09:07 +01:00
Marcus Efraimsson e978d0810e DS apiserver: Minor fixes (#84691) 2024-03-19 09:02:52 +01:00
Agnès Toulet 58170d4141 Rendering: Add PDFRendering capability (#84438) 
* Rendering: Add PDFRendering capability

* fix tests
 2024-03-19 08:48:46 +01:00
Isabella Siu 0606a8e413 CloudWatch: Static labels should use label name (#84611) 
CloudWatch: static labels should use label name
 2024-03-18 17:30:59 -04:00
CharandasandMarcus Efraimsson 2d1cd82a98 K8s: standalone: use Grafana's logger to stream all logs (#84530) 
---
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
 2024-03-18 19:25:30 +02:00
Matthew Jacobson 3ea5c08c88 Alerting: External AM fix parsing basic auth with escape characters (#84681) 2024-03-18 13:04:57 -04:00
Ivana Huckova 494d169980 Elasticsearch: Fix legend for alerting, expressions and previously frontend queries (#84485) 
* Elasticsearch: Fix legend for alerting, expressions and previously frontend queries

* Add comment

* Update comment
 2024-03-18 18:01:33 +01:00
Kyle Brandt 818c94f067 Scopes: (Chore) Fix ScopeDashboard by adding spec (#84675) 2024-03-18 17:16:53 +01:00
RobFabrizioIsabel MatwawanaAndrej Ocenas
 		677b765dab NodeGraph: Edge color and stroke-dasharray support (#83855) 
* Adds color and stroke-dasharray support for node graph edges

Adds support for providing color, highlighted color, and visual display of node graph edges as dashed lines via stroke-dasharray.

* Updates node graph documentation

* Updates documentation

Adds default for `highlightedColor`

* Update docs/sources/panels-visualizations/visualizations/node-graph/index.md

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>

* Update packages/grafana-data/src/utils/nodeGraph.ts

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>

* Update docs/sources/panels-visualizations/visualizations/node-graph/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Removes highlightedColor; deprecates highlighted

Per [request](https://github.com/grafana/grafana/pull/83855#issuecomment-1999810826), deprecates `highlighted` in code and documentation, and removes `highlightedColor` as an additional property. `highlighted` will continue to be supported in its original state (makes the edge red), but is superseded if `color` is provided.

* Update types.ts

Missed a file in my last commit. Removes `highlightedColor` and deprecates `highlighted`.

* Add test scenario in test data source

---------

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>
Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
 2024-03-18 16:26:22 +01:00
Kyle Brandt aec2ef727a Prometheus/Scopes: Update to use scopespec type from app (#84593) 2024-03-18 09:49:26 -04:00
Andrej Ocenas 5b085976bf Pyroscope: Fix template variable support (#84477) 2024-03-18 14:25:47 +01:00
Kyle BrandtandTodd Treece aac2cf0aa5 Scopes: Update BE API to include object for linking scope to dashboards (#84608) 
* Add ScopeDashboard

---------

Co-authored-by: Todd Treece <todd.treece@grafana.com>
 2024-03-18 09:22:28 -04:00
Isabella Siu 00f16cd018 CloudWatch Logs: Remove toggle for cloudWatchLogsMonacoEditor (#84414) 2024-03-18 08:56:57 -04:00
Ieva 7aa0ba8c59 Teams: Display teams page to team reader if they also have the access to list team permissions (#84650) 
* display teams to team reader if they also have the access to list team permissions

* fix a typo in the docs
 2024-03-18 14:52:01 +02:00
Jack Westbrook 4ca68925a1 Backend: Delete bundled plugin tests (#84646) 2024-03-18 13:28:24 +01:00
Andres Martinez Gotor e394110f44 Fix api_plugins_test locally (#84484) 2024-03-18 12:08:49 +01:00
Joey f5e83d07a7 Tempo: Deprecate old search (#84498) 
* Add logic to update query from old search to new search i.e. nativeSearch to traceqlSearch

* Remove nativeSearch query and transform

* Update tracking

* Remove nativeSearch from query field

* Udpdate gen comment

* Fix tests

* Add tests

* Remove comments

* Remove log

* Remove log

* Update comment

* Update ids etc for migratedQuery

* Remove old nativeSearch folder

* Fix tests, manual testing
 2024-03-18 09:17:10 +00:00
Andres Martinez Gotor 6204f1e847 Chore: Use SigV4 middleware from aws-sdk (#84462) 2024-03-18 09:33:22 +01:00
Dan CechandDiego Augusto Molina 89f3b70e17 Storage: Add support for listing resource history (#84331) 
* add support for listing resource history

* make watch handle custom label selectors properly

* fix tests

* Apply suggestions from code review

Co-authored-by: Diego Augusto Molina <diegoaugustomolina@gmail.com>

* properly handle special characters in json label matcher

* tidy up

---------

Co-authored-by: Diego Augusto Molina <diegoaugustomolina@gmail.com>
 2024-03-15 19:17:54 -04:00
Josh Hunt 08f4aeded1 E2C: Change permissions for navigating to Cloud Migration (#84594) 
* allow org admins / settings writers to access e2c

* test for org admin specifically
 2024-03-15 17:22:39 +00:00
William Wernert 97f37b2e6f Alerting: Clamp Loki ASH range query to configured max_query_length (#83986) 
* Clamp range in loki http client to configured max_query_length

Defaults to 721h to match Loki default
 2024-03-15 18:59:45 +02:00
Josh Hunt f2628bfad4 Whitelabelling: Override version in UI from config (#84392) 
* Unify how the version is shown in the UI

* use versionString in dashboard help bundles

* fix lint

* remove comment

* fix test types

* make test less flakey
 2024-03-15 18:39:13 +02:00
Karl Persson d4e802dd47 Authn: Add function to resolve identity from org and namespace id (#84555) 
* Add function to get the namespaced id

* Add function to resolve an identity through authn.Service from org and namespace id

* Switch to resolve identity for re-authenticate in another org
 2024-03-15 15:08:15 +01:00
Eric Leijonmarck 6c8895e349 Service accounts: Same Org fix migration to account for duplicate entries (#84349) 
* bug: fix migration to account for duplicate entries

* refactoring to create test folder for user migrations

* fix migration log

* added the migration

* additional tests

* added extSrv tests
 2024-03-15 15:00:25 +01:00
Isabella Siu a0b68deae4 Cloudwatch: Remove cloudWatchWildCardDimensionValues feature toggle (#84329) 2024-03-15 09:49:53 -04:00
ismail simsek eae9bfe4bc Chore: Promlib allows extendOptions to be nil (#84463) 
* use logger from service

* allow extendOptions to be nil

* Update logger
 2024-03-15 13:37:29 +01:00
Sofia Papagiannaki 1208888bb6 Folders: Allow listing folders with write permission (#83527) 
* Folders: Allow listing folders with write permission

* Check for subfolder access if parent does not have

* Add test

* GetFolders: fix ordering

* Apply suggestion from code review
 2024-03-15 14:05:27 +02:00
Will Browne 9d453d0dcc Plugins: Remove direct featuremgmt.FeatureToggles dependency from plugins config (#84482) 2024-03-15 10:58:51 +01:00
Karl Persson ebf455d107 RBAC: Don't refetch permissions when searching for users in authenticated org (#84546) 
Don't refetch permissions when searching for users in authenticated org
 2024-03-15 10:36:16 +01:00
Charandas 759cefd94c ExtSvcAccounts: FIX tests that accidently depended on enterprise (#84535) 
* ExtSvcAccounts: FIX tests that accidently depended on enterprise

* fix
 2024-03-15 08:18:11 +01:00
Charandas 34b5303daf K8s: file-storage: provide empty for resourceVersion initially (#84523) 2024-03-14 16:33:41 -07:00
Dan Cech 0fa0cede75 Storage: streamline context handling (#84319) 
streamline context handling
 2024-03-14 17:12:20 -04:00
Gabriel MABILLEandKarl Persson 2795f9827a ExtSvcAccounts: FIX prevent service account deletion (#84502) 
* ExtSvcAccounts: Fix External Service Accounts Login check

Co-authored-by: Karl Persson <kalle.persson@grafana.com>

* Remove service accounts assignments and permissions on delete

* Fix first set of tests

* Fix second batch of tests

* Fix third batch of tests

---------

Co-authored-by: Karl Persson <kalle.persson@grafana.com>
 2024-03-14 19:11:02 +01:00
Yuri Tseretyan 827860d459 Alerting: Alerting accesscontrol utilities (#84508) 
* create fake for accesscontrol.RuleService
* make errAuthorizationGeneric public
 2024-03-14 14:03:53 -04:00
Yuri Tseretyan f7d836feed Alerting: Update rule provisioning service to accept user (#84480) 2024-03-14 12:04:10 -04:00
Gilles De Mey fe15bb5f48 Alerting: Update composable_kind.go (#84479) 
update composable_kind.go
 2024-03-14 17:20:23 +02:00
Alexander Zobnin f36ad469d0 Access Control: Get global role from request params (#84469) 2024-03-14 16:17:24 +01:00
Gilles De MeyMatthew JacobsonSonia AguilarArmand GrilletWilliam WernertYuri Tseretyan
 		8765c48389 Alerting: Remove legacy alerting (#83671) 
Removes legacy alerting, so long and thanks for all the fish! 🐟

---------

Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>
Co-authored-by: Sonia Aguilar <soniaAguilarPeiron@users.noreply.github.com>
Co-authored-by: Armand Grillet <armandgrillet@users.noreply.github.com>
Co-authored-by: William Wernert <rwwiv@users.noreply.github.com>
Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
 2024-03-14 15:36:35 +01:00
Gilles De Mey 336acaf0bf Alerting: Promote new alerting detail view (#84277) 2024-03-14 15:18:01 +01:00