public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
46,808 Commits 655 Branches 650 Tags
4f46fb412ca4e96b0b0ef3f462aead3fc146389e
Commit Graph

11882 Commits

Author SHA1 Message Date
Joey 4f46fb412c Tempo: Embed flame graph in span details (#77537) 
* Embed flame graph

* Update test

* Update test

* Use toggle

* Update test

* Add tests

* Use const

* Cleanup

* Update profile tag

* Move flame graph out of tags, remove request and other cleanup + tests

* Update test

* Set flame graph by profile id and simplify logic

* Cleanup and redrawListView

* Create/use feature toggle
 2023-11-23 13:36:53 +00:00
Gabriel MABILLE 91a5c3803c RBAC: GrafanaAdmin users are admins of the Global Organization (#78559) 2023-11-23 12:17:28 +01:00
Ieva 778841cabe Annotations: Remove dashboard permission checks for annotations (#78352) 
remove checks for access to dashboard if FlagAnnotationPermissionUpdate is enabled
 2023-11-23 10:47:37 +00:00
Kevin Wang 8bdfb7e1cf chore(authn.service): fix typo in log statement (#76205) 2023-11-23 09:06:19 +01:00
Todd Treece 4203a83538 K8s: Prevent user impersonation (#78555) 2023-11-22 15:55:37 -05:00
Pablo 302519fe26 CloudWatch: Add AWS Bedrock metrics definition (#78478) 2023-11-22 13:40:40 -05:00
ismail simsek c5f3ce1371 InfluxDB: Parse data for table view to have parity with frontend parser (#78365) 
* Use TimeSeriesWide format for table response

* fix group by query result parsing

* handle labels

* provide a test where result has no tags

* parsing results without time column

* clean the code

* remove the comment line

* more cleaning

* lint
 2023-11-22 19:27:42 +01:00
Oscar Kilhed 4c4f11f4b3 Avatar: Allow browser caching of /avatar/ (#78314) 
don't set no-store headers to /avatar/
 2023-11-22 17:41:54 +01:00
Ashley Harrison 4290ed3d86 Chore: Remove newBrowseDashboards feature toggle (#78190) 
* remove all the things

* fix OldFolderPicker tests

* i18n

* remove more unused code

* remove mutation of error object since it's now frozen in the redux state

* fix error handling
 2023-11-22 15:22:00 +00:00
Jo 40c8e2fc75 Live: Move empty orgRole safety valve (#78531) 
move empty orgRole safety valve
 2023-11-22 15:51:11 +01:00
Mihai Doarna f0d3e27ea7 Add unit tests for the removeSSOSettings API method (#78476) 
add unit tests for the removeSSOSettings api method
 2023-11-22 15:57:12 +02:00
Jo 0de66a8099 Authz: Remove use of SignedInUser copy for permission evaluation (#78448) 
* remove use of SignedInUserCopies

* add extra safety to not cross assign permissions

unwind circular dependency

dashboardacl->dashboardaccess

fix missing import

* correctly set teams for permissions

* fix missing inits

* nit: check err

* exit early for api keys
 2023-11-22 14:20:22 +01:00
Ieva 9a3b2937aa Data sources: Refactor logic for naming new data sources (#78479) 
* move the name finding logic for new data sources from frontend to backend

* cleanup and fix test

* linting

* change the way the number after the ds type is incremented - keep incrementing it without adding more hyphens

* enterprise spec updates (unrelated to the PR)
 2023-11-22 09:57:26 +00:00
Xavi Lacasa 72759be6ec AuthN: Support HA setups with External Service Account management (#78425) 
* Lock when creating external service

* Add local lock back

* Improve function signature

* Define lockName separately to make it more explicit

* Update pkg/infra/serverlock/serverlock.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

* Update pkg/infra/serverlock/serverlock.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
 2023-11-22 10:15:13 +01:00
Joey 61553e1693 Tempo: Switch to sdk httpclient from infra httpclient (#78446) 
Switch to sdk httpclient from infra httpclient
 2023-11-22 09:14:53 +00:00
Tania 39754ba2d6 Nested Folders: Wrap create/update operations with transactions (#78000) 
* Nested Folders: Add transaction to create and update methods

* Update tests

* Make IncreaseVersionForAllRulesInNamespace synchronous

* Resolve merge conflicts
 2023-11-21 23:06:20 +02:00
Juan Cabanas 9c5daed336 PublicDashboards: Middleware creation (#77941) 2023-11-21 17:56:36 -03:00
Misi 3607a00692 Auth: Use camelCase in SSO Settings API (#78480) 
Return/accept camelCase fields in sso setting api
 2023-11-21 17:41:47 +01:00
Julien Duchesne 5acb981680 Swagger: Rename API Key AddCommand (#78491) 
As a global definition, `AddAPIKeyCommand` is clearer
 2023-11-21 11:25:21 -05:00
Gabriel MABILLE b6b86bb0b3 RBAC: Check plugins:install globally (#78438) 
* RBAC: Check plugins:install globally

* Add disclamer to the RBACSingleOrganization config option
 2023-11-21 15:09:43 +01:00
Karl Persson 1eb19befaa Login: refactor auth info package (#78459) 
* Remove unused stats and metrics

* No longer collect metrics

* Remove unused dependency

* Move database from sub package
 2023-11-21 14:47:23 +01:00
Andres Martinez Gotor f8a6380510 Chore: Change endpoint to check versions in cli (#78008) 2023-11-21 12:46:26 +01:00
Andres Martinez Gotor 20f3a87bf5 Bug: Fix loading behavior with FlagExternalCorePlugins (#78388) 2023-11-21 11:51:13 +01:00
Karl Persson d42201dbf4 Login: remove unused function (#78442) 
* Move test to the db so we test the queries and not just testing the mock

* Remove unused function and dependencies

* Remove unused functions from the database

* Add some integration tests
 2023-11-21 11:44:13 +01:00
Ivan Babrou 860b3bbce7 Dashboards: Implement natural sort for query variables (#78024) 2023-11-21 10:17:38 +01:00
Sven Grossmann 44586df7bf Loki: Fix scope of labels variable being wrong (#78417) 
fix scope of labels var
 2023-11-21 10:14:21 +01:00
Mihai Doarna 875ea092df Add more unit tests for removeSSOSettings method (#78329) 
* add more unit tests for remove sso settings

* add unit tests for the service method
 2023-11-21 10:11:52 +02:00
Kevin Yu 7f7d912af7 CloudWatch: Call query method from DataSourceWithBackend to support public dashboards (#77532) 
* CloudWatch: call query method from DataSourceWithBackend to support public dashboards

* add test

* remove unneeded properties from test case

* update betterer

* add parens to group related logic

* remove unnecessary aliasing of variable

* use t.Cleanup

* remove redundant check

* add comment
 2023-11-20 14:44:22 -08:00
Kat Yang 2f2ce3edbb Chore: Deprecate ID from Folder (#78281) 
* Chore: Deprecate ID from Folder

* chore: add more linter comments

* chore: add missing lint comment
 2023-11-20 15:44:51 -05:00
Jo 259ecb1793 AuthZ: Improve team ID fetching for signedInUser (#78378) 
* improve team ID fetching for signedInUser

* remove inner join

* rename func

* nit: remove extra params

* nit: spacing and wrapping
 2023-11-20 16:23:13 +01:00
Misi 53f53a44e3 Auth: Make clientTokenRotation enabled by default (#78384) 
Make clientTokenRotation enabled by default
 2023-11-20 15:28:33 +01:00
Ieva 87c3703a0d Data sources: show data source menu to users who only have access to create a data source (#78347) 
* show data source menu to users who only have access to create a data source

* return early if missing permissions
 2023-11-20 13:59:02 +00:00
Karl Persson 72db9739c7 UserAuth: clean-up auth entries on update (#78377) 
* UserAuth: clean-up auth entries on update

* Update pkg/services/login/authinfoservice/database/database.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
 2023-11-20 14:58:32 +01:00
Ivana Huckova 28f4c3ed44 Elasticsearch: Fix processing of raw_data with not-recognized time format (#78262) 
* Elasticsearch: Fix non-standard time field in raw data queries

* Update snapshot tests

* Refactor
 2023-11-20 12:01:41 +01:00
Misi 437ae8e8c5 Auth: Refactor OAuth connectors' initialization (#77919) 
* Refactor AzureAD to init itself

* Use mapstructure to convert data to OAuthInfo

* Update

* Align tests

* Remove unused functions

* Add owner to mapstructure

* Clean up, lint

* Refactor Okta init, Align tests

* Address review comments, fix name in newSocialBase

* Update newSocialBase first param

* Refactor GitLab init, align tests

* Update pkg/login/social/common.go

Co-authored-by: Karl Persson <kalle.persson@grafana.com>

* Use ini conversion to map

* Leftovers

* Refactor GitHub connector initialization, align tests

* Refactor Google connector init, align tests

* Refactor grafana_com connector, align tests

* Refactor generic_oauth connector init, align tests

* cleanup

* Remove util.go

* Add tests for custom field init

* Change OAuthInfo's Extra type

* Fix

* Replace interface{} with any

* clean up

---------

Co-authored-by: Karl Persson <kalle.persson@grafana.com>
 2023-11-20 09:45:40 +01:00
Ryan McKinley 49fc8214a0 K8s: Add etcd tests for dual write (local) (#78161) 2023-11-17 14:20:54 -05:00
Ivan Ortega Alba ddfe4e1bdd FeatureToggle: Disable dashgpt by default and mark it as preview (#78348) 2023-11-17 18:51:51 +02:00
Matthew Jacobson 893839d27b Alerting: Move general alert rule validation from db-layer to model (#78325) 
Alerting: Move general alert rule validation to model
 2023-11-17 11:20:50 -05:00
Karl Persson a929e3f2cf Auth: Remove unused function (#78332) 
Remove unused function
 2023-11-17 17:07:39 +01:00
Karl Persson 140b5b4a61 AuthN: Add debug logs and check error during oauth token sync (#78323) 
Add some debug logs and handle error
 2023-11-17 16:03:25 +01:00
Giuseppe Guerra 027a157898 Plugins: Allow disabling "skip host environment variables" per-plugin (#78266) 
* Plugins: Allow disabling skipping host environment variables per-plugin

* Renamed SkipEnvVarsDecorateFunc to SkipHostEnvVarsDecorateFunc

* PR review feedback

* fix tests
 2023-11-17 16:12:05 +02:00
Will Browne ddb7406caa Plugins: Add running method to interface (#78326) 
* add running to interface

* add context
 2023-11-17 13:52:31 +01:00
Tania a9208f623a Nested Folders: Refactor query for getting folders (#78286) 
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
 2023-11-17 13:09:30 +01:00
Mihai Doarna 9da9bbf907 Add swagger code for the removeProviderSettings API method (#78270) 
* add swagger code for the remove provider SSO settings API method

* replace fine grained with role based

* address feedback
 2023-11-17 14:07:26 +02:00
Domas 6edc86a7ed Chore: Add app o11y viz as code owners for sparkline related stuff (#78310) 
* add app o11y viz as code owners for sparkline related stuff

* run gencue
 2023-11-17 14:02:52 +02:00
Esteban Beltran 5a2127c221 Sandbox: Fix configuration key for sandbox exceptions (#78317) 
* Sandbox: Disable incident app inside the sandbox code

* Fix wrong key for default config and config key

* Rllback file
 2023-11-17 12:35:09 +02:00
Ashley Harrison 7404ed66f6 Chore: Remove navAdminSubsections toggle (#78179) 
* remove navAdminSubsections toggle

* missed one!
 2023-11-17 10:04:34 +00:00
Ieva 2a5547e1b5 Annotations: Update annotation scope resolver to resolve annotation scopes to dash and folder scopes (#78222) 
* update annotation scope resolver to resolve dashboard annotation scopes to dash and folder scopes

* Update annotations.go

remove unwanted changes

* remove unwanted change

* use switch statement
 2023-11-17 11:57:25 +02:00
Gabriel MABILLE 36fd9040af Chore: Fix flaky test (#78309) 
* Chore: Fix flaky test

* Found another one
 2023-11-17 11:38:57 +02:00
Jean-Philippe Quéméner 2d2e058563 refactor: use constant for prometheus datasource type (#78287) 2023-11-17 01:07:35 +01:00