62485898e4
grafana-cli: Fix security issue ( #28888 )
...
* grafana-cli: Fix security issue
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* grafana-cli: Add and improve tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-01-15 17:50:50 +01:00
2a734c2040
fall back to any architecture when getting plugin's checksum #30034 ( #30035 )
...
* fall back to any architecture when getting plugin's checksum
* Update pkg/cmd/grafana-cli/commands/install_command.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* remove typo
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-01-05 14:26:48 +01:00
db67e70ba4
use sha256 checksum instead of md5 ( #30018 )
...
* use sha256 checksum instead of md5
* Chore: Rewrite ldap login test to standard library (#29998 )
* Chore: Rewrite ldap login test to standard library
* Preserve original ldap enabled setting after test
* Chore: Rewrite models alert test to standard library (#30021 )
* Chore: Rewrite models dashboard acl test to standard library (#30022 )
* Chore: Rewrite models dashboards test to standard library (#30023 )
* Chore: Rewrite login auth test to standard library (#29985 )
* Chore: Rewrite login auth test to standard library
* Use assert.Empty when empty string expected
* Chore: Rewrite brute force login protection test to standard library (#29986 )
* Update pkg/cmd/grafana-cli/services/api_client.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/cmd/grafana-cli/services/api_client.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* use sha256 checksum instead of md5
* Update pkg/cmd/grafana-cli/services/api_client.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/cmd/grafana-cli/services/api_client.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* grafana-cli: Remove MD5
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Emil Hessman <emil@hessman.se >
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-01-04 13:27:47 +01:00
c2cad26ca9
Chore: Disable default golangci-lint filter ( #29751 )
...
* Disable default golangci-lint filter
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Chore: Fix linter warnings
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-12-15 09:32:06 +01:00
f326b79cc1
Security: Add gosec G304 auditing annotations ( #29578 )
...
* Security: Add gosec G304 auditing annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* space
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: bergquist <carl.bergquist@gmail.com >
2020-12-03 22:13:06 +01:00
52c154a221
Backend: Rename variables for style conformance ( #29097 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-11-17 17:09:14 +01:00
9f159c5e3d
grafana-cli: Fix file path processing, returning of errors ( #26954 )
...
* grafana-cli: Fix file path processing, returning of errors
2020-08-13 09:38:05 +02:00
2093f7c1f0
grafana-cli: Fix installing of plugins missing directory entries in zip ( #26945 )
2020-08-12 17:08:12 +02:00
16c185c3b9
Chore: Drop xerrors dependency ( #26718 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-07-31 09:45:20 +02:00
5070f7a75b
Chore: Start harmonizing linting with plugin SDK ( #25854 )
...
* Chore: Harmonize linting with plugin SDK
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Chore: Fix linting issues
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-06-29 14:08:32 +02:00
084542a006
Chore: Consolidate on golangci-lint ( #25834 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-06-26 08:46:08 +02:00
766d8a5888
avoid aliased import in cli ( #22566 )
2020-03-04 13:18:13 +01:00
eb98d9c15b
grafana-cli: Upgrade to urfave/cli v2 ( #22402 )
...
* grafana-cli: Upgrade to urfave/cli v2
2020-02-26 12:27:31 +01:00
79c0fa4ca5
CLI: Return error and aborts when plugin file extraction fails ( #20849 )
...
Return error and aborts when plugin file extraction fails.
If file is in use, a somewhat user-friendly message is returned.
Fixes #20841
2019-12-04 12:48:40 +01:00
b4712ec4b9
CLI: Reduce memory usage for plugin installation ( #19639 )
...
* grafana-cli: use tmp file when downloading plugin install file
2019-11-06 13:42:58 +01:00
573e78feeb
pkg/cmd: Check errors ( #19700 )
...
* pkg/cmd: Check errors
* pkg/cmd: Make sure server waits on services, even in case of error
* pkg/cmd: Inform of error to show help
* pkg/cmd: Only warn on failure to send systemd notification
* pkg/cmd: Don't log errors stemming from context cancelation
* pkg/cmd: Don't fail if unable to write to systemd
2019-10-15 16:44:15 +02:00
3866814ea9
CLI: Fix version selection for plugin install ( #19498 )
2019-09-30 15:34:09 +02:00
2acffbeb10
CLI: Fix installing plugins on windows ( #19061 )
...
Fixes #19022
2019-09-13 18:12:52 +02:00
8c49d27705
CLI: Allow installing custom binary plugins ( #17551 )
...
Make sure all data is sent to API to be able to select correct archive version.
2019-07-29 10:44:58 +02:00
81ff856568
grafana-cli: allow installing plugins from a local zip file ( #18021 )
2019-07-10 00:40:33 -07:00
151b24b95f
CLI: Add command to migrate all datasources to use encrypted password fields ( #17118 )
...
closes : #17107
2019-05-27 10:47:21 +02:00
c1289b308f
Chore: revise some of the gosec rules ( #16713 )
2019-05-01 11:36:02 +02:00
54c1bf0cc9
Chore: a bit of spring cleaning ( #16710 )
...
* Chore: use early return technic everywhere
And enable "indent-error-flow" revive rule
* Chore: remove if-return rule from revive config
* Chore: improve error messages
And enable "error-strings" revive rule
* Chore: enable "error-naming" revive rule
* Chore: make linter happy
* Chore: do not duplicate gofmt execution
* Chore: make linter happy
* Chore: address the pull review comments
2019-04-23 11:24:47 +03:00
56c965e5df
cli: chmod 755 for backend plugin binaries
...
Fixes #15500 . Does a simple filename check if the binary names ends
with _linux_amd64 or _darwin_amd64 then sets the file mode to 755.
2019-02-18 15:05:34 +01:00
d2f2c3f220
Fix spelling of your and you're
2018-09-25 12:38:02 +02:00
ee1083d9b4
cli: avoid rely on response.ContentLength ( #13120 )
...
response.ContentLength might be invalid if the http response
is chunked.
fixes #13079
2018-09-03 20:33:21 +02:00
4d6386e97b
Use fmt.Errorf() (gosimple)
...
This fixes:
pkg/cmd/grafana-cli/commands/install_command.go:36:11: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
pkg/models/org_user.go:53:11: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
pkg/services/notifications/mailer.go:138:16: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
2018-04-16 21:04:57 +02:00
ee623e2091
Grafana-CLI: mention the plugins directory is not writable on failure
2018-04-15 13:44:59 -04:00
b099f0309f
cli: download latest dependency by default
2018-02-16 09:54:37 +01:00
5bbe047eaa
Revert "removes dependencies install for plugins"
...
This reverts commit 47e363ea15
2018-02-16 09:49:29 +01:00
47e363ea15
removes dependencies install for plugins
...
this features was never intended for production.
2018-02-14 15:40:42 +01:00
e978bfc368
Added --pluginUrl option to grafana-cli for local network plugin installation
2017-09-15 20:34:08 +02:00
3f00834f25
tech: remove unused dependencies
2016-09-19 15:21:53 +02:00
3c966caa23
feat(cli): download all plugin dependencies
2016-09-15 14:38:11 +02:00
07be2c89a3
tech(cli): lets use the fact that we have a compiler
2016-06-26 03:47:15 +02:00
6de1399cf0
fix(cli): fixes broken import
2016-06-03 12:35:17 +02:00
15aeb4aec2
tech(cli): rename log to logger to separate from server logger
2016-06-03 12:22:30 +02:00
07b13e24fa
style(cli): add some color to error messages
2016-04-23 14:39:42 +02:00
0855f51436
feat(cli): improves defer error handling
2016-04-23 14:39:42 +02:00
70acfb2cfd
fix(cli): adds better help text.
...
The zip lib is throwing panics sometimes when the response is malformed.
The cli will now try to download the zip file up to three times before
aborting. The cli gives a better error message and informes the user
about retrying.
closes #4651
2016-04-23 14:39:42 +02:00
ff22f43002
fix(cli): fixes missplaced %
2016-04-19 14:46:03 +02:00
d38d4efc18
style(cli): improve logging to find install crash
2016-04-19 10:39:55 +02:00
a8c68e33db
feat(cli): add more logging for failed install
2016-04-19 10:22:02 +02:00
903d1b7797
tech(cli): dont use defer statements in loops
2016-04-19 09:13:58 +02:00
676e950fa3
fix(cli): improve error message for not using sudo
...
closes #4562
2016-04-05 15:37:09 +02:00
1e44ee9e9b
feat(grafana-cli): minor changes
2016-03-28 21:42:26 +02:00
1a11f1e8c6
Merge branch 'master' into cli_colors
2016-03-16 14:17:35 +01:00
8e70e9c1c3
feat(cli): improve error message for missing permission
2016-03-13 11:29:43 +01:00
740478344b
Merge branch 'master' into cli_colors
2016-03-11 14:43:12 +01:00
f5bb2b11e5
feat(cli): improve error handling for missing plugin dir
2016-03-11 14:11:25 +01:00
Arve Knudsen
ying-jeanne
Adrián López
Carl Bergquist
Marcus Efraimsson
Olivier Lemasle
Andrej Ocenas
Ryan McKinley
Oleg Gaidarenko
Daniel Lee
Axel Pirek
Carl Bergquist
Karsten Weiss
Matthew McGinn
THIERRY SALLE
Torkel Ödegaard