Commit Graph
44332 Commits
Author SHA1 Message Date
Emil TullstedtandSofia Papagiannaki 10ee900beb Errors: Remove direct dependencies on github.com/pkg/errors (#64026)
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
2023-03-02 16:28:10 +01:00
8c8f584b41 Plugins: Extend panel menu with links from plugins (#63089)
* feat(plugins): introduce dashboard panel menu placement for adding menu items

* test: add test for getPanelMenu()

* added an unique identifier for each extension.

* added context to getPluginExtensions.

* wip

* Wip

* wiwip

* Wip

* feat: WWWIIIIPPPP 🧨

* Wip

* Renamed some of the types to align a bit better.

* added limit to how many extensions a plugin can register per placement.

* decreased number of items to 2

* will trim the lenght of titles to max 25 chars.

* wrapping configure function with error handling.

* added error handling for all scenarios.

* moved extension menu items to the bottom of the more sub menu.

* added tests for configuring the title.

* minor refactorings.

* changed so you need to specify the full path in package.json.

* wip

* removed unused type.

* big refactor to make things simpler and to centralize all configure error/validation handling.

* added missing import.

* fixed failing tests.

* fixed tests.

* revert(extensions): remove static extensions config in favour of registering via AppPlugin APIs

* removed the compose that didn't work for some reason.

* added tests just to verify that validation and error handling is tied together in configuration function.

* adding some more values to the context.

* draft validation.

* added missing tests for getPanelMenu.

* added more tests.

* refactor(extensions): move logic for validating extension link config to function

* Fixed ts errors.

* Update packages/grafana-data/src/types/app.ts

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>

* Update packages/grafana-runtime/src/services/pluginExtensions/extensions.test.ts

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>

* refactor(extensions): rename limiter -> pluginPlacementCount

* refactor(getpanelmenu): remove redundant continue statement

---------

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
2023-03-02 15:42:00 +01:00
Ludovic Viaud 5bd2fac9c8 InfluxDB: Update InfluxQL querybuilder to qualify identifiers (#62230) 2023-03-02 15:05:24 +01:00
Kristin Laemmert bb798e24f3 chore(services): replace dependencies on dashboard store with dashboard service (#63937)
* chore(services): replace dependencies on dashboard store with dashboard service

This continues the backend service/store split by replacing dashboard store dependencies with service dependencies. the folder service remains the single exception for now; otherwise we'd have a dependency cycle between the folder and dashboard services. I have some ideas for that, but I'll take care of all the easy parts first.

While doing this, I identified and removed a number of unused arguments from the following functions:

NewFolderNameScopeResolver
NewFolderIDScopeResolver
NewFolderUIDScopeResolver
NewDashboardIDScopeResolver
NewDashboardUIDScopeResolver
resolveDashboardScope

I have a small enterprise PR to support this commit.

* lingering fmt
2023-03-02 08:09:57 -05:00
renovate[bot]renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Ashley Harrison
a227f69bed Update dependency glob to v9 (#64016)
* Update dependency glob to v9

* update usage of glob

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-03-02 12:59:34 +00:00
Gilles De Mey 5412f8d414 Alerting: New notification policies view (#61952) 2023-03-02 13:49:38 +01:00
renovate[bot]renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Ashley Harrison
494176d122 Remove dependency fs-extra to v11 (#64015)
* Update dependency fs-extra to v11

* remove fs-extra since it's only used in toolkit

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-03-02 12:17:22 +00:00
Torkel Ödegaard 27070c252d ErrorHandling: Fixes issues with bad error messages (#63775) 2023-03-02 13:09:58 +01:00
renovate[bot]andrenovate[bot] <29139614+renovate[bot]@users.noreply.github.com> a2bd98488d Update dependency eventemitter3 to v5 (#64014)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-03-02 11:58:40 +00:00
Sofia Papagiannaki 89569be3a6 SQLStore: Fix wrong usage of xorm's insert functions in tests (#63850)
* SQLStore: Fix InsertId

* Prefs: Fix Insert return value

* Fix tests

* Add guidelines
2023-03-02 13:01:36 +02:00
Joao Silva afd5f41780 StatPanel: Fix issue where sparkline chart was not being shown on resize (#63942) 2023-03-02 12:00:40 +01:00
renovate[bot]renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Ashley Harrison
9e2e569708 Update dependency @types/uuid to v9 (#63957)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-03-02 05:43:11 -05:00
Horst Gutmann 2732c844bd Chore: update latest.json to 9.4.2 (#64005) 2023-03-02 05:36:17 -05:00
Andres Martinez Gotor c84cfd2b3f Plugin query API: Handle multiple errors (#63553) 2023-03-02 11:25:50 +01:00
beateguia b211ec0a1d Docs [Search] update _index.md by replacing dashboardPreviews for panelTitleSearch feature toggle (#63268) 2023-03-02 11:16:50 +01:00
Grot (@grafanabot) ae90f73b78 Changelog: Updated changelog for 9.4.2 (#64000) 2023-03-02 04:49:00 -05:00
Joey adcebcaf8c Flame graph: Add context menu (#62705)
* Context menu

* Flame graph context menu improvements

* Move context menu state into flame graph

* Simplify logic

* Add test and rename to ContextMenuData
2023-03-02 09:47:56 +00:00
Matias Chomicki 40ac0fa14b Query Splitting: Add support for multiple queries (#63663)
* Range splitting: group metric and logs queries

* Range splitting: intercalate logs and metric queries when > 1 queries

* Range splitting: fix possibly undefined error and remove console log

* Range splitting: update test imports

* Range splitting: add unit tests for multiple queries

* Query splitting: use lodash partition function

* Chore: rename variable

* Chore: attempt to improve readability
2023-03-02 10:32:45 +01:00
Jack Baldry f3e08a3560 Fix redirect from /setup-grafana/upgrade-grafana/ to /upgrade-guide/ (#63914)
Additionally fix redirect from `/installation/upgrading/` to
`/setup-grafana/upgrade-grafana/`.

The alias proposed in
https://github.com/grafana/grafana/pull/62402#discussion_r1090526464
was incorrect. It used the `../installation/upgrading/` alias as
reference but I did not check the redirect. As this page itself has
moved from `/setup-grafana/upgrade-grafana/` to `/upgrade-guide/` the
relative alias needed updating also.

To verify that this alias is working as expected:

1. Checkout this branch.
2. Run `make docs`
3. Browse to
http://localhost:3002/docs/grafana/latest/setup-grafana/upgrade-grafana/
4. Verify that you have been redirected to
http://localhost:3002/docs/grafana/latest/upgrade-guide/
5. Browse to
http://localhost:3002/docs/grafana/latest/installation/upgrading/
6. Verify that you have been redirected to
http://localhost:3002/docs/grafana/latest/upgrade-guide/

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
2023-03-02 09:08:27 +00:00
Ivana Huckova adda7819e9 Elasticsearch: Implement processing of raw document query results in backend (#63932) 2023-03-02 09:50:54 +01:00
Andres Martinez Gotor dc6d0a2bdb Nav: Handle app plugin installation/uninstallation (#63706) 2023-03-02 09:50:01 +01:00
Ryan McKinley a4fc8b9fca Transformations: Support time format when converting time to strings (#63826) 2023-03-01 20:00:53 -08:00
matt abrams bc1c54ca17 GHActions: add token to publish changelog on forum (#63294)
add API token for forum
2023-03-01 15:30:01 -10:00
Leon Sorokin 9314fe1056 BarChart: Only apply radius to topmost bar segment when stacking (#63906) 2023-03-01 17:17:55 -06:00
Fábio Silva afc9925dbf Alerting: Fix invalid duration that causes Grafana to crash (#63753)
* Alerting: fix invalid alert duration

* Return empty string from intervalToAbbreviatedDurationString

* Alerting: add tests for invalid duration

* tests intervalToAbbreviatedDurationString

* Alerting: add missing isAfter import 

* durationutils.ts
2023-03-01 11:45:41 -10:00
Jev Forsberg 9160f608b4 TextFormatting/chore: update and add test coverage to the value formatting (#63975)
baldm0mma/chore/updateFormattingTests/ update and add tests to formatting module
2023-03-01 13:54:59 -07:00
Grot (@grafanabot)andMichael Mandrus 682a186676 Changelog: Updated changelog for 9.4.0 (#63978)
* Changelog: Updated changelog for 9.4.0

* Revert release date manually

---------

Co-authored-by: Michael Mandrus <41969079+mmandrus@users.noreply.github.com>
2023-03-01 15:28:33 -05:00
Ezequiel Victorero 8bd4e2cb25 Reqcontext: Use err status code instead of always fallback (#63974) 2023-03-01 17:11:16 -03:00
Andrej Ocenas 1fb2e7bba9 ContextMenu: Fix padding and show border based on items (#63948) 2023-03-01 20:14:28 +01:00
Ryan McKinley fcffedbbf9 Search: Include panel_type in query (#63229) 2023-03-01 11:13:09 -08:00
Kristin LaemmertandRyan McKinley 157c270ad3 chore: remove export service POC from main (#63945)
* chore: remove export service POC from main

This is a POC and we'll see it, or something like it, again!

* remove frontend changes

---------

Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2023-03-01 12:42:53 -05:00
George Robinson 030f6c948f Alerting: Fix migration pauses all alert rules on PostgreSQL (#63951)
This commit fixes a serious bug in Grafana 9.4.1 where on upgrade
a migration would pause all existing alert rules and change the
default value of the column to true.
2023-03-01 17:32:29 +00:00
Leon Sorokin 5510fdc3ce TimeSeries: Ignore invalid, user-defined log-y-axis min/max limits (#59758) 2023-03-01 09:16:54 -08:00
Ashley Harrison 4f01d55a3c Profile: Fix session table overflowing page layout in mobile (#63858)
handle table overflowing in mobile layout
2023-03-01 17:08:04 +00:00
Alex Moreno a05bf41ff9 Alerting: Fix boolean default in migration from false to 0 (#63952)
Fix boolean default in migration from false to 0
2023-03-01 16:58:30 +00:00
Victor Marin c4048fc826 Regen cue after conflicting heatmap/table migrations (#63956) 2023-03-01 11:54:10 -05:00
Ieva 3fb1894739 Service accounts: Creation logic simplification (#63884)
* SA creation improvements

* PR feedback - put salt and rand back in and remove an unneeded line:
2023-03-01 16:31:20 +00:00
Ashley Harrison a534119c44 Command Palette: Sign out link now works correctly (#63742)
* pass target to command palette urls so sign out link works correctly

* improve types
2023-03-01 15:59:32 +00:00
Ryan McKinley 22aa09d392 DashboardStore: Provide an interface directly rather than pointer receiver (#63910) 2023-03-01 07:52:16 -08:00
Victor Marin a91e0a49c9 Migrate table to cue model (#61852)
* WIP table cue model

* WIP table types migration

* refactor

* WIP table cue

* docs

* veneer fix, docs

* docs
2023-03-01 17:48:36 +02:00
Victor Marin e1bc3fad83 Heatmap: Migrate to CUE (#62173)
* IP migrate heatmap to cue

* WIP

* refactor

* change usages and refactor panelcfg

* CR modifications and docs

* refactor, enable heatmap cue generation, overwrite enum values in types.ts

* small refactor

* refactor types.ts

* cr modifications

* docs
2023-03-01 17:47:21 +02:00
Ryan McKinley 763b0fa4d5 Select: Show icon in the grafana/ui Select component (#63827) 2023-03-01 07:41:41 -08:00
9d6ab92e39 Service accounts: Remove Add API keys buttons and remove one state of migrating for API keys tab (#63411)
* add: hide apikeys tab on start

* make use of store method

* added hiding of apikeys tab for new org creation

* missing err check

* removed unused files

* implemennted fake to make tests run

* move check for globalHideApikeys from org to admin

* refactor to remove the fake

* removed unused method calls for interface

* Update pkg/services/serviceaccounts/manager/service.go

Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>

* Update pkg/services/serviceaccounts/manager/service.go

Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>

* remove the checkglobal method

* removed duplicate global set const

* add count of apikeys for performance

* remove apikeys adding in UI

* added back deleted file

* added comment on component

* changed wording and copy for hiding and migrating service accounts

* refactor: remove migrationstatus in front/backend

This removes the migrationstatus state from the UI in favor of only
looking at the number of API keys to determine what to show to the user.
This simplifies the logic and makes less calls to the backend with each
page load. This was called both on the API keys page and the Service
accounts page.

- removes the state of migrationstatus from the UI
- removes the backend call
- removes the backend endpoint for migrationstatus

* Update pkg/services/apikey/apikeyimpl/xorm_store.go

Co-authored-by: Karl Persson <kalle.persson@grafana.com>

* changes the contet to also be primary

* change id of version for footer component

---------

Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
Co-authored-by: Karl Persson <kalle.persson@grafana.com>
2023-03-01 15:34:53 +00:00
Ashley Harrison 8e9ccfc66e Navigation: Fix broken layout at 544px (#63793)
* ensure media queries transition properly

* fix unit tests
2023-03-01 15:31:32 +00:00
Andrej Ocenas 78b39bb282 NodeGraph: Support icons for nodes (#60989) 2023-03-01 16:02:33 +01:00
Sonia Aguilar fa35ed8141 Fix wrong texts in titles when cloning templates (#63930) 2023-03-01 09:37:00 -05:00
Sofia PapagiannakiandJosh Hunt 8aae7be4e5 API: Enable serving Swagger UI by default and add docs and guidelines (#63489)
* Enable serving Swagger UI by default

It used to be served behind the `swaggerUi` feature toggle.

* Remove `swaggerUi` feature toggle

* Add docs and guidelines for updating swagger

* Apply suggestions from code review

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
2023-03-01 16:36:37 +02:00
Joey fbd049a094 Profiling: Enable flame graph & Phlare/Parca data sources for all users (#63488)
* Remove flame graph toggle

* Remove beta badge from panel

* Update expectedListResp.json

* Update flame graph container to only show if there is data
2023-03-01 11:32:39 +00:00
Ivana Huckova d258c8ef8a Elasticsearch: Implement processing of logs query results in backend (#63647)
* Elasticsearch: Add processing of logs query to backend

* Add and fix tests

* Add snapshot tests

* Fix test in ES client

* Small updates, remove redundant logic

* Refactor setPreferredVisType to improve readability
2023-03-01 05:50:56 -05:00
renovate[bot]andAshley Harrison 8ac92aab19 Update dependency @testing-library/dom to v9 (#63908)
ignore testing-library/dom updates until react 18

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-03-01 05:38:13 -05:00