Commit Graph

29898 Commits

Author SHA1 Message Date
Grot (@grafanabot) 6f5f36d305 PieChart: Support row data in pie chart (#34755) (#34865)
* PieChart: Support row data in pie chart

* Make color override work

* removed thing

* Minor refactoring

(cherry picked from commit 658cc5dd2d)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
2021-05-28 08:04:02 +02:00
Grot (@grafanabot) d76104fedf Fix flaky TestNotificationChannels (#34831) (#34866)
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
(cherry picked from commit 89262ac64d)

Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
2021-05-28 07:56:57 +02:00
Grot (@grafanabot) fe968a329e AzureMonitor: Hide App Insights for data sources not using it (#34725) (#34854)
* AzureMonitor: Hide Application Insights and Insights Analytics for panels not using them

* AzureMonitor: Hide Application Insights config

* simplify

* fix test

(cherry picked from commit 7646246d8c)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
2021-05-27 23:09:03 +01:00
Grot (@grafanabot) e6cad0f415 fixes toggleDownloadForExcel function (#34685) (#34852)
(cherry picked from commit f05bddae43)

Co-authored-by: Matt Abrams <37156449+zuchka@users.noreply.github.com>
2021-05-27 22:26:44 +02:00
Grot (@grafanabot) 04741642c5 Live: max_connections option with strict default (#34634) (#34853)
this should help Live to be enabled by default but still
do not affect setups with lots of simultenious users. To
properly handle many WS connections Grafana administrators
should tune infrastructure a bit - for example increase a
number of open files for a process. Will be in more details
in documentation.

(cherry picked from commit 6d750c000e)

Co-authored-by: Alexander Emelin <frvzmb@gmail.com>
2021-05-27 21:47:40 +02:00
Grot (@grafanabot) f44c41fde8 AzureMonitor: reset default subscription when credentials change (#34707) (#34850)
* Update default subscription on credentials change

* Fix secret reset when subscription selected

* Remove unused exports

(cherry picked from commit de86114b66)

Co-authored-by: Sergey Kostrukov <sekost@microsoft.com>
2021-05-27 20:20:29 +01:00
Grot (@grafanabot) 5bf678bcf0 AddPanelWidget: Add padding to prevent top being cut off (#34806) (#34829)
* fix(dashboardpage): add padding so add panel chrome isnt cut off

* fix(addpanelwidget): introduce wrapping element to cater for pulsate animation offset

* refactor(addpanelwidget): use spacing.xs rather than spacing.sm

* test(addpanelwidget): update snapshot

(cherry picked from commit 8ced249c91)

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2021-05-27 18:38:55 +02:00
Grot (@grafanabot) ed29c58d8b Timeline: Default line width to 0 (#34802) (#34840)
(cherry picked from commit 52f3025901)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
2021-05-27 18:01:18 +02:00
Grot (@grafanabot) e2c03cf843 Overrides: Hide from visualization should be available as a manual override option (#34783) (#34841)
* Visualization: Hide from option should be available as a manual override option

* Fix misaligned type

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
(cherry picked from commit f07366690e)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
2021-05-27 17:54:34 +02:00
Grot (@grafanabot) 9364ec4404 Alerting: Set max width on alerting query rows (#34749) (#34833)
(cherry picked from commit e085b2316c)

Co-authored-by: Peter Holmberg <peterholmberg@users.noreply.github.com>
2021-05-27 16:40:51 +02:00
Grot (@grafanabot) 0f27ab2d8f Alerting: improved error message and change styling of relative button. (#34730) (#34832)
* improved error message and change styling of relative button.

* minor adjustments.

* adding clock icon.

(cherry picked from commit da6236d89a)

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>
2021-05-27 16:38:36 +02:00
Marcus Andersson 4a876b6986 Alerting: rename type to make it obvious what part of the code base it belongs to. (#34714) (#34824)
* renamed grafana query to grafana alert query.

* renamed according to feedback in PR.

(cherry picked from commit 1ded9a37c1)
2021-05-27 16:23:01 +02:00
Grot (@grafanabot) b8aeab41de fix the url of API (#34808) (#34823)
(cherry picked from commit 006135c028)

Co-authored-by: ying-jeanne <74549700+ying-jeanne@users.noreply.github.com>
2021-05-27 21:18:41 +08:00
Grot (@grafanabot) fea7355e75 Tempo: Fix the test data source implementation (#34762) (#34825)
Fixes #32677

(cherry picked from commit ec3f8ce04c)

Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
2021-05-27 15:12:31 +02:00
Grot (@grafanabot) 922b34817c Chore: additional check when decrypting values (#34637) (#34671)
* Chore: additional check when decrypting values

* Apply suggestions from code review

(cherry picked from commit a5082ab112)

Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>
2021-05-27 15:42:54 +03:00
Grot (@grafanabot) 337bce75a5 Alerting/testing promql extraction (#34665) (#34819)
* promql compat for marshaling

* extracts upstream instant queries into data frame for alerting

* eval string parity

(cherry picked from commit 0e0ed43153)

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
2021-05-27 08:36:37 -04:00
Grot (@grafanabot) b3a1a063fe Time series panel: Position tooltip correctly when window scrolled or resized (#34782) (#34794)
* Position GraphNG tooltip correctly when window scrolled or resized

* Use syncRect uPlot hook instead of polling

* update snap?!

(cherry picked from commit 1fa755bada)

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2021-05-27 13:53:58 +02:00
Grot (@grafanabot) 6d44eb8954 Alerting: Move Visualization to QueryRow (#34658) (#34792)
* move visualization to queryeditorrow

* add prop to hide disable query

* move panel plugin state outside the vizwrapper

(cherry picked from commit 23cf31a567)

Co-authored-by: Peter Holmberg <peterholmberg@users.noreply.github.com>
2021-05-27 13:47:28 +02:00
Grot (@grafanabot) 986e54c127 SSE/Chore: cleanup some error messages (#34738) (#34743)
removes "rpc error: code = InvalidArgument desc =" like strings from error messages.

This came from old grpc stuff left from when SSE was a plugin (that probably should
not have been used even when it was a plugin)

(cherry picked from commit 9016d20c4c)

Co-authored-by: Kyle Brandt <kyle@grafana.com>
2021-05-27 07:47:05 -04:00
Grot (@grafanabot) 8b0109c095 sort alert instance, "datasource" -> "data source" (#34724) (#34812)
(cherry picked from commit 871e476e41)

Co-authored-by: Domas <domasx2@gmail.com>
2021-05-27 13:26:31 +02:00
Grot (@grafanabot) 8633344706 Plugins: Enable catalog management link to gcom (#34673) (#34811)
* click out to gcom when config enabled

* set to false

* fix styling for uninstall

* remove advertising config + simplify callout URL

* add entry to configuration.md

* update config name

* update lingo

(cherry picked from commit c7b58fe186)

Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
2021-05-27 13:12:38 +02:00
Grot (@grafanabot) f37d9bf13a check if alertmanager being configured is cortex or vanilla (#34726) (#34813)
(cherry picked from commit 5660bb585f)

Co-authored-by: Domas <domasx2@gmail.com>
2021-05-27 13:11:40 +02:00
Grot (@grafanabot) c0d87c9779 PanelChrome: Fix issue with empty panel after adding a non data panel and coming back from panel edit (#34765) (#34804)
* PanelChrome: Fix issue with empty panel after adding a non data panel and coming back from panel edit

* Removed the console.log

(cherry picked from commit ca79d08dd8)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
2021-05-27 12:43:52 +02:00
Grot (@grafanabot) dc27360a89 Live: check schema equality between push messages (#34548) (#34801)
(cherry picked from commit 67028af99e)

Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2021-05-27 12:20:39 +02:00
Grot (@grafanabot) d41bfec2f8 GraphNG: uPlot 1.6.10 (#34759) (#34800)
(cherry picked from commit 1dd5d6ffb0)

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2021-05-27 12:13:17 +02:00
Grot (@grafanabot) 1c7e55085c AzureMonitor: Display variables in Logs resource picker (#34648) (#34719)
* AzureMonitor: Display variables in Resource Picker

* tests

* hide template variable group when there's no template variables

(cherry picked from commit b4ce068f0e)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
2021-05-27 12:09:00 +02:00
Grot (@grafanabot) 48b74313b5 remove feature toggle + add libraryPaneldefinition (#34488) (#34798)
* remove feature toggle + add libraryPaneldefinition

* update doc

* update comments

* Apply suggestions from code review

Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>

* fix typo

* remove post trim

* update api doc

* solve comments and retrigger the test

Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
(cherry picked from commit c59a2e1bcf)

Co-authored-by: ying-jeanne <74549700+ying-jeanne@users.noreply.github.com>
2021-05-27 18:03:54 +08:00
Grot (@grafanabot) 0d0a795d02 check is grafana admin (#34773) (#34797)
(cherry picked from commit dbef103fb9)

Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
2021-05-27 11:32:39 +02:00
Grot (@grafanabot) 47cf96dfee Plugins: Adds back getMappedValue to @grafana/data (#34746) (#34793)
* Plugins: Adds back getMappedValue to @grafana/data

* Chore: fixes doc errors

* Tests: fixes snapshot

* Tests: dummy change to restart Drone

* Tests: tries to fix snapshot

(cherry picked from commit 3a68409e5d)

Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
2021-05-27 11:13:39 +02:00
Grot (@grafanabot) 13473eae6d PanelEdit: Allow standard field config properties extensions without altering order of standard options (#34669) (#34791)
* Render tooltip options in correct category

* Allow custom field config properties that extend standard categories

(cherry picked from commit 811704fd2e)

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2021-05-27 11:08:30 +02:00
Grot (@grafanabot) 15c09dcd68 Histogram: Fix crash when state was undefined (when combine was enabled) (#34514) (#34520)
(cherry picked from commit d0769397b2)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
2021-05-27 10:59:57 +02:00
Grot (@grafanabot) c3bc0a861f [v8.0.x] Explore: Fix Browser title not updated on Navigation to Explore (#34764)
* Explore: Fix Browser title not updated on Navigation to Explore (#34651)

- Update document.title on Explore page
- Add unit test and snapshot for Wrapper component

(cherry picked from commit cebe67ab01)

* fix: remove snapshot for wrapper test

Co-authored-by: Maria Alexandra <239999+axelavargas@users.noreply.github.com>
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
2021-05-27 10:48:01 +02:00
Grot (@grafanabot) eba521f12b Chore: bump Acorn and Underscore (#34302) (#34562)
(cherry picked from commit 68513b9a3f)

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2021-05-27 10:45:07 +02:00
Grot (@grafanabot) 3acfa1b8d0 Dashboard: Fixes issue with title or folder change has no effect after exiting settings view (#34677) (#34786)
* Dashboard: Fixes issue with title or folder change has no effect after existing settings view

* Updates snapshot

(cherry picked from commit 6394a60a08)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
2021-05-27 10:35:10 +02:00
Grot (@grafanabot) 631b2f08a8 Catalog: set library as active tab when viewing (#34753) (#34761)
(cherry picked from commit 6f652e39cb)

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2021-05-27 10:11:11 +02:00
Grot (@grafanabot) f45f160ab8 Live: grafana_live namespace for centrifuge prom metrics (#34712) (#34767)
(cherry picked from commit 4221f2d147)

Co-authored-by: Alexander Emelin <frvzmb@gmail.com>
2021-05-26 15:31:48 -07:00
Grot (@grafanabot) d99847423b set state correctly and test (#34680) (#34770)
(cherry picked from commit 20d356947c)

Co-authored-by: David Parrott <stomp.box.yo@gmail.com>
2021-05-26 15:04:40 -07:00
Grot (@grafanabot) 653a3bdfbf Expose folder UID in dashboards API response (#33991) (#34772)
* expose folder UID in dashboards API response, import dashboards into folders by folder UID

* handle bad folder UID as 400 error

* 12591:Add tests for request with folderUid

* Use more descriptive error status for missing folders

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>

* return 400 when folder id is missing

* put error checking in the right place this time

* mention folderUid in the docs

* Clarify usage of folderUid and folderId when both present

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>

* Capitalise UID

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* mention folder UID in the metadata for a GET response

Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com>
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
(cherry picked from commit ef0fab9aa5)

Co-authored-by: Serge Zaitsev <serge.zaitsev@grafana.com>
2021-05-26 22:10:59 +02:00
Grot (@grafanabot) fca62d20d6 hide caching settings when its disabled (#34756) (#34769)
(cherry picked from commit 3aba08f708)

Co-authored-by: Kevin Minehart <kmineh0151@gmail.com>
2021-05-26 15:06:29 -05:00
Grot (@grafanabot) 52e2a2403f NodeGraph: Show node graph collapsed by default with trace view (#34491) (#34742)
* Show node graph collapsed by default with trace view

* Fix rename variable

* Change the message

* Add test

* Fix e2e test

* Remove expect in exemplars test

* Align icon

* review fixes

(cherry picked from commit 9dafd4f863)

Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
2021-05-26 18:53:47 +02:00
Grot (@grafanabot) cb9a36b91f Transformations: Prevent FilterByValue transform crashing panel edit (#34747) (#34754)
(cherry picked from commit 515c73d8e6)

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2021-05-26 17:54:22 +02:00
Grot (@grafanabot) 72b3478935 NGAlert: Update the default template to include more URLs (#34715) (#34750)
* NGAlert: Update the default template to include more URLs

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

* Fix tests

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
(cherry picked from commit d69c21acb6)

Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
2021-05-26 17:14:15 +02:00
Grot (@grafanabot) 81f2f68535 NGAlert: Add integration tests for remaining notification channels (#34662) (#34728)
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
(cherry picked from commit b168223029)

Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
2021-05-26 19:59:34 +05:30
Grot (@grafanabot) ebe20d1998 TestData: Some simple small test data and first draft of what's new in v8 demo dashboard (#34731) (#34736)
* TestData: More test data

* Added v8 demo dashboard

(cherry picked from commit 6fb0560a84)

Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
2021-05-26 14:36:01 +02:00
Grot (@grafanabot) 771013904a CustomScrollbar: Invoke setScrollTop callback only after scrolling finishes (#34263) (#34564)
* Invoke setScrollTop callback only after scrolling finishes

When the state is updated while scroll events are being dispatched (like in QueryGroup) it may cause resetting the scroll position to the first emitted event because setting the scroll happens only after render (useEffect).

* Memoize onScrollStop callback

(cherry picked from commit 8d05df83ed)

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
2021-05-26 13:38:52 +02:00
Grot (@grafanabot) ba85b954e1 Access control: Rename predefined roles to fixed roles (code) (#34469) (#34663)
* s/grafana:roles:/fixed:/

* Update free text references to predefined roles

(cherry picked from commit 0f4806db8a)

Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
2021-05-26 13:22:44 +02:00
Grot (@grafanabot) b23bd2c105 PageToolbar: add bottom padding (#34602) (#34711)
* fix(pagetoolbar): pad elements top and bottom to keep vertical align and wrapper padding

* fix(sidemenu): prevent mobile sidemenu squashing dashboard, vertically align mobile sidemenu icon

* fix(dashboardsettings): prevent subheader overlap

* fix(pagetoolbar): center align all toolbar elements vertically

* refactor(pagetoolbar): combine vertical paddings to bring back original padding values

* refactor: update padding values for components that use PageToolbar

* fix(playlists): update Empty cta link route to prevent 404

* test(dashboard): update snapshot

(cherry picked from commit ad3b0b2272)

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2021-05-26 12:13:10 +02:00
Grot (@grafanabot) 02dd5a6f0e VisualisationPicker: allow scrolling in Safari (#34717) (#34721)
(cherry picked from commit bcc7bd9dd3)

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2021-05-26 12:12:20 +02:00
Grot (@grafanabot) ea84eb499a Datasource: Use intervalMs field of query model in GetIntervalFrom if interval field is not set (#34270) (#34720)
The /api/ds/query and /api/tsdb/query endpoints extract the intervalMs field from
each query in the request, but it currently seems to be ignored, at
least for queries to a Prometheus datasource. This changes
GetIntervalFrom function to check for the presence of intervalMs in the
query model if interval is missing.

(cherry picked from commit b7ea66b00d)

Co-authored-by: Ben Sully <ben.sully@grafana.com>
2021-05-26 12:09:04 +02:00
Grot (@grafanabot) e3d25450ed AzureMonitor: ResourceMonitor children refactor (#34591) (#34713)
* AzureMonitor: Refactor children to be an arrayu

* Add some resourcePickerData tests

* update tests

* some quick NestedResourceTable tests

(cherry picked from commit 1d3bcb0e90)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
2021-05-26 11:22:43 +02:00