8fb997d935
should not notify when going from unknown to pending
2018-11-14 23:43:09 +01:00
2fb78a50d6
minor fixes based on code review
2018-11-12 10:50:56 +01:00
ae2d536740
adds tests for extracting for property
2018-11-05 13:29:33 +01:00
ccd89eee97
renames debouceduration to for
2018-11-05 11:05:30 +01:00
d25284a364
introduce state unknown for rules that have not been evaluated yet
2018-11-05 10:50:28 +01:00
6f748d8a96
fixes go meta lint issue
2018-11-05 10:50:28 +01:00
4526660cb2
wire up debounce setting in the ui
2018-11-05 10:50:28 +01:00
2d3a575489
adds db migration for debounce_duration
2018-11-05 10:50:28 +01:00
ccfd9c89b2
introduces hard coded deboucing for alerting
2018-11-05 10:50:28 +01:00
7c3dcb3702
alerting: adds tests for the median reducer
...
adds a test that verify that null values are not used
when calculating the median value in alerting
closes #10056
2018-11-05 09:03:35 +01:00
65a15b157f
Increase Telegram captions length limit.
2018-10-31 18:07:09 +01:00
d505d83ee1
Merge pull request #13679 from mjtrangoni/fix-megacheck-issues
...
Fix megacheck issues
2018-10-25 16:31:53 +02:00
0d41904ee5
Merge pull request #13755 from Yukinoshita-Yukino/master
...
Fix cannot receive dingding alert when alert message is empty
2018-10-24 14:56:08 +02:00
0a9bfc5529
delete provisioning meta data when deleting folder
...
prior to this fix Grafana didnt delete meta data
about the provisioned dashboard in `dashboard_provisioning`
which means that the dashboard wasn't inserted into
Grafana again if the folder was delete within Grafana.
closes #13280
2018-10-24 13:32:45 +02:00
b371f2d91f
add debug logging of folder/dashbord permission checks
2018-10-23 11:08:57 +02:00
68507e8855
pkg/services/alerting/reader.go: Fix should use for range instead of for { select {} }.
...
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/services/alerting/reader.go:37:2⚠️ should use for range instead of for { select {} } (S1000) (megacheck)
2018-10-19 19:49:04 +02:00
68c460a957
fix cannot receive dingding alert bug
2018-10-19 17:17:38 +08:00
da89c27caf
Merge pull request #13702 from grafana/data-source-instance-to-react
...
Support Data source permissions
2018-10-17 16:54:57 +02:00
70385119bc
removes d in disableResolvedMessage
2018-10-17 10:41:18 +02:00
5566a61aef
alerting: tests default value for disable resolve message
2018-10-17 09:53:03 +02:00
a3137e731d
clean up tests
2018-10-16 20:39:07 -04:00
0eae7b077d
fix gofmt, add test, correct noted concerns with default value
2018-10-16 17:38:59 -04:00
c4dcf5a4ee
fix gofmt, add test, correct noted concerns with default value
2018-10-16 17:33:38 -04:00
18c73631ea
rename UI Option, align with control, update tests
2018-10-16 07:12:32 -04:00
ee0cc9bd77
Merge branch 'master' into data-source-instance-to-react
2018-10-16 12:14:11 +02:00
6376154b16
add channel option to disable the resolved alert (OK Message) that is sent when condition returns to normal.
2018-10-15 17:16:14 -04:00
938541be2e
Merge pull request #13660 from grafana/alerting-validation-messages
...
Alerting: Propagate alert validation issues to the api/user
2018-10-15 18:16:29 +02:00
272274220c
Fix grammar in log message
2018-10-15 14:37:12 +02:00
ba67dc7689
changed to plain errors further down the alerting validation model so error did not get double wrapping in ValidationError
2018-10-12 23:15:23 -07:00
ec4698fb96
alerting: propagate alert validation issues to the user instead of just 'invalid alert data' message
2018-10-12 23:03:54 -07:00
d17025fb43
Merge pull request #13631 from mjtrangoni/fix-megacheck-issues
...
Fix trivial megacheck issues
2018-10-13 06:56:29 +02:00
74533a7a19
pkg/services/sqlstore/user_auth_test.go: comment unused users slice
...
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/services/sqlstore/user_auth_test.go:28:18⚠️ this result of append is never used, except maybe in other appends (SA4010) (megacheck)
2018-10-13 02:35:03 +02:00
8c9939df72
Adds backend hooks service so extensions can modify index data
2018-10-12 11:26:42 +02:00
d5d8d7efa6
minor setting refactorings
2018-10-12 07:55:36 +02:00
b671b9704f
changed property name to UserWasDeleted and added an assert for it
2018-10-11 12:20:53 -07:00
9c44c75936
pkg/services/alerting/notifiers/telegram.go: check error before close.
...
See,
$ gometalinter --vendor --deadline 6m --disable-all --enable=megacheck ./...
pkg/services/alerting/notifiers/telegram.go:130:2⚠️ should check returned error before deferring imageFile.Close() (SA5001) (megacheck)
2018-10-11 19:51:54 +02:00
9585dc7825
added the UserWasRemoved flag to make api aware of what happened to return correct message to UI
2018-10-11 07:58:22 +02:00
5b5cb6622d
Remove user form org now completely removes the user from the system if the user is orphaned
2018-10-11 07:48:35 +02:00
4d719b0d05
Merge remote-tracking branch 'origin/master' into noop-services-poc
2018-10-08 16:02:44 +02:00
019d0ee179
Merge pull request #13506 from mjtrangoni/fix-megacheck-issues
...
Fix megacheck issues
2018-10-03 20:10:01 +02:00
4498d75b17
provisioning: adds more logging about failed to deletion of provisioned dashboards
2018-10-03 17:38:10 +02:00
d1e1fb7e72
pkg/services/alerting/notifiers/telegram_test.go: pass context.Background() instead of nil
...
See,
$ gometalinter --vendor --disable-all --enable=megacheck --disable=gotype --deadline 6m ./...
pkg/services/alerting/notifiers/telegram_test.go:55:44⚠️ do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (SA1012) (megacheck)
pkg/services/alerting/notifiers/telegram_test.go:71:45⚠️ do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (SA1012) (megacheck)
pkg/services/alerting/notifiers/telegram_test.go:88:45⚠️ do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (SA1012) (megacheck)
pkg/services/alerting/notifiers/telegram_test.go:104:45⚠️ do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (SA1012) (megacheck)
2018-10-03 09:47:54 +02:00
6c41cfb72c
wip: made sqlstore dialect accessable from outside
2018-10-02 16:14:29 +02:00
9af809ff8a
Merge pull request #13440 from grafana/reminder_refactoring
...
Transaction issues for alert reminder
2018-10-02 15:55:18 +02:00
0e0901874b
better comment about state changes
2018-10-02 15:11:33 +02:00
418f77e70e
get or create alert notification should use transaction
2018-10-02 15:07:44 +02:00
7b781e4c3c
use notification state id instead of notifier id
2018-10-02 14:53:39 +02:00
9289cba625
merges defaultShouldNotify and ShouldNotify
2018-10-02 14:28:48 +02:00
67e5f62514
move version conflict logging for mark as complete to sqlstore package
2018-10-02 14:23:18 +02:00
9d3659d30d
improve local variable name
2018-10-02 14:04:50 +02:00
bergquist
Sergio Conde Gomez
Torkel Ödegaard
Carl Bergquist
Marcus Efraimsson
Mario Trangoni
Yuan Liu
Dave Waters
Peter Holmberg
Andreas Kohn