public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
45,325 Commits 655 Branches 650 Tags
9532ff3799bc4db0d0cc40ffb994d7e855e23969
Commit Graph

3310 Commits

Author SHA1 Message Date
Kat Yang
9532ff3799 Chore: Split OSS and Enterprise OAPI Spec Generation (#75133) 
* chore: implement sofia makefile changes from #62456

* chore: clean up makefile and generate specs

* docs: update command to delete old specs

* fix: regenerate specs with enterprise linked

* chore: implement review comments

* Update Makefile

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>

* chore: update make command in drone step

* chore: update bingo, fix makefile indentation error, regen specs

* fix: revert .bingo/README changes to make prettier happy

* chore: add BEP as owners of api-enterprise-spec.json

* chore: rerun drone

---------

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
 2023-09-25 15:34:57 -04:00
João Calisto
7e1b45ba31 Feature Toggles API: Trigger webhook call when updating (#75254) 
* Feature Toggles API: Trigger webhook call when updating

* update status code error check

* lint - handle Close() error

* Rename update webhook config

* fix tests
 2023-09-25 19:11:24 +01:00
Andres Martinez Gotor
ece94b1e01 Chore: Remove plugincontext.ErrPluginNotFound (#74997) 2023-09-25 13:10:47 +03:00
Andres Martinez Gotor
1714fa598c Chore: Refactor backend plugin errors (#74928) 2023-09-25 11:56:03 +02:00
Andres Martinez Gotor
c70623fb85 Chore: Rename testdata plugin with a fully qualified name (#75104) 2023-09-22 15:00:40 +03:00
Ezequiel Victorero
4cfc834c08 HealthCheck: show enterprise commit (#75242) 2023-09-22 08:17:10 -03:00
Carl Bergquist
e5fbc4a4cd web: add slo group to request meta (#74765) 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
 2023-09-22 11:52:28 +03:00
Will Browne
7fca1bde54 Plugins: Set grafana config, plugin version and user agent on plugin requests (#75171) 
* first pass

* fixup

* remove test line

* fix tests

* use new fields

* fix imports + formatting

* fix tests

* rollback changes

* undo whitespace

* apply pr feedback
 2023-09-21 11:33:31 +02:00
Carl Bergquist
764478b9e7 Instrumentation: Set auth as owners for more routes (#75105) 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
 2023-09-20 10:18:52 +02:00
Will Browne
e855efb13d Plugins: Move store and plugin dto to pluginsintegration (#74655) 
move store and plugin dto
 2023-09-11 13:59:24 +02:00
Marcus Efraimsson
8ee43f3705 Instrumentation: Add status_source label to request metrics/logs (#74114) 
Ref #68480

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
 2023-09-11 12:13:13 +02:00
Sofia Papagiannaki
9fcee9b206 Nested folders: Fix folder hierarchy in folder responses (#74516) 
Nested folders: Fix hierarchy in folder response
 2023-09-08 10:43:41 +03:00
Ashley Harrison
a7425f875e Browse Dashboards: Update docs to remove reference to General folder (#74528) 
* update documentation to remove mention of General folder

* update swagger-tags
 2023-09-08 03:57:16 +01:00
Kristin Laemmert
6ce4af7840 chore: remove unused feature flag (#74460) 
This commit removes the validateDashboardsOnSave feature flag that is currently not in use.
Closes #70022
 2023-09-06 11:25:44 -04:00
linoman
0e8f19ca6a Auth: Reduce restriction with non-user accounts (#74397) 
* Reduce restrictions with non-user accounts

* Revert restrictions on anonymous accounts

* Change log level from warning to debug

* Change log messages to upper case
 2023-09-06 13:37:54 +02:00
linoman
13f4382214 Auth: Implement requester interface in access control module (#74289) 
* Implement requester interface in the access control module
 2023-09-06 11:16:10 +02:00
Ieva
58efa49933 Chore: remove IsDisabled method for access control (#74340) 
remove IsDisabled method for access control, clean up tests
 2023-09-05 11:04:39 +01:00
Ryan McKinley
025b2f3011 Chore: use any rather than interface{} (#74066) 2023-08-30 18:46:47 +03:00
linoman
1b8e9b51b2 Replace signed in user for identity.requester (#74048) 
* Make identity.Requester available at Context

* Clean pkg/services/guardian/guardian.go

* Clean guardian provider and guardian AC

* Clean pkg/api/team.go

* Clean ctxhandler, datasources, plugin and live

* Clean dashboards and guardian

* Implement NewUserDisplayDTOFromRequester

* Change status code numbers for http constants

* Upgrade signature of ngalert services

* log parsing errors instead of throwing error
 2023-08-30 16:51:18 +02:00
Karl Persson
127473f4a4 API: Remove usage of legacy dashboard guardian in tests (#73937) 2023-08-29 15:09:09 +02:00
Jo
fe1563882a Chore: Port oauth token service to identity requester (#73988) 
* port oauth token service to identity requester

* fix broken test

* no need to check for render
 2023-08-29 11:55:58 +02:00
venkatbvc
7c98678188 Auth: Add support for OIDC RP-Initiated Logout (#70357) 
* Fix signout redirect_uri issue

* Fix signout redirect_uri issue

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* remove signout url global

* style alignment

* remove legacy handlers for devenv

* Update pkg/api/login.go

---------

Co-authored-by: Rao B V Chalapathi <b_v_chalapathi.rao@nokia.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: jguer <me@jguer.space>
 2023-08-29 11:34:11 +02:00
Jo
a307582212 Revert "Replace signed in user for identity.requester (#73750)" (#73962) 
This reverts commit 9b9c9e83dc.
 2023-08-28 21:05:59 +02:00
linoman
9b9c9e83dc Replace signed in user for identity.requester (#73750) 
* Make identity.Requester available at Context

* Clean pkg/services/guardian/guardian.go

* Clean guardian provider and guardian AC

* Clean pkg/api/team.go

* Clean ctxhandler, datasources, plugin and live

* Question: what to do with the UserDisplayDTO?

* Clean dashboards and guardian

* Remove identity.Requester from ReqContext

* Implement NewUserDisplayDTOFromRequester

* Fix tests

* Change status code numbers for http constants

* Upgrade signature of ngalert services

* log parsing errors instead of throwing error

* Fix tests and add logs

* linting
 2023-08-28 12:04:36 -05:00
Jo
5eed495cce Chore: Port user services to identity.Requester (#73851) 
* port api key api to signedinuser

* port users to signed in user interface

* fix tests
 2023-08-28 10:42:24 +02:00
Karl Persson
01d98114b9 Authz: fix snapshot tests legacy guardian (#73823) 
* Guardian: remove unused dependencies

* API: rewrite tests to use access control guardian
 2023-08-28 09:49:10 +02:00
Torkel Ödegaard
3ee26df41e PublicDashboards: Variables refactor (#73476) 
Co-authored-by: Juan Cabanas <juan.cabanas@grafana.com>
Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
 2023-08-25 13:56:02 -05:00
Ieva
ca46a5c1af Chore: prepare for removing RBACenabled config option (#73845) 
prepare for removing RBACenabled config option
 2023-08-25 17:13:46 +02:00
Ieva
6885b3d577 Chore: remove checks for whether RBAC is disabled (#73812) 
* remove checks for whether access control is disabled, as it is always enabled now

* linting
 2023-08-25 14:19:58 +01:00
Serge Zaitsev
00893a158c Chore: return a JSON on folder DELETE (#73604) 2023-08-24 18:10:58 +02:00
Karl Persson
05c386504b authz: Clean up acl endpoints and dashboard guardian (#73746) 
* RBAC: remove unnessisary guardian construction and update tests

* RBAC: remove usage of guardian in UpdateFolderPermissions and refactor test

* RBAC: remove usage of guardian in update and get permissions for dashboards
 2023-08-24 15:37:54 +02:00
Marcus Efraimsson
040b7d2571 Chore: Add errutils helpers (#73577) 
Add helpers for the errutil package in favor of errutil.NewBase.
 2023-08-22 12:52:24 +02:00
Ieva
ec9c35fae5 Chore: clean up access control for data sources (#73010) 
* move DS guardian interfaces to OSS, move allow guardian to OSS

* update codeowner file
 2023-08-21 14:26:49 +01:00
Joao Silva
3bb23d6be7 Whitelabeling: Add a config option to hide the Grafana edition from the footer (#73412) 2023-08-18 15:09:36 +01:00
Jo
26339f978b Auth: Move access control API to SignedInUser interface (#73144) 
* move access control api to SignedInUser interface

* remove unused code

* add logic for reading perms from a specific org

* move the specific org logic to org_user.go

* add a comment

---------

Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com>
 2023-08-18 11:42:18 +01:00
Will Browne
3c50db328d Plugins: Make Installer responsible for removing plugins from file system (#73323) 
* installer is responsible for removing from file system

* take plugin as arg

* remove resolve step

* return plugin in test
 2023-08-16 15:44:20 +02:00
Carl Bergquist
243b757168 Middleware: Add team metadata to HTTP handlers (#71010) 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
 2023-08-16 15:05:19 +02:00
Karl Persson
43aab615c3 Auth: Remove unused Authenticator service (#73143) 
Auth: remove unused Authenticator service
 2023-08-10 11:02:32 +02:00
Will Browne
d29f4a8f76 Plugins: Add context to StaticRouteResolver and ErrorResolver interfaces (#73121) 
* add ctx

* fix tests
 2023-08-10 10:32:12 +02:00
Karl Persson
2c57bca176 Auth: Remove auth broker flag and clean up login handlers (#73109) 
* Auth: Remove auth broker flag and clean up login handlers
 2023-08-10 09:56:04 +02:00
Will Browne
72da44db0e Plugins: Add validation stage to plugin loader pipeline (#73053) 
* first pass

* change validation signature

* err tracking

* fix

* undo golden

* 1 more

* fix

* adjust doc

* add test helper

* fix linter
 2023-08-09 18:25:28 +02:00
Michael Mandrus
779e0fe311 Feature Toggles: Create API for updating feature toggle state from the feature toggle admin page (#73022) 
* create roles for writing feature toggles

* create update endpoint / handler

* api changes

* add feature toggle validations

* hide toggles based on their state

* make FlagFeatureToggle read only

* add username log

* add username string

* refactor for better readability

* refactor unit tests so we can do more validations

* some skeletoning for the set tests

* write unit tests for updater

* break helper functions out

* update sample ini to match defaults

* add more logic to ReadOnly label

* add user documentation

* fix lint issue

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: J Stickler <julie.stickler@grafana.com>

---------

Co-authored-by: IbrahimCSAE <ibrahim.mdev@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
 2023-08-09 11:32:28 -04:00
Karl Persson
e53e22ef2a Contexthandler: Remove code that is no longer used (#73101) 
* Contexthandler: remove dead code

* Contexthandler: Add tests

* Update pkg/tests/api/alerting/api_alertmanager_test.go

Co-authored-by: Jo <joao.guerreiro@grafana.com>

---------

Co-authored-by: Jo <joao.guerreiro@grafana.com>
 2023-08-09 15:17:59 +02:00
Jo
5d8e6aa162 Auth: Org Invite and Team API SignedInUser interfacing (#73085) 
* fix ngalert Evaluate sig change

* interface for teams and org invites

* Update pkg/api/org_invite.go

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>

---------

Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>
 2023-08-09 12:33:35 +02:00
Karl Persson
144e4887ee Auth: Use authn.Service for all tests (#72921) 
* Dashboards: Fix tests when authn broker is enabled.
StarService was not configured for tests, the call was guarded by !c.IsSignedIn

* Change default to be anon user to match expectations from tests

* OAuth: rewrite tests to work with authn.Service

* Setup template renderer by default

* Extract cookie options from cfg instead of relying on global variables

* Fix test to work with authn service

* Middleware: rewrite auth tests

* Remvoe session cookie if we cannot refresh access token
 2023-08-09 08:54:52 +02:00
Maksym Revutskyi
d9c232b331 Auth: prevent auto_login redirect if user is already authenticated (#72477) 
* Auth: prevent auto_login redirect if user is already authenticated

Before attempting an auto-login for OAuth, verifies if current context has already been
authenticated.

Fixes: #72476

Co-authored-by: Karl Persson <kalle.persson92@gmail.com>
 2023-08-07 09:14:31 +02:00
Will Browne
98f827537b Plugins: Add remaining steps to inititialization stage (#72894) 
add remainder of init steps
 2023-08-04 12:35:57 +02:00
Will Browne
60b4a0b2a4 Plugins: Add termination stage to plugin loader pipeline (#72822) 
* add termination stage

* uid -> pluginID (for now)

* also fix fakes

* add simple test

* Fix logger name

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>

* inline stop func call

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>

---------

Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>
 2023-08-04 11:57:49 +02:00
Josh Hunt
7bc6d32eb9 Search API: Search by folder UID (#65040) 
* Search: Attempt to support folderUID filter

* Search: Use folder UID instead of ID for searching folders

* Update swagger

* Fix JSON property casing

* Add integration test

* Remove redundant query condition

* Fix frontend test

* Fix listing dashboards in General/root

* Add support for fetching top level folders

using `folderUIDs=` (empty string) query parameter

* Add deprecation notice

* Send uid of general in sql.ts

* Use 'general' for query folderUIDs query param for fetching folder

* Add tests

* Fix FolderUIDFilter

---------

Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
 2023-08-04 12:43:47 +03:00
Ibrahim
0d48ac2419 Feat: Feature toggle admin page frontend interface (#72164) 
* feature toggles admin page proto

* feature toggle admin page proto

* keep phase 1 code only

* latest update with api

* fix

* fix

* add correct premissions in admin.go

* move behind toggle

* Use InteractiveTable

* guard behind feature toggle

* use RTK

* route in api.go

* fixes
 2023-08-03 14:17:00 -04:00