9340430723
Chore: Add alert ctx ( #41161 )
...
* Add context for alert
* Remove context.TODO
* Remove xorm
* Remove context.TODO
* Fix UsageStatsQuerier interface
2021-11-03 14:10:39 +01:00
47f6bb3583
Chore: Add context to org ( #40685 )
...
* Add context to org
* Rebase
* Fix rebase
2021-11-03 11:31:56 +01:00
7b15cd0ed2
Chore: Refactor GoConvey in provisioning package ( #40892 )
...
* refactor goconvey in some provisioning subpackages
* fix goconvey in provisioning/datasources
* remove goconvey from notifiers subpackage
* finally resolve goconvey in dashboards subpackage
2021-11-01 11:31:55 +01:00
2759b16ef5
Chore: Add context for dashboards ( #39844 )
...
* Add context for dashboards
* Remove GetDashboardCtx
* Remove ctx.TODO
2021-10-05 13:26:24 +02:00
fa9857499b
Chore: GetDashboardQuery should be dispatched using DispatchCtx ( #36877 )
...
* Chore: GetDashboardQuery should be dispatched using DispatchCtx
* Fix after merge
* Changes after review
* Various fixes
* Use GetDashboardCtx function instead of GetDashboard
2021-09-14 16:08:04 +02:00
643c7fa0cb
Chore: update all +build statements ( #38782 )
2021-09-01 17:38:56 +03:00
ec9a587cbe
Provisioning: Improve validation by validating across all dashboard providers ( #26742 )
...
* Provisioning: check sanity across all dashboard readers
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Apply suggestions from code review
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Refactor of duplicateValidator and fix issues according to commentaries
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove newDuplicateEntries function
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Change folderUid in logs to folderUID
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Restrict write access for readers, which are provisioning duplicate dashboards
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Fix file reader after rebasing onto master
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Format file_reader
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix lint problem
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Apply suggestions from code review
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
2021-07-21 17:52:41 +02:00
a151dfaa04
ProvisioningService: Change the ProvisioningService interface for easier extension ( #32910 )
...
* Made a public constructor in order to instantiate it from the service override
* Removed unused plugins.DataRequestHandler
* Added a Run and RunInitProvisioners methods that can be run from Enterprise
* Adding a mock for Run and RunInitProvisioners as well
2021-04-21 13:41:34 +02:00
7b7ea5a1ce
Provisioning: Use dashboard checksum field as change indicator ( #29797 )
...
* Add tests for checksum validation
Check dashboard checksum for provisioned dashboards
Remove extra error
Remove extra error
Ignore mtime when checking privisioned dashboards; Fix tests
Fix linting errors
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Clean up tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-04-13 17:02:25 +02:00
87c3a2b790
PluginManager: Make Plugins, Renderer and DataSources non-global ( #31866 )
...
* PluginManager: Make Plugins and DataSources non-global
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix integration tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Replace outdated command
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* DashboardService: Ensure it gets constructed with necessary parameters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix build
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* DashboardService: Ensure it gets constructed with necessary parameters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove dead code
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove FocusConvey
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove dead code
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Undo interface changes
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Backend: Move tsdbifaces.RequestHandler to plugins.DataRequestHandler
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Rename to DataSourceCount
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Consolidate dashboard interfaces into one
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix dashboard integration tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-03-17 16:06:10 +01:00
1716de88b5
DashboardService: Consolidate constructors ( #31886 )
...
* DashboardService: Consolidate constructors
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-03-12 11:51:02 +01:00
116809ed7f
services/provisioning: Various cleanup ( #30396 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-01-19 18:57:09 +01:00
25048ebdf8
Chore: Add CloudWatch HTTP API tests ( #29691 )
...
* CloudWatch: Add HTTP API tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-01-07 11:36:13 +01:00
f326b79cc1
Security: Add gosec G304 auditing annotations ( #29578 )
...
* Security: Add gosec G304 auditing annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* add G304 auditing comment
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* space
Signed-off-by: bergquist <carl.bergquist@gmail.com >
* Add gosec annotations
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: bergquist <carl.bergquist@gmail.com >
2020-12-03 22:13:06 +01:00
f2b7fbc32a
Chore: Check errors from Close calls ( #29562 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-12-03 10:11:14 +01:00
9593d57914
Chore: Enable errorlint linter ( #29227 )
...
* Enable errorlint linter
* Handle wrapped errors
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
2020-11-19 14:47:17 +01:00
7897c6b7d5
Chore: Fix staticcheck issues ( #28854 )
...
* Chore: Fix issues reported by staticcheck
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Undo changes
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-11-05 11:57:20 +01:00
6e3e0dead8
Provisioning: Remove provisioned dashboards without parental reader ( #26143 )
2020-09-11 09:19:44 +02:00
b646a1d627
Provisioning: describe which folder caused an error while provisioning from files structure ( #26771 )
...
* Provisioning: describe which folder caused an error while provisioning from files structure
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Apply suggestions from code review
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove unused DashType constants
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com >
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-08-04 09:03:09 -07:00
ba2524cd88
Provisioning: Add validation for missing organisations in datasource, dashboard, and notifier configurations ( #26601 )
...
* Provisioning: Check that org. from config exists
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix some code after applying suggestions
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
* Add negative test case
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com >
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-07-30 12:59:12 +03:00
41d432b5ae
Chore: Enable whitespace linter ( #25903 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-07-06 20:17:28 +02:00
810ec4c5f8
Provisioning: Use folders structure from the file system to create desired folders in dashboard provisioning. ( #23117 )
...
Fixes #12016
2020-06-30 15:33:26 +02:00
07582a8e85
Chore: Fix various spelling errors in back-end code ( #25241 )
...
* Chore: Fix various spelling errors in back-end code
Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com >
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com >>
2020-06-01 17:11:25 +02:00
c62591e77b
Provisioning: Makes file the default dashboard provisioner type ( #24856 )
...
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-05-19 15:01:04 +02:00
5fc255bd89
Linting fixes for provisoning ( #23600 )
2020-04-16 05:46:20 +02:00
80f40040b0
Linting fixes for dashboard provsioning ( #23576 )
2020-04-15 08:12:52 +02:00
9f2af718dc
Provisioning: Validate that dashboard providers have unique names ( #22898 )
...
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
Co-authored-by: bergquist <carl.bergquist@gmail.com >
2020-04-14 20:54:00 +02:00
69c5efcf00
Cleanup: move interface ProvisioningService into provisioning package ( #23061 )
2020-03-25 14:14:24 +01:00
06bf7e8ef1
OAuth: Removes send_client_credentials_via_post setting ( #20044 )
...
Removes send_client_credentials_via_post oauth setting and
use auto-detect mechanism instead.
By these changes also fixes statichcheck errors
Ref #8968
2019-12-12 20:00:56 +01:00
b489c75aaf
Provisioning: fix for cannot save provisioned dashboard ( #20218 )
...
Provisioning of dashboards now always overwrite existing ones and does not look at the configuration `allowUiUpdates` anymore
2019-11-07 10:49:24 +01:00
a45ce36566
Allow saving of provisioned dashboards ( #19820 )
...
Allows saving of provisioned dashboards if the config value allowUiUpdates is set to true
Fixes #11778
2019-10-31 14:27:31 +01:00
caa1314f44
Build: use golangci-lint as a make command ( #17739 )
...
* Build: use golangci-lint as a make command
* Since gometalinter was deprecated in favor of golangci-lint so it was
replaced by it. Responsibilities held by the gometalinter was moved to
golangci-lint
* There was some changes in implementation (that was also mentioned in
the code comment) between the tools, which uncovered couple errors
in the code. Those issues were either solved or disabled by
the inline comments
* Introduce the golangci-lint config, to make their
configuration more manageable
* Build: replace backend-lint.sh script with make
2019-07-02 16:06:59 +03:00
c8382ba435
Provisioning: Support folder that doesn't exist yet in dashboard provisioning ( #17407 )
...
closes #17320
2019-06-04 22:23:08 +02:00
be66ed9dab
Chore: explore possibilities of using makefile ( #17039 )
...
* Chore: explore possibilities of using makefile
This is an exploratory commit - I wanted to see how
revive/gosec linters could be integrated with makefile and our build scripts.
Looks better then I expected :)
* Chore: make revive happy
Revive execution was not supplied with path, if you restore there is couple
errors that were popping up - so I fixed them
* Chore: make revive happy
2019-05-16 00:29:26 +03:00
c55e6016bf
backend: replace /pkg/errors with errutil ( #17065 )
2019-05-15 12:20:17 +02:00
2fff8f77dc
move log package to /infra ( #17023 )
...
ref #14679
Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com >
2019-05-13 08:45:54 +02:00
eb82a75668
Provisioning: Show file path of provisioning file in save/delete dialogs ( #16706 )
...
* Add file path to metadata and show it in dialogs
* Make path relative to config directory
* Fix tests
* Add test for the relative path
* Refactor to use path relative to provisioner path
* Change return types
* Rename attribute
* Small fixes from review
2019-04-30 13:32:18 +02:00
42b745a098
Provisioning: Add API endpoint to reload provisioning configs ( #16579 )
...
* Add api to reaload provisioning
* Refactor and simplify the polling code
* Add test for the provisioning service
* Fix provider initialization and move some code to file reader
* Simplify the code and move initialization
* Remove unused code
* Update comment
* Add comment
* Change error messages
* Add DashboardProvisionerFactory type
* Update imports
* Use new assert lib
* Use mutext for synchronizing the reloading
* Fix typo
Co-Authored-By: aocenas <mr.ocenas@gmail.com >
* Add docs about the new api
2019-04-25 09:06:44 +02:00
fcebd713a5
Provisioning: Interpolate env vars in provisioning files ( #16499 )
...
* Add value types with custom unmarshalling logic
* Add env support for notifications config
* Use env vars in json data tests for values
* Add some more complexities to value tests
* Update comment with example usage
* Set env directly in the tests, removing patching
* Update documentation
* Add env var to the file reader tests
* Add raw value
* Post merge fixes
* Add comment
2019-04-24 15:39:47 +02:00
fca5ee4bea
Provisioning: Support FolderUid in Dashboard Provisioning Config ( #16559 )
...
* add folderUid to DashbaordsAsConfig structs and DashbardProviderConfigs struct, set these values in mapping func
look for new folderUid values in config_reader tests
set dashboard folder Uid explicitly in file_reader, which has no affect when not given
* formatting and docstrings
* add folderUid to DashbaordsAsConfig structs and DashbardProviderConfigs struct, set these values in mapping func
look for new folderUid values in config_reader tests
set dashboard folder Uid explicitly in file_reader, which has no affect when not given
* formatting and docstrings
* add folderUid option, as well as documentation for the rest of the fields
* add blank folderUid in devenv example.
* add folderUid to provisioning sample yaml
* instead of just warning, return error if unmarshalling dashboard provisioning file fails
* Removing the error handling and adding comment
* Add duplicity check for folder Uids
Co-authored-by: swtch1 <joshua.thornton@protonmail.com >
2019-04-24 08:57:42 +02:00
2d7fc55df7
Provisioning: Do not allow deletion of provisioned dashboards ( #16211 )
...
* Unprovision dashboard in case of DisableDeletion = true
* Rename command struct
* Handle removed provision files
* Allow html in confirm-modal
* Do not show confirm button without onConfirm
* Show dialog on deleting provisioned dashboard
* Changed DeleteDashboard to DeleteProvisionedDashboard
* Remove unreachable return
* Add provisioned checks to API
* Remove filter func
* Fix and add tests for deleting dashboards
* Change delete confirm text
* Added and used pkg/errors for error wrapping
2019-04-10 13:29:10 +02:00
b4267eafb8
log root cause error when reading from provisioning directories
2019-02-07 15:46:57 +01:00
8880829eda
avoid infinite loop in the dashboard provisioner
...
if one dashboard with an uid is refered to by two
provsioners each provsioner overwrite each other.
filling up dashboard_versions quite fast if using
default settings.
ref #12864
2019-01-14 16:38:39 +01:00
92a8c5b81b
log error when resolvePath
2018-12-13 02:10:29 -08:00
4498d75b17
provisioning: adds more logging about failed to deletion of provisioned dashboards
2018-10-03 17:38:10 +02:00
464f3f738f
Merge pull request #13360 from sapcc/symlinks
...
resolve symlink on each run
2018-09-27 09:21:29 +02:00
862ca07f03
fix: updated tests
2018-09-25 14:01:38 +02:00
98dad530e2
provisioning: changed provisioning default update interval from 3 to 10 seconds
2018-09-22 10:06:57 +02:00
1355c00c44
fix reader linux test
2018-09-20 13:42:56 +02:00
6b2d91815a
resolve symlink on each run
2018-09-20 11:46:32 +02:00
idafurjes
Serge Zaitsev
Marcus Efraimsson
Maksim Nabokikh
gamab
Cristian C
Arve Knudsen
Maksim Nabokikh
Carl Bergquist
Artur Kondas
huanggze
Alexander Morozov
Jon Gyllenswärd
Oleg Gaidarenko
Augustin Husson
Carl Bergquist
zhulongcheng
Andrej Ocenas
Josh
Joesis
Torkel Ödegaard
Arno Uhlig