d5ae55c5dd
NGAlert: Add message field to email notification channel ( #34044 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
2021-05-17 16:05:09 +05:30
1367f7171e
Alerting/ruler metrics ( #34144 )
...
* adds active configurations metric
* rule evaluation metrics
* ruler metrics
* pr feedback
2021-05-14 16:13:44 -04:00
eb74994b8b
Alerting: Modify configuration apply and save semantics - v2 ( #34143 )
...
* Save default configuration to the database and copy over secure settings
2021-05-14 19:49:54 +01:00
c778d6a4a2
Library Panels: Add name endpoint & unique name validation to AddLibraryPanelModal ( #33987 )
2021-05-14 15:03:37 +01:00
fc90c36d50
removes unused db method ( #34082 )
2021-05-13 20:28:10 +02:00
baca873a84
extracts alertmanager from DI, including migrations ( #34071 )
...
* extracts alertmanager from DI, including migrations
* includes alertmanager Run method in ngalert
* removes 3s test shutdown timeout
* lint
2021-05-13 14:01:38 -04:00
ec3214bac2
NGAlert: Add integration tests for notification channels ( #33431 )
...
* NGAlert: Add integration tests for notification channels
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Fix the failing tests
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Fix review comments
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
* Override creation of rule UID, remove only namespace UID
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
2021-05-13 22:58:19 +05:30
babb17afd6
Alerting/Chore: Move tests from tests package ( #34059 )
...
Instead put in package folder but with package name suffixed with _test
This enables code coverage within the pkg while still allow the tests to operate from external to package perspective (only exported things).
2021-05-13 10:05:33 -04:00
5f44ccff0c
NGAlert: Fix unit test to write files in temporary directory ( #34032 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
2021-05-13 16:08:12 +05:30
e97750b824
Live: labels column as default frame format ( #33984 )
...
* labels columns as default frame format
* update sdk
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
2021-05-13 11:01:20 +02:00
83abaa8bdf
Quota: Do not count folders towards dashboard quota ( #32519 )
...
For dashboard quota fix so that folders are not counted as dashboards.
Fixes #31317
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
2021-05-12 23:44:46 +02:00
c2e761f28e
Access control: Attach ID to error message ( #33472 )
2021-05-12 23:00:27 +02:00
a14ae53347
UseRunStream is a default behaviour ( #34021 )
2021-05-12 22:17:31 +03:00
3da8db7f3f
Alerting: Run table migrations regardless of feature flag and move out of service ( #33996 )
2021-05-12 14:39:48 -04:00
2459a0ceb5
live: remove demultiplexor ( #34012 )
2021-05-12 18:47:03 +03:00
ec71919e7b
Rendering: add CSV support ( #33729 )
...
* Rendering: add CSV rendering support
* Rendering: save csv files into a separate folder
* add missing field
* Renderer: get filename from renderer plugin
* apply PR suggestions
* Rendering: remove old PhantomJS error
* Rendering: separate RenderCSV and Render functions
* fix alerting test
* Rendering: fix handling error in HTTP mode
* apply PR feedback
* Update pkg/services/rendering/http_mode.go
Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com >
* apply PR feedback
* Update rendering metrics with type label
* Rendering: return error if not able to parse header
* Rendering: update grpc generated file
* Rendering: use context.WithTimeout to render CSV too
Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com >
2021-05-12 17:16:57 +02:00
f2fcf721eb
32540: Add org users with pagination ( #33788 )
...
* Add model for search org user and add handler for dispatch
* 32540_org_users_with_pagination: Add endpoint for search org users
* 32540_org_users_with_pagination: Add test for org user search handler
* 32540_org_users_with_pagination: fix indentation
* 32540_org_users_with_pagination: Remove newline
* 32540_org_users_with_pagination: Remove empty line
* 32540_org_users_with_pagination: Fix indentation
* Update pkg/api/org_users.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/models/org_user.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* 32540_org_users_with_pagination: Use hs.SQLStore.SearchOrgUsers instead of bus
* Add model for search org user and add handler for dispatch
* 32540_org_users_with_pagination: Add endpoint for search org users
* 32540_org_users_with_pagination: Add test for org user search handler
* 32540_org_users_with_pagination: fix indentation
* 32540_org_users_with_pagination: Remove newline
* 32540_org_users_with_pagination: Remove empty line
* 32540_org_users_with_pagination: Fix indentation
* Update pkg/api/org_users.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/models/org_user.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* 32540_org_users_with_pagination: Use hs.SQLStore.SearchOrgUsers instead of bus
* 32540_org_users_with_pagination: Add test for the sqlstore
* 32540_org_users_with_pagination: Fix sqlstore test
* Update pkg/api/org_users.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/api/org_users_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/sqlstore/org_users.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/sqlstore/org_users.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/sqlstore/org_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/sqlstore/org_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* 32540: Fix search org users method
* 32540: Fix sqlstore test
* 32540: Fix go-lint
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-05-12 14:10:35 +02:00
3b06f52bab
Alerting/allow empty receiver ( #33962 )
...
* simplifies yaml unmarshaling: PostableApiReceiver
* allow empty receiver type
* allows name only receivers (blackhole)
* better receiver type parsing
* linting
2021-05-12 07:58:16 -04:00
a735c51202
Alerting/Chore: Backend remove def_ columns from instance ( #33875 )
...
rename def_uid and def_org_id to rule_uid and rule_org_id on the alert_instance table and drops the definition table.
2021-05-12 07:17:43 -04:00
8d442c9b44
NGAlert: Fix templating and remove unwanted default templates ( #33918 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
2021-05-12 15:13:43 +05:30
b0094b325e
Annotations: Prevent orphaned annotation tags cleanup when no annotations were cleaned ( #33957 )
...
Fixes #33948
Co-authored-by: Anatoly Fayngelerin <afayngelerin@dropbox.com >
2021-05-12 10:44:00 +02:00
a7ea0ca849
refactory to move trim/apply default into schema.go ( #33754 )
...
* refactory to move trim/apply default into schema.go
* fix comments
* move schema test outside of load folder
2021-05-12 15:38:00 +08:00
69d9f427e1
LibraryPanels: removes feature toggle ( #33839 )
...
* WIP: intial structure
* Refactor: adds create library element endpoint
* Feature: adds delete library element
* wip
* Refactor: adds get api
* Refactor: adds get all api
* Refactor: adds patch api
* Refactor: changes to library_element_connection
* Refactor: add get connections api
* wip: in the middle of refactor
* wip
* Refactor: consolidating both api:s
* Refactor: points front end to library elements api
* Tests: Fixes broken test
* LibraryPanels: removes feature toggle
* Fix: fixes delete library elements in folder and adds tests
* Tests: fixes snapshot
* Refactor: adds service interfaces so they can be easily mocked
* Refactor: changes order of tabs in manage folder
* Refactor: fixes so link does not cover whole card
* Refactor: fixes index string name
* Update pkg/services/libraryelements/libraryelements.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/libraryelements/libraryelements_permissions_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/libraryelements/database.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Chore: changes after PR comments
* Update libraryelements.go
* Update libraryelements.go
* Chore: updates after PR comments
* Chore: trying to fix build error
* Refactor: fixed stupid mistake
* Update libraryelements.go
* Chore: tries to fix build errors
* Refactor: trying to fix MySQL key length
* Update libraryelements.go
* Update pkg/services/libraryelements/libraryelements.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/librarypanels/librarypanels.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Refactor: changes after PR comments
* Refactor: changes after PR comments
* Tests: fixes tests
* Refactor: renames connections to connectedDashboards
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-05-12 08:48:17 +02:00
95a356a840
Live: using organisation IDs throughout stack ( #33714 )
2021-05-11 22:03:04 +03:00
dc3e17ba5b
Alerting: Change rule migration to be based on feature flag ( #33792 )
...
makes it so the feature flag can be turned on off, and the migration will be cleared and rerun. All existing NG alert rules, configuration settings, etc are removed when disabling the feature flag.
for https://github.com/grafana/alerting-squad/issues/142
Co-authored-by: Sofia Papagiannaki <sofia@grafana.com >
2021-05-11 08:08:39 -04:00
f4750fb3c8
[Alerting]: Alertmanager API apply permissions ( #33843 )
...
* [Alerting]: Alertmanager API apply permissions
* Apply suggestions from code review
2021-05-11 11:31:38 +03:00
f1b2c750e5
LibraryElements: Adds library elements api and tables ( #33741 )
...
* WIP: intial structure
* Refactor: adds create library element endpoint
* Feature: adds delete library element
* wip
* Refactor: adds get api
* Refactor: adds get all api
* Refactor: adds patch api
* Refactor: changes to library_element_connection
* Refactor: add get connections api
* wip: in the middle of refactor
* wip
* Refactor: consolidating both api:s
* Refactor: points front end to library elements api
* Tests: Fixes broken test
* Fix: fixes delete library elements in folder and adds tests
* Refactor: changes order of tabs in manage folder
* Refactor: fixes so link does not cover whole card
* Update pkg/services/libraryelements/libraryelements.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/libraryelements/libraryelements_permissions_test.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Update pkg/services/libraryelements/database.go
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
* Chore: changes after PR comments
* Update libraryelements.go
* Chore: updates after PR comments
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-05-11 07:10:19 +02:00
e18ca8f6f2
enforce receivers align with backend type when posting AM config ( #33877 )
2021-05-10 16:58:41 -04:00
c610eff5cd
live: move connection endpoint to api scope, fixes #33861 ( #33863 )
2021-05-10 19:56:02 +03:00
7367cfc0a3
Add isolation level db configuration parameter ( #33830 )
...
* add isolation level db configuration parameter
* add isolation_level to default.ini and sample.ini
* add note that only mysql supports isolation levels for now
* mention isolation_level in the documentation
* Update docs/sources/administration/configuration.md
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com >
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com >
2021-05-10 17:54:13 +02:00
da13f88862
Redact sensitive values before logging them ( #33829 )
...
* use a common way to redact sensitive values before logging them
* fix panic on missing testCase.err, simplify require checks
* fix a silly typo
* combine readConfig and buildConnectionString methods, as they are closely related
2021-05-10 17:03:10 +02:00
8feeaab996
Alerting: Disable dash alerting if NG enabled ( #33794 )
2021-05-10 10:46:01 -04:00
1c58fd380f
[Alerting]: store encrypted receiver secure settings ( #33832 )
...
* [Alerting]: Store secure settings encrypted
* Move encryption to the API handler
2021-05-10 15:30:42 +03:00
1d15686bdf
Access control: Add a role for provisioning admins ( #33787 )
2021-05-10 11:46:42 +02:00
bfd5d3b16a
Live: streamId in path for ws push endpoint ( #33786 )
2021-05-06 12:28:14 -07:00
e58aca2d20
Alerting: remove instances from db and cache on rule update ( #33722 )
...
* remove instances from db and cache on rule update
* fix panic
* rename
2021-05-06 18:39:34 +02:00
c2c1ec7d0f
Chore: Move from master to main branch ( #33693 )
...
* Chore: Move from master branch to main
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* CI: Upgrade build pipeline tool to v2
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-05-06 16:29:29 +02:00
fae093bbe2
Alerting: Fix state cache getOrCreate panic ( #33777 )
2021-05-06 14:35:52 +02:00
e642506dcb
use dynamic ID in test assertion for search ( #33320 )
2021-05-06 10:48:33 +02:00
a5ae8cf377
Unredact/secret ( #33723 )
...
* no longer redacts GETing proxied AM configs
* removes unused testfile
* testware fix
* consistently roundtrips yaml<>json and doesnt redact secrets
* lint
2021-05-05 16:21:53 -04:00
bd66c8dde3
SQL data sources: Convert to return data frames ( #32257 )
...
Convert SQL data sources to return data frames.
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Will Browne <will.browne@grafana.com >
Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com >
2021-05-05 16:46:07 +02:00
1b8c0ce88b
NGAlert: Fix some TODOs in notification channels ( #33739 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
2021-05-05 17:48:40 +05:30
605bae8e2c
LibraryPanels: Adds folder name to Library Panel card ( #33697 )
...
* LibraryPanels: Adds folder filter
* Refactor: Adds folder filter to library search
* Refactor: splits huge function into smaller functions
* LibraryPanels: Adds Panels Page to Manage Folder tabs (#33618 )
* Chore: adds tests to LibraryPanelsSearch
* Refactor: Adds reducer and tests
* Chore: changes GrafanaThemeV2
* Refactor: adds folderName to get all result
* Refactor: adds folderName to get result
* Refactor: adds folder name to LibraryPanelDTOMeta
* Refactor: adds folder name to lbirary panels result
* Chore: reverts public/app/routes/routes.tsx to master
* Minor style tweak
* Refactor: adds folder uid to meta
* Chore: updates after PR comments
Co-authored-by: Torkel Ödegaard <torkel@grafana.com >
2021-05-05 11:09:12 +02:00
b1a8c67689
Alerting return evaluation errors to /rules ( #33663 )
...
* Set and return errors produced by evaluation results
* test fixup
2021-05-04 13:08:12 -04:00
39099bf3c0
Alerting nested state cache ( #33666 )
...
* nest cache by orgID, ruleUID, stateID
* update accessors to use new cache structure
* test and linter fixup
* fix panic
Co-authored-by: Kyle Brandt <kyle@grafana.com >
* add comment to identify what's going on with nested maps in cache
Co-authored-by: Kyle Brandt <kyle@grafana.com >
2021-05-04 09:57:50 -07:00
5072fefc22
allow saving pending alerts ( #33667 )
2021-05-04 09:24:20 -07:00
540f110220
[Alerting]: Extend quota service to optionally set limits on alerts ( #33283 )
...
* Quota: Extend service to set limit on alerts
* Add test for applying quota to alert rules
* Apply suggestions from code review
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com >
* Get used alert quota only if naglert is enabled
* Set alert limit to zero if nglalert is not enabled
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com >
2021-05-04 19:16:28 +03:00
33e4f8d7ac
Live: remove feature toggle and enable by default ( #33654 )
2021-05-04 08:44:55 -07:00
c6d4d14a89
LibraryPanels: Adds folder filter to manage library panel page ( #33560 )
...
* LibraryPanels: Adds folder filter
* Refactor: Adds folder filter to library search
* Refactor: splits huge function into smaller functions
* LibraryPanels: Adds Panels Page to Manage Folder tabs (#33618 )
* Chore: adds tests to LibraryPanelsSearch
* Refactor: Adds reducer and tests
* Chore: changes GrafanaThemeV2
* Refactor: pulls everything behind the feature toggle
* Chore: removes clear icon from FolderFilter
* Chore: adds filter to SortPicker
* Refactor: using useAsync instead
2021-05-04 13:59:40 +02:00
918552d34b
NGAlert: Send list of available ngalert notification channels via API ( #33489 )
...
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com >
2021-05-04 13:58:39 +02:00
Ganesh Vernekar
Owen Diehl
gotjosh
kay delaney
Kyle Brandt
Alexander Emelin
Conor Evans
Emil Tullstedt
Agnès Toulet
idafurjes
afayngelerindbx
ying-jeanne
Hugo Häggmark
Sofia Papagiannaki
Serge Zaitsev
Vardan Torosyan
David Parrott
Arve Knudsen
Dafydd
Ryan McKinley