Commit Graph
36339 Commits
Author SHA1 Message Date
Joe Blubaugh 481a68cbf5 Unified Alerting: Make log message follow codebase convention. (#46881)
1. Keep log lines lower case.
2. The key-value pair arguments are not format argument for the string.
3. Always use the "err" key.
2022-03-23 15:07:07 +01:00
idafurjes 77976ea810 Add fakes for db interface (#46885) 2022-03-23 15:06:47 +01:00
Torkel Ödegaard 72b6f64df9 Theme: Increase contrast for overlays and drawers (#46630) 2022-03-23 14:47:33 +01:00
87a883ec62 Update dependency stylelint to v14.6.0 (#46626)
* Update dependency stylelint to v14.6.0

* remove old rule that wasn't working properly

* Revert "remove old rule that wasn't working properly"

This reverts commit 41a96ebad2.

* allow any border values

* fix typo

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2022-03-23 13:40:54 +00:00
Sarah Zinger dd49f9d182 Azure Monitor: Small bug fixes for Resource Picker (#46665)
- fixes issue with checkbox styling
- fixes issue with selecting subscriptions
2022-03-23 09:38:46 -04:00
721c3207e9 Update dependency prettier to v2.6.0 (#46612)
* Update dependency prettier to v2.6.0

* Keep toolkit in sync

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2022-03-23 11:34:45 +00:00
Will Browne 5e18293f88 Plugins: Make plugin loading from file system deterministic (#46842)
* Plugins: Make plugin loading from file system deterministic

* fix test name

* flip assertion arg order
2022-03-23 11:58:00 +01:00
Agnès Touletandachatterjee-grafana c31428128a Docs: improve Redis configuration doc for query caching (#46834)
* Docs: improve Redis configuration doc for query caching

* Apply suggestions from code review

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* fix small typo

* Update docs/sources/enterprise/enterprise-configuration.md

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2022-03-23 11:04:45 +01:00
Joe Blubaugh c5b39dd3cd Unified Alerting, Issue 41156: Clean up expired silences. (#46740)
Expired silences older than the retention period were not being cleaned up. The root problem was that notifier.Alertmanager overrides the Prometheus alert manager's silence maintenance function and was not calling Silences.GC() in the overriden function.
2022-03-23 09:49:02 +01:00
Jean-Philippe Quéméner a80f04c949 Alerting: add collision safe update function for alertmanager configurations (#46692)
* Alerting: add collision safe update function for alertmanager configurations

* fix typo

* use bootstrap func for tests

* move hash calculation to store

* remove icons lol

* remove removed field
2022-03-23 09:31:46 +01:00
Gabriel MABILLE ff3c1e3144 AccessControl: Handle ':' in attribute resolution (#46742)
* AccessControl: Handle ':' in attribute resolution

* Simplify based on assumption that prefixes will have maximum 2 parts
2022-03-23 08:48:32 +01:00
Torkel Ödegaard 76c9ad2d9b Loki: Improve operation ordering when adding new operations (#46598) 2022-03-23 07:42:25 +01:00
Torkel Ödegaard e10c4397dc Prometheus: Enable new visual query builder by default (#46634)
* Prometheus: Enable new query builder by default

* Updated e2e test

* Fixed e2e
2022-03-23 07:28:19 +01:00
achatterjee-grafana e0aaff86ae Docs: Removed incorrect bullet point from SAML authenticationhttps://github.com/grafana/grafana/issues/46605 topic (#46854)
* Removed incorrect bullet point.

* Empty-Commit
2022-03-22 18:00:19 -04:00
Kat Yang 884c2351d8 Chore: Remove x from org (#46851) 2022-03-22 21:17:53 +00:00
Jesse Weaver 560fc9812d Expose reporting-enabled flag to frontend (#46753) 2022-03-22 14:30:45 -06:00
Gilles De Mey 4a568769e7 Alerting: fix flakey test (#46845) 2022-03-22 21:20:58 +01:00
Karl Persson ee9badecdf Access Control: Add test flag to enable access control (#46780)
* Add feature flags options to test db
2022-03-22 20:48:32 +01:00
achatterjee-grafana 552b447946 update version (#46838) 2022-03-22 15:12:41 -04:00
Ashley Harrison 04bbafb4a6 Chore: Enable jest-fail-on-console to prevent console errors in unit tests (#46835)
* Add jest-fail-on-console

* Fix last 2 console warnings

* Update package syntax
2022-03-22 17:03:07 +00:00
Kevin Yu ba62f5ad5d Chore: clean up console warning from SQL Builder Editor tests (#46779)
* Chore: clean up console warning from SQL Builder Editor tests

* Re-add test for checking dimensions filter
2022-03-22 09:39:51 -07:00
achatterjee-grafana a0f5953cb3 Updated regex function (#46839) 2022-03-22 12:39:30 -04:00
dd2a952c29 Update sentry-javascript monorepo to v6.19.1 (#46799)
* Update sentry-javascript monorepo to v6.19.1

* fix breaking change

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Domas <domasx2@gmail.com>
2022-03-22 16:06:53 +01:00
idafurjes 5db1a2e804 Add DB interface (#46832) 2022-03-22 15:43:53 +01:00
Eng Zer Jun b56848f006 test: use T.TempDir to create temporary test directory (#44947)
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-03-22 15:43:29 +01:00
Simon Lundström 52fec0d7db Add back domain configuration (#46820)
It was lost in the PR #30695
2022-03-22 15:42:44 +01:00
Marcus Efraimsson be7bcbf94e Chore: Add tests for plugin settings sqlstore (#46792)
Follow up of #46777 adding tests for plugin settings in sqlstore package.
2022-03-22 15:34:27 +01:00
Selene b2af18f129 Chore: Remove bus from dashboard service (#46829)
* Move DeleteDashboard funtion into dashboards store service, remove bus and update tests

* Remove bus from folder service and update more tests

* Fix mock
2022-03-22 14:36:50 +01:00
Karl Persson bfb03d779d Access Control: Correctly check for id suffix (#46824)
* Correctly check for id suffix
2022-03-22 13:48:15 +01:00
Ashley Harrison 8159379ba6 Update stale.yml (#46827) 2022-03-22 13:21:14 +01:00
Karl Persson faf4a3f751 Access Control: Rename global users scope (#46794)
* Rename scope from global:users to global.users to match scope convention
2022-03-22 12:48:46 +01:00
ying-jeanne adc0cbf176 remove global variable in annotation (#46746)
* remove global varaible in annotation

* remove todo

* replace intransaction with withdbtransaction

* fix typo
2022-03-22 19:20:57 +08:00
renovate[bot]andRenovate Bot 3d43535bc3 Update typescript-eslint monorepo to v5.16.0 (#46809)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-22 10:20:05 +01:00
Serge Zaitsev 4ce7978cd8 Chore: Remove bus from notification service (#46813)
* Chore: Remove bus from notification service

* fix signature

* fix function signature in tests
2022-03-22 09:04:30 +01:00
Nathan RodmanandYuriy Tseretyan 5a25ada3d0 Alerting: Add FGAC for Silences (#46479)
* add FGAC actions for silences table

* redirect users without permissions

* hide silence button in rules list

* add permissions checks to routes

* add read action for silences page

* add permissions checks to navigation

* add additional access checks for rule viewing

* create authorize component

* add tests for silences

* hide alerting nav for users without access

* nolint: gocyclo

* add permission check to alert details

* add check for external instances

* remove unecessary new lines

* use correct actions for alert details

* fix failing tests

Co-authored-by: Yuriy Tseretyan <yuriy.tseretyan@grafana.com>
2022-03-21 16:54:37 -07:00
Yuriy Tseretyan 2ade8b56dd Alerting: support fine-grained access control in ruler update API (#45749)
* require Editor if FGAC is disabled. Otherwise, check `alert.rule:*` + `datasource:query` permissions when user changes rules.
2022-03-21 19:20:35 -04:00
Serge Zaitsev 9315ddd57c Chore: Remove bus from oauthtoken (#46811) 2022-03-21 21:13:57 +01:00
Tomas Rohrer 45745debe5 Fix anchor (#46797) 2022-03-21 15:46:01 -04:00
Serge Zaitsev cce46a6349 Chore: Remove bus from live package (#46803) 2022-03-21 20:34:19 +01:00
Kevin Yu 54d4a69e91 Chore: clean up console warning from Metrics Query Editor tests (#46747)
* Chore: clean up console warning from Metrics Query Editor tests

* Chore: remove type assertions
2022-03-21 12:21:04 -07:00
Kevin Yu 7480ba0226 Chore: clean up console warning from SQL Group By tests (#46733) 2022-03-21 12:20:48 -07:00
Shirley 499445a5f9 Azure Monitor: Bump core plugin version (#46776)
* Azure Monitor: Bump core plugin version

* Remove updated, update learn more link
2022-03-21 19:01:26 +01:00
Ezequiel Victorero c717320942 Adding FGAC annotations validation for creation and deletion (#46736)
Access Control: Adding FGAC annotations validation for creation and deletion
Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com>
2022-03-21 14:28:39 -03:00
Karl Persson 7ab1ef8d6e Access Control: Support other attributes than id for resource permissions (#46727)
* Add option to set ResourceAttribute for a permissions service
* Use prefix in access control sql filter to parse scopes
* Use prefix in access control metadata to check access
2022-03-21 17:58:18 +01:00
renovate[bot]andRenovate Bot 79f5c7d7a7 Update typescript-eslint monorepo to v5.15.0 (#46554)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-21 16:26:11 +00:00
Emil TullstedtandKarl Persson 0e5ac29763 Data sources: Grant creator edit permissions to data source by default (#46168)
* Data sources: Sent user ID when creating data source

* Data sources: Grant a data source creator edit permissions

* Use edit permisison and only append if user id is in command

Co-authored-by: Karl Persson <kalle.persson@grafana.com>
2022-03-21 17:16:05 +01:00
ying-jeanne 0d5a6c2194 remove bus from search and avoid import cycle (#46789)
* fix the import cicle

* fix some unittest

* fix removal bus from search
2022-03-21 23:54:30 +08:00
Fiona Artiagaandachatterjee-grafana 8199cc0cf8 Docs: Correct Team Sync availability (#45340)
Update the explanation of which users can use Team Sync

Co-authored-by: achatterjee-grafana <aparajita.chatterjee@grafana.com>
2022-03-21 11:42:06 -04:00
Marcus Efraimsson 1044585b50 Plugins: Fix problematic query (#46777)
Fixes mysql error "sql: expected 0 arguments, got 1" introduced via #46283
2022-03-21 15:42:05 +01:00
Alex Khomenko 912018ff64 TimePickerContent: Use button time for range dropdown toggle (#46778) 2022-03-21 15:36:07 +01:00