Mario Trangoni
91447dcbf9
pkg/tsdb/stackdriver/stackdriver.go: Fix regular expression does not contain any meta characters.
...
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/tsdb/stackdriver/stackdriver.go:171:26⚠️ regular expression does not contain any meta characters (SA6004) (megacheck)
2018-10-23 17:26:47 +02:00
Mario Trangoni
bb12a1bc99
pkg/tsdb/graphite/graphite.go: Fix regular expression does not contain any meta characters.
...
I found this article benchmarking Replace vs Regexp,
https://medium.com/codezillas/golang-replace-vs-regexp-de4e48482f53
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/tsdb/graphite/graphite.go:167:28⚠️ regular expression does not contain any meta characters (SA6004) (megacheck)
pkg/tsdb/graphite/graphite.go:172:28⚠️ regular expression does not contain any meta characters (SA6004) (megacheck)
2018-10-23 17:26:46 +02:00
Mario Trangoni
3466969a7c
pkg/login/ldap.go: Fix warning comparison to bool constant
...
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/login/ldap.go:188:40⚠️ should omit comparison to bool constant, can be simplified to !*extUser.IsGrafanaAdmin (S1002) (megacheck)
2018-10-23 17:26:46 +02:00
Marcus Efraimsson
8a3b1cf484
Merge pull request #13785 from grafana/13729_perm_debug
...
Add debug logging of dashboard permission checks
2018-10-23 11:50:47 +02:00
Marcus Efraimsson
b371f2d91f
add debug logging of folder/dashbord permission checks
2018-10-23 11:08:57 +02:00
Erik Sundell
6abbf5b3b8
stackdriver: refactoring request builder
2018-10-22 16:12:55 +02:00
Erik Sundell
1756e82d8b
stackdriver: remove not used struct
2018-10-22 16:12:55 +02:00
Erik Sundell
5b04a8b6c2
stackdriver: remove not used query file
2018-10-22 16:11:17 +02:00
Erik Sundell
1a329e4e47
stackdriver: remove test datasource query. use ensuredefaultproject instead
2018-10-22 16:11:17 +02:00
Erik Sundell
b02a8127ff
stackdriver: remove debug comments
2018-10-22 16:11:17 +02:00
Erik Sundell
afe0b4b8db
stackdriver: fix typo
2018-10-22 16:11:17 +02:00
Erik Sundell
b2c6c743ce
stackdriver: add debug logging
2018-10-22 16:11:17 +02:00
Erik Sundell
3999578300
stackdriver: fix broken braces
2018-10-22 16:11:17 +02:00
Erik Sundell
3935f9d24c
stackdriver: use constant instead of variable
2018-10-22 16:11:17 +02:00
Erik Sundell
8b4fff8b87
stackdriver: use gce variable
2018-10-22 16:11:17 +02:00
Erik Sundell
4a51d05477
stackdriver: add variable for gce authentication type
2018-10-22 16:11:17 +02:00
Erik Sundell
b9cb4649bb
stackdriver: get default project from backend. also ensure default project could be retrieved when authentication type is gce
2018-10-22 16:11:17 +02:00
Erik Sundell
cd7b454e25
stackdriver: add default value for authentication type
2018-10-22 16:03:14 +02:00
Erik Sundell
823838a839
stackdriver: wip - remove debug code
2018-10-22 16:03:14 +02:00
Erik Sundell
0b82fda49c
stackdriver: only get default token from metadata server when applying route
2018-10-22 16:03:14 +02:00
Erik Sundell
2b1709b875
stackdriver: only get default token from metadata server when applying route
2018-10-22 16:03:13 +02:00
Erik Sundell
dd9e9ed419
stackdriver: make backend query a pure test datasource function
2018-10-22 16:03:13 +02:00
Erik Sundell
9c7022be86
stackdriver: add status code
2018-10-22 16:03:13 +02:00
Erik Sundell
412a1f6d99
stackdriver: wip - return metric descriptors in the format of tablew
2018-10-22 16:03:13 +02:00
Erik Sundell
ff5f281508
stackdriver: wip - get metric descriptors in the backend
2018-10-22 16:03:13 +02:00
Erik Sundell
60617d0bf7
stackdriver: wip - add logic for retrieving token from gce metadata server in the auth provider
2018-10-22 16:03:13 +02:00
Erik Sundell
102f531c1e
stackdriver: break out project name resolving into its own function in the stackdriver.go file
2018-10-22 16:03:12 +02:00
Erik Sundell
3f9ed2efaa
stackdriver: wip - temp remove jwt token auth
2018-10-22 16:03:12 +02:00
Erik Sundell
b2de0d8c3e
stackdriver: wip - always use gce default account for stackdriver
2018-10-22 16:03:12 +02:00
Erik Sundell
2002162073
stackdriver: wip - add scope and remove debug code
2018-10-22 16:03:12 +02:00
Erik Sundell
df215d9d09
stackdriver: WIP - test retrieving project id from gce metadata
2018-10-22 16:03:12 +02:00
Mitsuhiro Tanda
fbe0ffd10b
skip jwt token auth if privateKey is empty
2018-10-22 16:03:12 +02:00
Mitsuhiro Tanda
43aa6603a3
fetch token from GCE metadata server
2018-10-22 16:03:12 +02:00
Mario Trangoni
68507e8855
pkg/services/alerting/reader.go: Fix should use for range instead of for { select {} }.
...
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/services/alerting/reader.go:37:2⚠️ should use for range instead of for { select {} } (S1000) (megacheck)
2018-10-19 19:49:04 +02:00
Mario Trangoni
e673337cb9
pkg/middleware/middleware.go: Fix empty branch warning.
...
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/middleware/middleware.go:46:3⚠️ empty branch (SA9003) (megacheck)
2018-10-19 19:49:04 +02:00
Mario Trangoni
abb6b135a3
pkg/plugins/plugins.go: remove ineffective break statement.
...
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/plugins/plugins.go:124:4⚠️ ineffective break statement. Did you mean to break out of the outer loop? (SA4011) (megacheck)
2018-10-19 19:49:04 +02:00
Torkel Ödegaard
5b8178cdae
fixed gofmt issue after go update
2018-10-19 11:32:36 +02:00
Yuan Liu
68c460a957
fix cannot receive dingding alert bug
2018-10-19 17:17:38 +08:00
Torkel Ödegaard
dddbe62d6c
Merge branch 'master' into react-panels-step1
2018-10-19 09:15:37 +02:00
Torkel Ödegaard
0f592679f9
Merge pull request #13742 from Cdiscount/feature/fix_ldap_server_admin
...
fix LDAP Grafana admin logic
2018-10-18 14:15:47 +02:00
Marcus Efraimsson
77f23018a5
Merge pull request #13684 from mtanda/cw_concurrent_map
...
fix concurrent map writes
2018-10-18 13:41:39 +02:00
Adrien Fillon and Remi Buisson
781e66ba3c
fix LDAP Grafana admin logic
...
Co-authored-by: Adrien Fillon <adrien.fillon@cdiscount.com >
Co-authored-by: Remi Buisson <remi.buisson@cdiscount.com >
2018-10-18 12:36:48 +02:00
Marcus Efraimsson
1d0dee189c
Merge pull request #13705 from Yukinoshita-Yukino/master
...
Add socket support for mysql data source
2018-10-18 09:45:50 +02:00
Yuan Liu
f640df7a2c
simplify code
2018-10-18 01:45:14 +08:00
Marcus Efraimsson
da89c27caf
Merge pull request #13702 from grafana/data-source-instance-to-react
...
Support Data source permissions
2018-10-17 16:54:57 +02:00
Leonard Gram
3245227016
permissions: cleanup.
2018-10-17 15:58:52 +02:00
Marcus Efraimsson
62f21a254a
Merge pull request #12337 from mtanda/cw_regions
...
show all CloudWatch regions (avoid hard coding)
2018-10-17 11:55:43 +02:00
Yuan Liu
36dbc5f51c
Add socket support for mysql data source
2018-10-17 17:45:06 +08:00
Marcus Efraimsson
52f398e7f7
cloudwatch: return a distinct list of regions
2018-10-17 10:58:06 +02:00
bergquist
70385119bc
removes d in disableResolvedMessage
2018-10-17 10:41:18 +02:00
Mario Trangoni
Marcus Efraimsson
Erik Sundell
Mitsuhiro Tanda
Torkel Ödegaard
Yuan Liu
Adrien FillonandRemi Buisson
Leonard Gram
bergquist