f5be918e49
Use sdk pkg for gtime ( #39354 ) ( #39468 )
...
(cherry picked from commit 64c8d32fe7andres.martinez@grafana.com >
2021-09-21 13:41:31 +02:00
fa9857499b
Chore: GetDashboardQuery should be dispatched using DispatchCtx ( #36877 )
...
* Chore: GetDashboardQuery should be dispatched using DispatchCtx
* Fix after merge
* Changes after review
* Various fixes
* Use GetDashboardCtx function instead of GetDashboard
2021-09-14 16:08:04 +02:00
fc73bc1161
LibraryElements: Enables creating library elements with specific UID ( #39019 )
...
* LibraryPanels: Enables create/update library panels with specific UID
* Chore: added check for uid length after PR comments
* Refactor: creates IsShortUIDTooLong function
* Refactor: adds UID to PATCH endpoint
* Refactor: clarifies the patch code
* Refactor: changes after PR comments
2021-09-10 11:22:13 +02:00
643c7fa0cb
Chore: update all +build statements ( #38782 )
2021-09-01 17:38:56 +03:00
b96dd1877c
Folder API: optionally force deleting Grafana 8 alerts when deleting a folder (or error) ( #36427 )
...
* Folder API: Add an optional query parameter for allowing deleting a folder containing rules
* Update frontend
- Set forceDeleteRules=true when frontend deletes a folder
- Improve modal text
* Update docs
* Apply suggestions from code review
Co-authored-by: gotjosh <josue@grafana.com >
Co-authored-by: Nathan Rodman <nathanrodman@gmail.com >
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com >
2021-07-22 12:27:13 +03:00
7815ed511f
Alerting: Refactor API endpoints for fetching alert rules ( #37055 )
...
* Refactor ruler API endpoint for listing rules
* Refactor prometheus API endpoint for listing rules
* Update HTTP API docs
2021-07-22 09:53:14 +03:00
084c9c8746
Dashboards: Add IsFolder field into models.GetDashboardQuery ( #36214 )
...
* Add IsFolder field into models.GetDashboardQuery
* Reverted folderId - return dummy success when calling get folder with id 0
* Moved condition to upper level - add test
2021-07-01 11:40:38 +03:00
8848d825e0
[Alerting]: Use title instead of slug for retrieving the namespace ( #32957 )
...
* [Alerting]: Use title instead of slug for retrieving the namespace
* Apply suggestions from code review
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-04-14 12:02:50 +03:00
ee06970d72
[Alerting]: Grafana managed ruler API implementation ( #32537 )
...
* [Alerting]: Grafana managed ruler API impl
* Apply suggestions from code review
* fix lint
* Add validation for ruleGroup name length
* Fix MySQL migration
Co-authored-by: kyle <kyle@grafana.com >
2021-04-01 11:11:45 +03:00
27aa7bb900
ImportDashboard: Fixes backend handler not found error when importing dashboard ( #32391 )
2021-03-29 08:13:49 +02:00
5c07df9f4b
Chore: Replace Command dispatches by explicit calls ( #32131 )
...
* Clean up GetProvisionedDashboardDataByIdQuery
* Clean up SaveProvisionedDashboardCommand
* Clean up & fix AddTeamMemberCommand usages
* Clean up & fix UpdateUserPermissionsCommand usages
* Lint imports
2021-03-19 09:14:14 +01:00
87c3a2b790
PluginManager: Make Plugins, Renderer and DataSources non-global ( #31866 )
...
* PluginManager: Make Plugins and DataSources non-global
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix integration tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Replace outdated command
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* DashboardService: Ensure it gets constructed with necessary parameters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix build
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* DashboardService: Ensure it gets constructed with necessary parameters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove dead code
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove FocusConvey
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Remove dead code
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Undo interface changes
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Backend: Move tsdbifaces.RequestHandler to plugins.DataRequestHandler
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Rename to DataSourceCount
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Consolidate dashboard interfaces into one
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix test
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Fix dashboard integration tests
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-03-17 16:06:10 +01:00
1716de88b5
DashboardService: Consolidate constructors ( #31886 )
...
* DashboardService: Consolidate constructors
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-03-12 11:51:02 +01:00
b79e61656a
Introduce TSDB service ( #31520 )
...
* Introduce TSDB service
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Erik Sundell <erik.sundell87@gmail.com >
Co-authored-by: Will Browne <will.browne@grafana.com >
Co-authored-by: Torkel Ödegaard <torkel@grafana.org >
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com >
Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com >
2021-03-08 07:02:49 +01:00
3303e28b38
Search: add sort information in dashboard results ( #30609 )
...
* Search: add SortMeta in dashboard results
* fix integration tests
* trim SortMeta
* fix searchstore tests
* Update pkg/services/sqlstore/dashboard.go
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
2021-02-11 08:49:16 +01:00
116809ed7f
services/provisioning: Various cleanup ( #30396 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2021-01-19 18:57:09 +01:00
9593d57914
Chore: Enable errorlint linter ( #29227 )
...
* Enable errorlint linter
* Handle wrapped errors
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com >
2020-11-19 14:47:17 +01:00
52c154a221
Backend: Rename variables for style conformance ( #29097 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-11-17 17:09:14 +01:00
494c20db5f
gtime: Add ParseDuration function ( #28525 )
...
* gtime: Make calculations independent of current time
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Introduce gtime.ParseDuration function
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* gtime: Fix ParseDuration
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-11-02 19:26:19 +01:00
a5d9196a53
Chore/fix lint issues ( #27704 )
...
* Chore: Fix linting issues
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-09-22 16:22:19 +02:00
5da3276db1
Dashboard: Use same min refresh interval fallback in the API as in provisioning ( #25926 )
...
* Dashboard: Solve the discrepancy between provisioning and the API, Handle min refresh interval when creating/updating dashboard via API
* Docs: Add refresh field in the example dashboard http api docs
* Update create dashboard API docs
Add refresh field in the create dashboard example response
* Fix create dashboard API docs
* Fix create dashboard API docs
* Update docs/sources/http_api/dashboard.md
Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com >
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com >
2020-08-17 12:00:10 -07:00
16c185c3b9
Chore: Drop xerrors dependency ( #26718 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-07-31 09:45:20 +02:00
f427f90a45
Chore: Aggregate save dashboard error ( #26443 )
...
* Chore: Aggregate save dashboard error
* Use errors package for error detection
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com >
Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com >
2020-07-21 11:12:01 +02:00
41d432b5ae
Chore: Enable whitespace linter ( #25903 )
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-07-06 20:17:28 +02:00
5070f7a75b
Chore: Start harmonizing linting with plugin SDK ( #25854 )
...
* Chore: Harmonize linting with plugin SDK
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
* Chore: Fix linting issues
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com >
2020-06-29 14:08:32 +02:00
b22649bf8d
Dashboard: Handle min refresh interval when importing dashboard ( #23959 )
...
If refresh interval is lower than minimum refresh interval
when importing dashboard, use the minimum refresh interval
instead of returning error.
Fixes #23099
2020-04-27 21:17:28 +02:00
5fc255bd89
Linting fixes for provisoning ( #23600 )
2020-04-16 05:46:20 +02:00
72628c8ea0
Dashboard: Adds support for a global minimum dashboard refresh interval ( #19416 )
...
This feature would provide a way for administrators to limit the minimum
dashboard refresh interval globally.
Filters out the refresh intervals available in the time picker that are lower
than the set minimum refresh interval in the configuration .ini file
Adds the minimum refresh interval as available in the time picker.
If the user tries to enter a refresh interval that is lower than the minimum
in the URL, defaults to the minimum interval.
When trying to update the JSON via the API, rejects the update if the
dashboard's refresh interval is lower than the minimum.
When trying to update a dashboard via provisioning having a lower
refresh interval than the minimum, defaults to the minimum interval
and logs a warning.
Fixes #3356
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com >
2020-02-28 14:32:01 +01:00
b489c75aaf
Provisioning: fix for cannot save provisioned dashboard ( #20218 )
...
Provisioning of dashboards now always overwrite existing ones and does not look at the configuration `allowUiUpdates` anymore
2019-11-07 10:49:24 +01:00
a45ce36566
Allow saving of provisioned dashboards ( #19820 )
...
Allows saving of provisioned dashboards if the config value allowUiUpdates is set to true
Fixes #11778
2019-10-31 14:27:31 +01:00
2fff8f77dc
move log package to /infra ( #17023 )
...
ref #14679
Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com >
2019-05-13 08:45:54 +02:00
eb82a75668
Provisioning: Show file path of provisioning file in save/delete dialogs ( #16706 )
...
* Add file path to metadata and show it in dialogs
* Make path relative to config directory
* Fix tests
* Add test for the relative path
* Refactor to use path relative to provisioner path
* Change return types
* Rename attribute
* Small fixes from review
2019-04-30 13:32:18 +02:00
c429934a66
Chore: Use x/xerrors instead of pkg/errors ( #16668 )
...
* Use xerrors instead of pkg/errors
* Add Wrap util func
* Move Wrap to errutil package
2019-04-23 11:50:31 +02:00
8b0dd4244b
Search: Fixes search limits and adds a page parameter ( #16458 )
...
* Search: Fixes search limits and adds a page parameter
This adds a page parameter to search api without adding
any major breaking change.
It does at an api validation error when trying to use
a limit beyond 5000. This is a breaking change. We could
remove this and have it only in the docs and describe that this
is a limit that grafana will apply silently.
Fixes #16049
* Fix: Corrected wrong array slice change
* Docs: minor docs fix
* Search: fixed folder tests
* Fixed: Moved limit to correct inner query
* Search: moving limit check and page check
* Search: limit in handler is no longer needed
2019-04-17 13:07:50 +02:00
2d7fc55df7
Provisioning: Do not allow deletion of provisioned dashboards ( #16211 )
...
* Unprovision dashboard in case of DisableDeletion = true
* Rename command struct
* Handle removed provision files
* Allow html in confirm-modal
* Do not show confirm button without onConfirm
* Show dialog on deleting provisioned dashboard
* Changed DeleteDashboard to DeleteProvisionedDashboard
* Remove unreachable return
* Add provisioned checks to API
* Remove filter func
* Fix and add tests for deleting dashboards
* Change delete confirm text
* Added and used pkg/errors for error wrapping
2019-04-10 13:29:10 +02:00
a615b78f8a
permissions: removes global access to bus from MakeUserAdmin.
2019-03-19 14:01:20 +01:00
9f8e43916d
permissions: refactor.
2019-03-19 14:01:19 +01:00
0b209de5d1
dashboard: only admin permission added to dashboard in folder.
2019-03-19 13:57:30 +01:00
da3dcd1918
folder: uses service to make user admin of created folder.
2019-03-19 13:57:21 +01:00
c8c004095c
permissions: broken out func for making creator admin.
2019-03-19 13:57:21 +01:00
e174f7c20b
folders: admin for created folders
2019-03-19 13:57:20 +01:00
e294252e92
dashboards: user automatically becomes admin for created dashboards
2019-03-19 13:57:20 +01:00
b7628f2060
pkg/util/{filepath.go,shortid_generator.go}: Fix golint issues
...
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=golint ./...
filepath.go:12:5⚠️ error var WalkSkipDir should have name of the form ErrFoo (golint)
shortid_generator.go:11:5⚠️ var validUidPattern should be validUIDPattern (golint)
shortid_generator.go:19:6⚠️ func IsValidShortUid should be IsValidShortUID (golint)
shortid_generator.go:24:6⚠️ func GenerateShortUid should be GenerateShortUID (golint)
2019-01-28 22:37:44 +01:00
bf90ff87cf
pkg/services/dashboards/dashboard_service.go: simplify return
...
See,
$ gometalinter --vendor --deadline 10m --disable-all --enable=megacheck ./...
pkg/services/dashboards/dashboard_service.go:167:2⚠️ 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (megacheck)
2019-01-26 14:23:10 +01:00
3e873a2500
Merge pull request #14710 from grafana/fixed-gometalinter
...
Fixed new gotmetalinter warning
2019-01-03 07:23:45 +01:00
80e441f48b
Fixed new gotmetalinter warning
2019-01-02 19:17:35 +01:00
9895b1e6d0
adds orgId to user dto for provisioned dashboards
2018-12-28 10:49:00 +01:00
36aec52c08
return actual error if failing to update alert data
2018-11-22 11:19:08 +01:00
9e0da02b6a
refactor dashboard alert extractor
2018-11-05 14:25:19 +01:00
ec4698fb96
alerting: propagate alert validation issues to the user instead of just 'invalid alert data' message
2018-10-12 23:03:54 -07:00
Grot (@grafanabot)
Marcus Efraimsson
Hugo Häggmark
Serge Zaitsev
Sofia Papagiannaki
Dimitris Sotirakis
Torkel Ödegaard
Joan López de la Franca Beltran
Arve Knudsen
Agnès Toulet
Kirchen99
gastonqiu
Carl Bergquist
lfroment
Jon Gyllenswärd
zhulongcheng
Andrej Ocenas
Torkel Ödegaard
Leonard Gram
Mario Trangoni
bergquist