Jack Westbrook
23a51ec9c5
* ci(frontend-lint): add frontend package change detection and add validate packed packages lint step * ci(change-detection): add validate-npm-packages.sh to frontend-packages list * ci(gh-workflows): add actions globs to frontend-packages detection * ci(gh-workflows): fix typo - > _ * ci(frontend-lint): add missing needs * chore(i18n): fix publint erroring for custom condition pointing to .cjs file * ci(validate-npm-packages): make profile node16 default * chore(validate-npm-packages): remove shellcheck disable comment
196 lines
7.0 KiB
YAML
196 lines
7.0 KiB
YAML
name: Lint Frontend
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- main
|
|
- release-*.*.*
|
|
|
|
permissions: {}
|
|
|
|
jobs:
|
|
detect-changes:
|
|
name: Detect whether code changed
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
outputs:
|
|
changed: ${{ steps.detect-changes.outputs.frontend }}
|
|
prettier: ${{ steps.detect-changes.outputs.frontend == 'true' || steps.detect-changes.outputs.docs == 'true' }}
|
|
changed-frontend-packages: ${{ steps.detect-changes.outputs.frontend-packages }}
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: true # required to get more history in the changed-files action
|
|
fetch-depth: 2
|
|
- name: Detect changes
|
|
id: detect-changes
|
|
uses: ./.github/actions/change-detection
|
|
with:
|
|
self: .github/workflows/frontend-lint.yml
|
|
|
|
lint-frontend-prettier:
|
|
needs: detect-changes
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
# Run this workflow only for PRs from forks; if it gets merged into `main` or `release-*`,
|
|
# the `lint-frontend-prettier-enterprise` workflow will run instead
|
|
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true && needs.detect-changes.outputs.prettier == 'true'
|
|
name: Lint
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: false
|
|
- name: Setup Node
|
|
uses: ./.github/actions/setup-node
|
|
- run: yarn install --immutable --check-cache
|
|
- run: yarn run prettier:check
|
|
- run: yarn run lint
|
|
lint-frontend-prettier-enterprise:
|
|
needs: detect-changes
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
# Run this workflow for non-PR events (like pushes to `main` or `release-*`) OR for internal PRs (PRs not from forks)
|
|
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false && needs.detect-changes.outputs.prettier == 'true'
|
|
name: Lint
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: false
|
|
- name: Setup Node
|
|
uses: ./.github/actions/setup-node
|
|
- name: Setup Enterprise
|
|
uses: ./.github/actions/setup-enterprise
|
|
with:
|
|
github-app-name: 'grafana-ci-bot'
|
|
- run: yarn install --immutable --check-cache
|
|
- run: yarn run prettier:check
|
|
- run: yarn run lint
|
|
lint-frontend-typecheck:
|
|
needs: detect-changes
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
# Run this workflow only for PRs from forks; if it gets merged into `main` or `release-*`,
|
|
# the `lint-frontend-typecheck-enterprise` workflow will run instead
|
|
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true && needs.detect-changes.outputs.changed == 'true'
|
|
name: Typecheck
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: false
|
|
- name: Setup Node
|
|
uses: ./.github/actions/setup-node
|
|
- run: yarn install --immutable --check-cache
|
|
- run: yarn run typecheck
|
|
lint-frontend-typecheck-enterprise:
|
|
needs: detect-changes
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
# Run this workflow for non-PR events (like pushes to `main` or `release-*`) OR for internal PRs (PRs not from forks)
|
|
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false && needs.detect-changes.outputs.changed == 'true'
|
|
name: Typecheck
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: false
|
|
- name: Setup Node
|
|
uses: ./.github/actions/setup-node
|
|
- name: Setup Enterprise
|
|
uses: ./.github/actions/setup-enterprise
|
|
with:
|
|
github-app-name: 'grafana-ci-bot'
|
|
- run: yarn install --immutable --check-cache
|
|
- run: yarn run typecheck
|
|
lint-frontend-api-clients:
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
# Run this workflow only for PRs from forks; if it gets merged into `main` or `release-*`,
|
|
# the `lint-frontend-api-clients-enterprise` workflow will run instead
|
|
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true
|
|
name: Verify API clients
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: false
|
|
- name: Setup Node
|
|
uses: ./.github/actions/setup-node
|
|
- run: yarn install --immutable --check-cache
|
|
- name: Generate API clients
|
|
run: |
|
|
extract_error_message='ERROR! API client generation failed!'
|
|
yarn generate-apis || (echo "${extract_error_message}" && false)
|
|
- name: Verify generated clients
|
|
run: |
|
|
uncommited_error_message="ERROR! API client generation has not been committed. Please run 'yarn generate-apis', commit the changes and push again."
|
|
file_diff="$(git diff ':!conf')"
|
|
if [ -n "$file_diff" ]; then
|
|
echo "$file_diff"
|
|
echo "${uncommited_error_message}"
|
|
exit 1
|
|
fi
|
|
lint-frontend-api-clients-enterprise:
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
# Run this workflow for non-PR events (like pushes to `main` or `release-*`) OR for internal PRs (PRs not from forks)
|
|
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
|
|
name: Verify API clients (enterprise)
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: false
|
|
- name: Setup Node
|
|
uses: ./.github/actions/setup-node
|
|
- name: Setup Enterprise
|
|
uses: ./.github/actions/setup-enterprise
|
|
with:
|
|
github-app-name: 'grafana-ci-bot'
|
|
- run: yarn install --immutable --check-cache
|
|
- name: Generate API clients
|
|
run: |
|
|
extract_error_message='ERROR! API client generation failed!'
|
|
yarn generate-apis || (echo "${extract_error_message}" && false)
|
|
- name: Verify generated clients
|
|
run: |
|
|
uncommited_error_message="ERROR! API client generation has not been committed. Please run 'yarn generate-apis', commit the changes and push again."
|
|
file_diff="$(git diff ':!conf')"
|
|
if [ -n "$file_diff" ]; then
|
|
echo "$file_diff"
|
|
echo "${uncommited_error_message}"
|
|
exit 1
|
|
fi
|
|
lint-frontend-packed-packages:
|
|
needs: detect-changes
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
if: github.event_name == 'pull_request' && needs.detect-changes.outputs.changed-frontend-packages == 'true'
|
|
name: Verify packed frontend packages
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout build commit
|
|
uses: actions/checkout@v5
|
|
with:
|
|
persist-credentials: false
|
|
- name: Setup Node
|
|
uses: ./.github/actions/setup-node
|
|
- name: Install dependencies
|
|
run: yarn install --immutable
|
|
- name: Build and pack packages
|
|
run: |
|
|
yarn run packages:build
|
|
yarn run packages:pack
|
|
- name: Validate packages
|
|
run: ./scripts/validate-npm-packages.sh
|