a72e02f88a
**Highlights**
* **Single-version migrations**: add `targetVersion` to migrator & model, separate outputs, enforce exact version.
* **Datasource fixes**: include `apiVersion` in tests, empty-string → `{}`, preserve `{}` refs, drop unwanted defaults.
* **Panel defaults & nesting**: only top-level panels get defaults; preserve empty `transformations` context-aware; filter repeated panels.
* **Migration parity**
* V16: collapsed rows, grid height parsing (`px`).
* V17: omit `maxPerRow` when `minSpan=1`.
* V19–V20: cleanup defaults (`targetBlank`, style).
* V23–V24: template vars + table panel consistency.
* V28: full singlestat/stat parity, mappings & color.
* V30–V36: threshold logic, empty refs, nested targets.
* **Save-model cleanup**: replicate frontend defaults/filtering, drop null IDs, metadata, unused props.
* **Testing**: unified suites, dev dashboards (v42), full unit coverage for major migrations.
Co-authored-by: Ivan Ortega [ivanortegaalba@gmail.com](mailto:ivanortegaalba@gmail.com)
Co-authored-by: Dominik Prokop [dominik.prokop@grafana.com](mailto:dominik.prokop@grafana.com)
123 lines
3.0 KiB
Go
123 lines
3.0 KiB
Go
package schemaversion
|
|
|
|
import "context"
|
|
|
|
// V18 migrates gauge panel options from the legacy `options-gauge` format to the new `options` format.
|
|
// This migration restructures gauge panel configuration to use the modern options structure with valueOptions.
|
|
//
|
|
// Example before migration:
|
|
//
|
|
// "panels": [
|
|
// {
|
|
// "type": "gauge",
|
|
// "options-gauge": {
|
|
// "unit": "ms",
|
|
// "stat": "last",
|
|
// "decimals": 2,
|
|
// "prefix": "Value: ",
|
|
// "suffix": " ms",
|
|
// "thresholds": [
|
|
// { "color": "green", "value": 0 },
|
|
// { "color": "red", "value": 100 }
|
|
// ]
|
|
// }
|
|
// }
|
|
// ]
|
|
//
|
|
// Example after migration:
|
|
//
|
|
// "panels": [
|
|
// {
|
|
// "type": "gauge",
|
|
// "options": {
|
|
// "valueOptions": {
|
|
// "unit": "ms",
|
|
// "stat": "last",
|
|
// "decimals": 2,
|
|
// "prefix": "Value: ",
|
|
// "suffix": " ms"
|
|
// },
|
|
// "thresholds": [
|
|
// { "color": "red", "value": 100 },
|
|
// { "color": "green", "value": 0 }
|
|
// ]
|
|
// }
|
|
// }
|
|
// ]
|
|
func V18(_ context.Context, dashboard map[string]interface{}) error {
|
|
dashboard["schemaVersion"] = 18
|
|
|
|
if !IsArray(dashboard["panels"]) {
|
|
return nil
|
|
}
|
|
panels := dashboard["panels"].([]interface{})
|
|
|
|
for _, p := range panels {
|
|
panel, ok := p.(map[string]interface{})
|
|
if !ok {
|
|
continue
|
|
}
|
|
|
|
migrateGaugePanelOptions(panel)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func migrateGaugePanelOptions(panel map[string]interface{}) {
|
|
optionsGauge, hasOptionsGauge := panel["options-gauge"].(map[string]interface{})
|
|
if !hasOptionsGauge {
|
|
return
|
|
}
|
|
|
|
options := map[string]interface{}{}
|
|
|
|
valueOptions := map[string]interface{}{}
|
|
if unit, ok := optionsGauge["unit"]; ok {
|
|
valueOptions["unit"] = unit
|
|
}
|
|
if stat, ok := optionsGauge["stat"]; ok {
|
|
valueOptions["stat"] = stat
|
|
}
|
|
if decimals, ok := optionsGauge["decimals"]; ok {
|
|
valueOptions["decimals"] = decimals
|
|
}
|
|
if prefix, ok := optionsGauge["prefix"]; ok {
|
|
valueOptions["prefix"] = prefix
|
|
}
|
|
if suffix, ok := optionsGauge["suffix"]; ok {
|
|
valueOptions["suffix"] = suffix
|
|
}
|
|
|
|
options["valueOptions"] = valueOptions
|
|
|
|
if IsArray(optionsGauge["thresholds"]) {
|
|
thresholds := optionsGauge["thresholds"].([]interface{})
|
|
if len(thresholds) > 0 {
|
|
reversedThresholds := make([]interface{}, len(thresholds))
|
|
for i, threshold := range thresholds {
|
|
reversedThresholds[len(thresholds)-1-i] = threshold
|
|
}
|
|
options["thresholds"] = reversedThresholds
|
|
}
|
|
}
|
|
|
|
// Copy any other properties from options-gauge to options
|
|
for key, value := range optionsGauge {
|
|
// Skip properties that were moved to valueOptions or are being deleted
|
|
if key == "options" || key == "unit" || key == "stat" || key == "decimals" || key == "prefix" || key == "suffix" || key == "thresholds" {
|
|
continue
|
|
}
|
|
options[key] = value
|
|
}
|
|
|
|
panel["options"] = options
|
|
delete(panel, "options-gauge")
|
|
|
|
// Clean up options.options property if it exists
|
|
// This options prop was due to a bug
|
|
if panelOptions, ok := panel["options"].(map[string]interface{}); ok {
|
|
delete(panelOptions, "options")
|
|
}
|
|
}
|