idafurjes
2532047e7a
* Add FolderUID in missing places for libraryelements * Add migration for FolderUID in library elements table * Add Folder UIDs tolibrary panels * Adjust dashboard import with folder uid * Fix lint * Rename back FolderUID to UID * Remove default * Check if folderUID is nil * Add unique indes on org_id,folder_uid,name and kind * Update pkg/services/libraryelements/database.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Fix folder integration test, with unique index on library elements * Make folder uids nullable and rewrite migration query * Use dashboard uid instead of folder_uid * Adjust test --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
199 lines
7.3 KiB
Go
199 lines
7.3 KiB
Go
package libraryelements
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/grafana/grafana/pkg/kinds/librarypanel"
|
|
"github.com/grafana/grafana/pkg/services/libraryelements/model"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
)
|
|
|
|
func TestCreateLibraryElement(t *testing.T) {
|
|
scenarioWithPanel(t, "When an admin tries to create a library panel that already exists, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
// nolint:staticcheck
|
|
command := getCreatePanelCommand(sc.folder.ID, sc.folder.UID, "Text - Library Panel")
|
|
sc.reqContext.Req.Body = mockRequestBody(command)
|
|
resp := sc.service.createHandler(sc.reqContext)
|
|
require.Equal(t, 400, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to create a library panel that does not exists, it should succeed",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
var expected = libraryElementResult{
|
|
Result: libraryElement{
|
|
ID: 1,
|
|
OrgID: 1,
|
|
FolderID: 1, // nolint:staticcheck
|
|
FolderUID: sc.folder.UID,
|
|
UID: sc.initialResult.Result.UID,
|
|
Name: "Text - Library Panel",
|
|
Kind: int64(model.PanelElement),
|
|
Type: "text",
|
|
Description: "A description",
|
|
Model: map[string]any{
|
|
"datasource": "${DS_GDEV-TESTDATA}",
|
|
"description": "A description",
|
|
"id": float64(1),
|
|
"title": "Text - Library Panel",
|
|
"type": "text",
|
|
},
|
|
Version: 1,
|
|
Meta: model.LibraryElementDTOMeta{
|
|
FolderName: "ScenarioFolder",
|
|
FolderUID: "ScenarioFolder",
|
|
ConnectedDashboards: 0,
|
|
Created: sc.initialResult.Result.Meta.Created,
|
|
Updated: sc.initialResult.Result.Meta.Updated,
|
|
CreatedBy: librarypanel.LibraryElementDTOMetaUser{
|
|
Id: 1,
|
|
Name: "signed_in_user",
|
|
AvatarUrl: "/avatar/37524e1eb8b3e32850b57db0a19af93b",
|
|
},
|
|
UpdatedBy: librarypanel.LibraryElementDTOMetaUser{
|
|
Id: 1,
|
|
Name: "signed_in_user",
|
|
AvatarUrl: "/avatar/37524e1eb8b3e32850b57db0a19af93b",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
if diff := cmp.Diff(expected, sc.initialResult, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
testScenario(t, "When an admin tries to create a library panel that does not exists using an nonexistent UID, it should succeed",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
// nolint:staticcheck
|
|
command := getCreatePanelCommand(sc.folder.ID, sc.folder.UID, "Nonexistent UID")
|
|
command.UID = util.GenerateShortUID()
|
|
sc.reqContext.Req.Body = mockRequestBody(command)
|
|
resp := sc.service.createHandler(sc.reqContext)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
var expected = libraryElementResult{
|
|
Result: libraryElement{
|
|
ID: 1,
|
|
OrgID: 1,
|
|
FolderID: 1, // nolint:staticcheck
|
|
FolderUID: sc.folder.UID,
|
|
UID: command.UID,
|
|
Name: "Nonexistent UID",
|
|
Kind: int64(model.PanelElement),
|
|
Type: "text",
|
|
Description: "A description",
|
|
Model: map[string]any{
|
|
"datasource": "${DS_GDEV-TESTDATA}",
|
|
"description": "A description",
|
|
"id": float64(1),
|
|
"title": "Text - Library Panel",
|
|
"type": "text",
|
|
},
|
|
Version: 1,
|
|
Meta: model.LibraryElementDTOMeta{
|
|
FolderName: "ScenarioFolder",
|
|
FolderUID: "ScenarioFolder",
|
|
ConnectedDashboards: 0,
|
|
Created: result.Result.Meta.Created,
|
|
Updated: result.Result.Meta.Updated,
|
|
CreatedBy: librarypanel.LibraryElementDTOMetaUser{
|
|
Id: 1,
|
|
Name: "signed_in_user",
|
|
AvatarUrl: "/avatar/37524e1eb8b3e32850b57db0a19af93b",
|
|
},
|
|
UpdatedBy: librarypanel.LibraryElementDTOMetaUser{
|
|
Id: 1,
|
|
Name: "signed_in_user",
|
|
AvatarUrl: "/avatar/37524e1eb8b3e32850b57db0a19af93b",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
if diff := cmp.Diff(expected, result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to create a library panel that does not exists using an existent UID, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
// nolint:staticcheck
|
|
command := getCreatePanelCommand(sc.folder.ID, sc.folder.UID, "Existing UID")
|
|
command.UID = sc.initialResult.Result.UID
|
|
sc.reqContext.Req.Body = mockRequestBody(command)
|
|
resp := sc.service.createHandler(sc.reqContext)
|
|
require.Equal(t, 400, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to create a library panel that does not exists using an invalid UID, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
// nolint:staticcheck
|
|
command := getCreatePanelCommand(sc.folder.ID, sc.folder.UID, "Invalid UID")
|
|
command.UID = "Testing an invalid UID"
|
|
sc.reqContext.Req.Body = mockRequestBody(command)
|
|
resp := sc.service.createHandler(sc.reqContext)
|
|
require.Equal(t, 400, resp.Status())
|
|
})
|
|
|
|
scenarioWithPanel(t, "When an admin tries to create a library panel that does not exists using an UID that is too long, it should fail",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
// nolint:staticcheck
|
|
command := getCreatePanelCommand(sc.folder.ID, sc.folder.UID, "Invalid UID")
|
|
command.UID = "j6T00KRZzj6T00KRZzj6T00KRZzj6T00KRZzj6T00K"
|
|
sc.reqContext.Req.Body = mockRequestBody(command)
|
|
resp := sc.service.createHandler(sc.reqContext)
|
|
require.Equal(t, 400, resp.Status())
|
|
})
|
|
|
|
testScenario(t, "When an admin tries to create a library panel where name and panel title differ, it should not update panel title",
|
|
func(t *testing.T, sc scenarioContext) {
|
|
command := getCreatePanelCommand(1, sc.folder.UID, "Library Panel Name")
|
|
sc.reqContext.Req.Body = mockRequestBody(command)
|
|
resp := sc.service.createHandler(sc.reqContext)
|
|
var result = validateAndUnMarshalResponse(t, resp)
|
|
var expected = libraryElementResult{
|
|
Result: libraryElement{
|
|
ID: 1,
|
|
OrgID: 1,
|
|
FolderID: 1, // nolint:staticcheck
|
|
FolderUID: sc.folder.UID,
|
|
UID: result.Result.UID,
|
|
Name: "Library Panel Name",
|
|
Kind: int64(model.PanelElement),
|
|
Type: "text",
|
|
Description: "A description",
|
|
Model: map[string]any{
|
|
"datasource": "${DS_GDEV-TESTDATA}",
|
|
"description": "A description",
|
|
"id": float64(1),
|
|
"title": "Text - Library Panel",
|
|
"type": "text",
|
|
},
|
|
Version: 1,
|
|
Meta: model.LibraryElementDTOMeta{
|
|
FolderName: "ScenarioFolder",
|
|
FolderUID: "ScenarioFolder",
|
|
ConnectedDashboards: 0,
|
|
Created: result.Result.Meta.Created,
|
|
Updated: result.Result.Meta.Updated,
|
|
CreatedBy: librarypanel.LibraryElementDTOMetaUser{
|
|
Id: 1,
|
|
Name: "signed_in_user",
|
|
AvatarUrl: "/avatar/37524e1eb8b3e32850b57db0a19af93b",
|
|
},
|
|
UpdatedBy: librarypanel.LibraryElementDTOMetaUser{
|
|
Id: 1,
|
|
Name: "signed_in_user",
|
|
AvatarUrl: "/avatar/37524e1eb8b3e32850b57db0a19af93b",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
if diff := cmp.Diff(expected, result, getCompareOptions()...); diff != "" {
|
|
t.Fatalf("Result mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|