Roberto Jiménez Sánchez
02464c19b8
* Validate Job Specs * Add comprehensive unit test coverage for job validator - Added 8 new test cases to improve coverage from 88.9% to ~100% - Tests for migrate action without options - Tests for delete/move actions with resources (missing kind) - Tests for move action with valid resources - Tests for move/delete with both paths and resources - Tests for move action with invalid source paths - Tests for push action with valid paths Now covers all validation paths including resource validation and edge cases for all job action types. * Add integration tests for job validation Added comprehensive integration tests that verify the job validator properly rejects invalid job specifications via the API: - Test job without action (required field) - Test job with invalid action - Test pull job without pull options - Test push job without push options - Test push job with invalid branch name (consecutive dots) - Test push job with path traversal attempt - Test delete job without paths or resources - Test delete job with invalid path (path traversal) - Test move job without target path - Test move job without paths or resources - Test move job with invalid target path (path traversal) - Test migrate job without migrate options - Test valid pull job to ensure validation doesn't block legitimate requests These tests verify that the admission controller properly validates job specs before they are persisted, ensuring security (path traversal prevention) and data integrity (required fields/options). * Remove valid job test case from integration tests Removed the positive test case as it's not necessary for validation testing. The integration tests now focus solely on verifying that invalid job specs are properly rejected by the admission controller. * Fix movejob_test to expect validation error at creation time Updated the 'move without target path' test to expect the job creation to fail with a validation error, rather than expecting the job to be created and then fail during execution. This aligns with the new job validation logic which rejects invalid job specs at the API admission control level (422 Unprocessable Entity) before they can be persisted. This is better behavior as it prevents invalid jobs from being created in the first place, rather than allowing them to be created and then failing during execution. * Simplify action validation using slices.Contains Replaced manual loop with slices.Contains for cleaner, more idiomatic Go code. This reduces code complexity while maintaining the same validation logic. - Added import for 'slices' package - Replaced 8-line loop with 1-line slices.Contains call - All unit tests pass * Refactor job action validation in ValidateJob function Removed the hardcoded valid actions array and simplified the validation logic. The function now directly appends an error for invalid actions, improving code clarity and maintainability. This change aligns with the recent updates to job validation, ensuring that invalid job specifications are properly handled.
594 lines
14 KiB
Go
594 lines
14 KiB
Go
package jobs
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
provisioning "github.com/grafana/grafana/apps/provisioning/pkg/apis/provisioning/v0alpha1"
|
|
)
|
|
|
|
func TestValidateJob(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
job *provisioning.Job
|
|
wantErr bool
|
|
validateError func(t *testing.T, err error)
|
|
}{
|
|
{
|
|
name: "valid pull job",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPull,
|
|
Repository: "test-repo",
|
|
Pull: &provisioning.SyncJobOptions{
|
|
Incremental: true,
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "missing action",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Repository: "test-repo",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.action: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "invalid action",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobAction("invalid"),
|
|
Repository: "test-repo",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.action: Invalid value")
|
|
},
|
|
},
|
|
{
|
|
name: "missing repository",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPull,
|
|
Pull: &provisioning.SyncJobOptions{
|
|
Incremental: true,
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.repository: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "pull action without pull options",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPull,
|
|
Repository: "test-repo",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.pull: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "push action without push options",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPush,
|
|
Repository: "test-repo",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.push: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "valid push job with valid branch",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPush,
|
|
Repository: "test-repo",
|
|
Push: &provisioning.ExportJobOptions{
|
|
Branch: "main",
|
|
Message: "Test commit",
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "push job with invalid branch name",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPush,
|
|
Repository: "test-repo",
|
|
Push: &provisioning.ExportJobOptions{
|
|
Branch: "feature..branch", // Invalid: contains consecutive dots
|
|
Message: "Test commit",
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.push.branch")
|
|
require.Contains(t, err.Error(), "invalid git branch name")
|
|
},
|
|
},
|
|
{
|
|
name: "push job with invalid path",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPush,
|
|
Repository: "test-repo",
|
|
Push: &provisioning.ExportJobOptions{
|
|
Path: "../../../etc/passwd", // Invalid: path traversal
|
|
Message: "Test commit",
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.push.path")
|
|
},
|
|
},
|
|
{
|
|
name: "delete action without options",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.delete: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "delete action without paths or resources",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
Delete: &provisioning.DeleteJobOptions{},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "at least one path or resource must be specified")
|
|
},
|
|
},
|
|
{
|
|
name: "valid delete action with paths",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
Delete: &provisioning.DeleteJobOptions{
|
|
Paths: []string{"dashboard.json", "folder/other.json"},
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid delete action with resources",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
Delete: &provisioning.DeleteJobOptions{
|
|
Resources: []provisioning.ResourceRef{
|
|
{
|
|
Name: "my-dashboard",
|
|
Kind: "Dashboard",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "delete action with invalid path",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
Delete: &provisioning.DeleteJobOptions{
|
|
Paths: []string{"../../etc/passwd"}, // Invalid: path traversal
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.delete.paths[0]")
|
|
},
|
|
},
|
|
{
|
|
name: "delete action with resource missing name",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
Delete: &provisioning.DeleteJobOptions{
|
|
Resources: []provisioning.ResourceRef{
|
|
{
|
|
Kind: "Dashboard",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.delete.resources[0].name")
|
|
},
|
|
},
|
|
{
|
|
name: "move action without options",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.move: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "move action without paths or resources",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
TargetPath: "new-location/",
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "at least one path or resource must be specified")
|
|
},
|
|
},
|
|
{
|
|
name: "move action without target path",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
Paths: []string{"dashboard.json"},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.move.targetPath: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "valid move action",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
Paths: []string{"old-location/dashboard.json"},
|
|
TargetPath: "new-location/",
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "move action with invalid target path",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
Paths: []string{"dashboard.json"},
|
|
TargetPath: "../../../etc/", // Invalid: path traversal
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.move.targetPath")
|
|
},
|
|
},
|
|
{
|
|
name: "valid migrate job",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMigrate,
|
|
Repository: "test-repo",
|
|
Migrate: &provisioning.MigrateJobOptions{
|
|
History: true,
|
|
Message: "Migrate from legacy",
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "migrate action without migrate options",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMigrate,
|
|
Repository: "test-repo",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.migrate: Required value")
|
|
},
|
|
},
|
|
{
|
|
name: "valid pr job",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPullRequest,
|
|
Repository: "test-repo",
|
|
PullRequest: &provisioning.PullRequestJobOptions{
|
|
PR: 123,
|
|
Ref: "refs/pull/123/head",
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "delete action with resource missing kind",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
Delete: &provisioning.DeleteJobOptions{
|
|
Resources: []provisioning.ResourceRef{
|
|
{
|
|
Name: "my-dashboard",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.delete.resources[0].kind")
|
|
},
|
|
},
|
|
{
|
|
name: "move action with valid resources",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
Resources: []provisioning.ResourceRef{
|
|
{
|
|
Name: "my-dashboard",
|
|
Kind: "Dashboard",
|
|
},
|
|
},
|
|
TargetPath: "new-location/",
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "move action with resource missing kind",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
Resources: []provisioning.ResourceRef{
|
|
{
|
|
Name: "my-dashboard",
|
|
},
|
|
},
|
|
TargetPath: "new-location/",
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.move.resources[0].kind")
|
|
},
|
|
},
|
|
{
|
|
name: "move action with both paths and resources",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
Paths: []string{"dashboard.json"},
|
|
Resources: []provisioning.ResourceRef{
|
|
{
|
|
Name: "my-dashboard",
|
|
Kind: "Dashboard",
|
|
},
|
|
},
|
|
TargetPath: "new-location/",
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "move action with invalid source path",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionMove,
|
|
Repository: "test-repo",
|
|
Move: &provisioning.MoveJobOptions{
|
|
Paths: []string{"../invalid/path"},
|
|
TargetPath: "valid/target/",
|
|
},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
validateError: func(t *testing.T, err error) {
|
|
require.Contains(t, err.Error(), "spec.move.paths[0]")
|
|
},
|
|
},
|
|
{
|
|
name: "delete action with both paths and resources",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionDelete,
|
|
Repository: "test-repo",
|
|
Delete: &provisioning.DeleteJobOptions{
|
|
Paths: []string{"dashboard.json"},
|
|
Resources: []provisioning.ResourceRef{
|
|
{
|
|
Name: "my-dashboard",
|
|
Kind: "Dashboard",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "push action with valid path",
|
|
job: &provisioning.Job{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-job",
|
|
},
|
|
Spec: provisioning.JobSpec{
|
|
Action: provisioning.JobActionPush,
|
|
Repository: "test-repo",
|
|
Push: &provisioning.ExportJobOptions{
|
|
Path: "some/valid/path",
|
|
Message: "Test commit",
|
|
},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
err := ValidateJob(tt.job)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
if tt.validateError != nil {
|
|
tt.validateError(t, err)
|
|
}
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|