Mario Trangoni dde650905d Fix megacheck issue unused code. ...

I removed some code, and commented out other one.

See,
$ gometalinter --vendor --disable-all --disable=gotype --enable=megacheck --deadline 6m ./... | grep unused
pkg/api/avatar/avatar.go:100:26⚠️ func (*CacheServer).mustInt is unused (U1000) (megacheck)
pkg/api/folder_test.go:136:6⚠️ func callGetFolderByUID is unused (U1000) (megacheck)
pkg/api/folder_test.go:141:6⚠️ func callDeleteFolder is unused (U1000) (megacheck)
pkg/api/live/hub.go:40:15⚠️ func (*hub).removeConnection is unused (U1000) (megacheck)
pkg/components/imguploader/azureblobuploader.go:130:5⚠️ var client is unused (U1000) (megacheck)
pkg/middleware/middleware_test.go:438:28⚠️ func (*scenarioContext).withInvalidApiKey is unused (U1000) (megacheck)
pkg/services/alerting/ticker.go:40:18⚠️ func (*Ticker).updateOffset is unused (U1000) (megacheck)
pkg/services/notifications/notifications_test.go:12:6⚠️ type testTriggeredAlert is unused (U1000) (megacheck)
pkg/services/sqlstore/dashboard_service_integration_test.go:935:6⚠️ type scenarioContext is unused (U1000) (megacheck)
pkg/services/sqlstore/dashboard_service_integration_test.go:939:6⚠️ type scenarioFunc is unused (U1000) (megacheck)
pkg/services/sqlstore/dashboard_service_integration_test.go:941:6⚠️ func dashboardGuardianScenario is unused (U1000) (megacheck)
pkg/services/sqlstore/transactions_test.go:13:6⚠️ type testQuery is unused (U1000) (megacheck)

2018-10-01 18:23:59 +02:00

..

migrations

Fix some typos found by codespell

2018-09-21 11:54:52 +02:00

migrator

sql: added code migration type

2018-08-21 13:53:04 +02:00

sqlutil

move database-specific code into dialects (#11884)

2018-05-10 16:54:21 +02:00

alert_notification_test.go

alerting: move all notification conditions to defaultShouldNotify

2018-09-26 14:34:10 +02:00

alert_notification.go

alerting: move all notification conditions to defaultShouldNotify

2018-09-26 14:34:10 +02:00

alert_test.go

alert: add missing test after refactor

2018-07-17 22:17:43 +02:00

alert.go

pkg/services/sqlstore: Fix sess.Id is deprecated: use ID instead. (megacheck)

2018-09-16 12:37:08 +02:00

annotation_test.go

renames PartialMatch to MatchAny

2018-09-13 15:15:42 +02:00

annotation.go

Merge pull request #10163 from grafana/9587_annotation_tags_wih_temp_var

2018-09-17 10:34:38 +02:00

apikey_test.go

Added expire option to dashboard snapshots, #1623

2015-03-26 12:00:52 +01:00

apikey.go

sql: adds tests for InTransaction

2018-06-15 12:46:20 +02:00

dashboard_acl_test.go

pkg/services: fix ineffassign issues

2018-04-23 19:28:54 +02:00

dashboard_acl.go

return inherited property for permissions

2018-04-23 09:23:14 +02:00

dashboard_folder_test.go

new property for current user indicating if edit permissions in folders

2018-04-30 15:34:31 +02:00

dashboard_provisioning_test.go

provisioning: simplify db query

2018-04-10 12:30:37 +02:00

dashboard_provisioning.go

provisioning: simplify db query

2018-04-10 12:30:37 +02:00

dashboard_service_integration_test.go

Fix megacheck issue unused code.

2018-10-01 18:23:59 +02:00

dashboard_snapshot_test.go

Sqlstore refactor (#11908)

2018-05-18 11:10:10 +02:00

dashboard_snapshot.go

Simplify comparison to bool constant (gosimple)

2018-04-16 21:04:57 +02:00

dashboard_test.go

fix failing test due to time diff issues

2018-07-24 19:05:09 +02:00

dashboard_version_test.go

dashboard version cleanup: more tests and refactor

2018-03-22 15:18:05 +03:00

dashboard_version.go

dashboard version cleanup: more tests and refactor

2018-03-22 15:18:05 +03:00

dashboard.go

pkg/services/sqlstore: Fix x.Sql is deprecated: use SQL instead. (megacheck)

2018-09-16 12:26:05 +02:00

datasource_test.go

Shouldn't be able to overwrite a dashboard if you don't have permissions (#10900)

2018-02-19 11:12:56 +01:00

datasource.go

bug: return correct err message

2018-02-14 13:32:52 +01:00

health.go

feat: added api health endpoint that does not require auth and never creates sessions, returns db status as well. #3302

2017-04-25 17:17:45 +02:00

logger.go

dasboard_history: security fix, added orgId filter to dashboard version lookup

2017-06-07 14:21:40 +02:00

login_attempt_test.go

WIP: Protect against brute force (frequent) login attempts (#10031)

2018-01-26 10:41:41 +01:00

login_attempt.go

login: uses epochs for login throtting.

2018-02-16 17:25:46 +01:00

org_test.go

Allow settting of default org id to auto-assign to (#12401)

2018-07-13 12:14:40 -07:00

org_users.go

pkg/services/sqlstore: Fix sess.Id is deprecated: use ID instead. (megacheck)

2018-09-16 12:37:08 +02:00

org.go

pkg/services/sqlstore: Fix sess.Id is deprecated: use ID instead. (megacheck)

2018-09-16 12:37:08 +02:00

playlist_test.go

chore(playlist): remove commented code

2016-01-29 20:33:01 +01:00

playlist.go

move database-specific code into dialects (#11884)

2018-05-10 16:54:21 +02:00

plugin_setting.go

pkg/services/sqlstore: Fix sess.Id is deprecated: use ID instead. (megacheck)

2018-09-16 12:37:08 +02:00

preferences.go

pkg/services/sqlstore: Fix sess.Id is deprecated: use ID instead. (megacheck)

2018-09-16 12:37:08 +02:00

quota_test.go

Sqlstore refactor (#11908)

2018-05-18 11:10:10 +02:00

quota.go

pkg/services/sqlstore: Fix sess.Id is deprecated: use ID instead. (megacheck)

2018-09-16 12:37:08 +02:00

search_builder_test.go

move database-specific code into dialects (#11884)

2018-05-10 16:54:21 +02:00

search_builder.go

move database-specific code into dialects (#11884)

2018-05-10 16:54:21 +02:00

session.go

expose functions to use sessions

2018-06-18 14:50:36 +02:00

sql_test_data.go

refactor: sqlstore inTransaction consolidated to one version, fixes #8376

2017-05-23 10:56:23 +02:00

sqlbuilder.go

refactoring: alert rule query refactoring (#10941)

2018-02-16 13:56:04 +01:00

sqlstore.go

string formating fixes

2018-08-28 22:33:38 +02:00

sqlstore.goconvey

feat(invite): small progress

2015-07-17 14:42:49 +02:00

star.go

refactor: sqlstore inTransaction consolidated to one version, fixes #8376

2017-05-23 10:56:23 +02:00

stars_test.go

Fixed gofmt formating, updated precommit hook

2015-03-07 16:37:19 +01:00

stats_test.go

adds usage stats for alert notifiers (#13173)

2018-09-06 21:03:09 +02:00

stats.go

adds usage stats for alert notifiers (#13173)

2018-09-06 21:03:09 +02:00

tables.go

Began work on real sql schema definitions, and migration engine

2015-01-17 21:40:22 +01:00

team_test.go

new column for team_member table

2018-09-14 17:27:36 +02:00

team.go

Merge pull request #13295 from mjtrangoni/fix-some-megacheck-issues

2018-09-17 10:13:34 +02:00

temp_user_test.go

signup: fix email sent logic for tempuser

2017-06-30 20:21:08 +02:00

temp_user.go

pkg/services/sqlstore: Fix x.Sql is deprecated: use SQL instead. (megacheck)

2018-09-16 12:26:05 +02:00

tls_mysql.go

generalized database connection cert support and added to postgres

2016-11-22 15:29:22 -08:00

transactions_test.go

Fix megacheck issue unused code.

2018-10-01 18:23:59 +02:00

transactions.go

string formating fixes

2018-08-28 22:33:38 +02:00

user_auth_test.go

merge create user handlers

2018-06-15 21:23:57 +02:00

user_auth.go

refactor authproxy & ldap integration, address comments

2018-04-17 14:06:25 -04:00

user_test.go

sql: added code migration type

2018-08-21 13:53:04 +02:00

user.go

pkg/services/sqlstore/user.go: empty branch

2018-09-20 20:16:14 +02:00