Marcus Efraimsson
5ec086dc56
If notification state is pending and last update of state was made less than a minute ago. In the case of a grafana instance is shut down/crashes between setting pending state and before sending the notification/marks as complete this logic should allow the notification to be sent after some time instead of being left in an inconsistent state where no notifications are being sent.
264 lines
9.2 KiB
Go
264 lines
9.2 KiB
Go
package sqlstore
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
func TestAlertNotificationSQLAccess(t *testing.T) {
|
|
Convey("Testing Alert notification sql access", t, func() {
|
|
InitTestDB(t)
|
|
|
|
Convey("Alert notification state", func() {
|
|
var alertID int64 = 7
|
|
var orgID int64 = 5
|
|
var notifierID int64 = 10
|
|
oldTimeNow := timeNow
|
|
now := time.Date(2018, 9, 30, 0, 0, 0, 0, time.UTC)
|
|
timeNow = func() time.Time { return now }
|
|
|
|
Convey("Get no existing state should create a new state", func() {
|
|
query := &models.GetNotificationStateQuery{AlertId: alertID, OrgId: orgID, NotifierId: notifierID}
|
|
err := GetAlertNotificationState(context.Background(), query)
|
|
So(err, ShouldBeNil)
|
|
So(query.Result, ShouldNotBeNil)
|
|
So(query.Result.State, ShouldEqual, "unknown")
|
|
So(query.Result.Version, ShouldEqual, 0)
|
|
So(query.Result.UpdatedAt, ShouldEqual, now.Unix())
|
|
|
|
Convey("Get existing state should not create a new state", func() {
|
|
query2 := &models.GetNotificationStateQuery{AlertId: alertID, OrgId: orgID, NotifierId: notifierID}
|
|
err := GetAlertNotificationState(context.Background(), query2)
|
|
So(err, ShouldBeNil)
|
|
So(query2.Result, ShouldNotBeNil)
|
|
So(query2.Result.Id, ShouldEqual, query.Result.Id)
|
|
So(query2.Result.UpdatedAt, ShouldEqual, now.Unix())
|
|
})
|
|
|
|
Convey("Update existing state to pending with correct version should update database", func() {
|
|
s := *query.Result
|
|
cmd := models.SetAlertNotificationStateToPendingCommand{
|
|
State: &s,
|
|
}
|
|
err := SetAlertNotificationStateToPendingCommand(context.Background(), &cmd)
|
|
So(err, ShouldBeNil)
|
|
So(cmd.State.Version, ShouldEqual, 1)
|
|
So(cmd.State.State, ShouldEqual, models.AlertNotificationStatePending)
|
|
|
|
query2 := &models.GetNotificationStateQuery{AlertId: alertID, OrgId: orgID, NotifierId: notifierID}
|
|
err = GetAlertNotificationState(context.Background(), query2)
|
|
So(err, ShouldBeNil)
|
|
So(query2.Result.Version, ShouldEqual, 1)
|
|
So(query2.Result.State, ShouldEqual, models.AlertNotificationStatePending)
|
|
So(query2.Result.UpdatedAt, ShouldEqual, now.Unix())
|
|
|
|
Convey("Update existing state to completed should update database", func() {
|
|
s := *cmd.State
|
|
cmd := models.SetAlertNotificationStateToCompleteCommand{
|
|
State: &s,
|
|
}
|
|
err := SetAlertNotificationStateToCompleteCommand(context.Background(), &cmd)
|
|
So(err, ShouldBeNil)
|
|
|
|
query3 := &models.GetNotificationStateQuery{AlertId: alertID, OrgId: orgID, NotifierId: notifierID}
|
|
err = GetAlertNotificationState(context.Background(), query3)
|
|
So(err, ShouldBeNil)
|
|
So(query3.Result.Version, ShouldEqual, 2)
|
|
So(query3.Result.State, ShouldEqual, models.AlertNotificationStateCompleted)
|
|
So(query3.Result.UpdatedAt, ShouldEqual, now.Unix())
|
|
})
|
|
|
|
Convey("Update existing state to completed should update database, but return version mismatch", func() {
|
|
cmd.State.Version = 1000
|
|
s := *cmd.State
|
|
cmd := models.SetAlertNotificationStateToCompleteCommand{
|
|
State: &s,
|
|
}
|
|
err := SetAlertNotificationStateToCompleteCommand(context.Background(), &cmd)
|
|
So(err, ShouldEqual, models.ErrAlertNotificationStateVersionConflict)
|
|
|
|
query3 := &models.GetNotificationStateQuery{AlertId: alertID, OrgId: orgID, NotifierId: notifierID}
|
|
err = GetAlertNotificationState(context.Background(), query3)
|
|
So(err, ShouldBeNil)
|
|
So(query3.Result.Version, ShouldEqual, 1001)
|
|
So(query3.Result.State, ShouldEqual, models.AlertNotificationStateCompleted)
|
|
So(query3.Result.UpdatedAt, ShouldEqual, now.Unix())
|
|
})
|
|
})
|
|
|
|
Convey("Update existing state to pending with incorrect version should return version mismatch error", func() {
|
|
s := *query.Result
|
|
s.Version = 1000
|
|
cmd := models.SetAlertNotificationStateToPendingCommand{
|
|
State: &s,
|
|
}
|
|
err := SetAlertNotificationStateToPendingCommand(context.Background(), &cmd)
|
|
So(err, ShouldEqual, models.ErrAlertNotificationStateVersionConflict)
|
|
})
|
|
})
|
|
|
|
Reset(func() {
|
|
timeNow = oldTimeNow
|
|
})
|
|
})
|
|
|
|
Convey("Alert notifications should be empty", func() {
|
|
cmd := &models.GetAlertNotificationsQuery{
|
|
OrgId: 2,
|
|
Name: "email",
|
|
}
|
|
|
|
err := GetAlertNotifications(cmd)
|
|
So(err, ShouldBeNil)
|
|
So(cmd.Result, ShouldBeNil)
|
|
})
|
|
|
|
Convey("Cannot save alert notifier with send reminder = true", func() {
|
|
cmd := &models.CreateAlertNotificationCommand{
|
|
Name: "ops",
|
|
Type: "email",
|
|
OrgId: 1,
|
|
SendReminder: true,
|
|
Settings: simplejson.New(),
|
|
}
|
|
|
|
Convey("and missing frequency", func() {
|
|
err := CreateAlertNotificationCommand(cmd)
|
|
So(err, ShouldEqual, models.ErrNotificationFrequencyNotFound)
|
|
})
|
|
|
|
Convey("invalid frequency", func() {
|
|
cmd.Frequency = "invalid duration"
|
|
|
|
err := CreateAlertNotificationCommand(cmd)
|
|
So(err.Error(), ShouldEqual, "time: invalid duration invalid duration")
|
|
})
|
|
})
|
|
|
|
Convey("Cannot update alert notifier with send reminder = false", func() {
|
|
cmd := &models.CreateAlertNotificationCommand{
|
|
Name: "ops update",
|
|
Type: "email",
|
|
OrgId: 1,
|
|
SendReminder: false,
|
|
Settings: simplejson.New(),
|
|
}
|
|
|
|
err := CreateAlertNotificationCommand(cmd)
|
|
So(err, ShouldBeNil)
|
|
|
|
updateCmd := &models.UpdateAlertNotificationCommand{
|
|
Id: cmd.Result.Id,
|
|
SendReminder: true,
|
|
}
|
|
|
|
Convey("and missing frequency", func() {
|
|
err := UpdateAlertNotification(updateCmd)
|
|
So(err, ShouldEqual, models.ErrNotificationFrequencyNotFound)
|
|
})
|
|
|
|
Convey("invalid frequency", func() {
|
|
updateCmd.Frequency = "invalid duration"
|
|
|
|
err := UpdateAlertNotification(updateCmd)
|
|
So(err, ShouldNotBeNil)
|
|
So(err.Error(), ShouldEqual, "time: invalid duration invalid duration")
|
|
})
|
|
})
|
|
|
|
Convey("Can save Alert Notification", func() {
|
|
cmd := &models.CreateAlertNotificationCommand{
|
|
Name: "ops",
|
|
Type: "email",
|
|
OrgId: 1,
|
|
SendReminder: true,
|
|
Frequency: "10s",
|
|
Settings: simplejson.New(),
|
|
}
|
|
|
|
err := CreateAlertNotificationCommand(cmd)
|
|
So(err, ShouldBeNil)
|
|
So(cmd.Result.Id, ShouldNotEqual, 0)
|
|
So(cmd.Result.OrgId, ShouldNotEqual, 0)
|
|
So(cmd.Result.Type, ShouldEqual, "email")
|
|
So(cmd.Result.Frequency, ShouldEqual, 10*time.Second)
|
|
|
|
Convey("Cannot save Alert Notification with the same name", func() {
|
|
err = CreateAlertNotificationCommand(cmd)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("Can update alert notification", func() {
|
|
newCmd := &models.UpdateAlertNotificationCommand{
|
|
Name: "NewName",
|
|
Type: "webhook",
|
|
OrgId: cmd.Result.OrgId,
|
|
SendReminder: true,
|
|
Frequency: "60s",
|
|
Settings: simplejson.New(),
|
|
Id: cmd.Result.Id,
|
|
}
|
|
err := UpdateAlertNotification(newCmd)
|
|
So(err, ShouldBeNil)
|
|
So(newCmd.Result.Name, ShouldEqual, "NewName")
|
|
So(newCmd.Result.Frequency, ShouldEqual, 60*time.Second)
|
|
})
|
|
|
|
Convey("Can update alert notification to disable sending of reminders", func() {
|
|
newCmd := &models.UpdateAlertNotificationCommand{
|
|
Name: "NewName",
|
|
Type: "webhook",
|
|
OrgId: cmd.Result.OrgId,
|
|
SendReminder: false,
|
|
Settings: simplejson.New(),
|
|
Id: cmd.Result.Id,
|
|
}
|
|
err := UpdateAlertNotification(newCmd)
|
|
So(err, ShouldBeNil)
|
|
So(newCmd.Result.SendReminder, ShouldBeFalse)
|
|
})
|
|
})
|
|
|
|
Convey("Can search using an array of ids", func() {
|
|
cmd1 := models.CreateAlertNotificationCommand{Name: "nagios", Type: "webhook", OrgId: 1, SendReminder: true, Frequency: "10s", Settings: simplejson.New()}
|
|
cmd2 := models.CreateAlertNotificationCommand{Name: "slack", Type: "webhook", OrgId: 1, SendReminder: true, Frequency: "10s", Settings: simplejson.New()}
|
|
cmd3 := models.CreateAlertNotificationCommand{Name: "ops2", Type: "email", OrgId: 1, SendReminder: true, Frequency: "10s", Settings: simplejson.New()}
|
|
cmd4 := models.CreateAlertNotificationCommand{IsDefault: true, Name: "default", Type: "email", OrgId: 1, SendReminder: true, Frequency: "10s", Settings: simplejson.New()}
|
|
|
|
otherOrg := models.CreateAlertNotificationCommand{Name: "default", Type: "email", OrgId: 2, SendReminder: true, Frequency: "10s", Settings: simplejson.New()}
|
|
|
|
So(CreateAlertNotificationCommand(&cmd1), ShouldBeNil)
|
|
So(CreateAlertNotificationCommand(&cmd2), ShouldBeNil)
|
|
So(CreateAlertNotificationCommand(&cmd3), ShouldBeNil)
|
|
So(CreateAlertNotificationCommand(&cmd4), ShouldBeNil)
|
|
So(CreateAlertNotificationCommand(&otherOrg), ShouldBeNil)
|
|
|
|
Convey("search", func() {
|
|
query := &models.GetAlertNotificationsToSendQuery{
|
|
Ids: []int64{cmd1.Result.Id, cmd2.Result.Id, 112341231},
|
|
OrgId: 1,
|
|
}
|
|
|
|
err := GetAlertNotificationsToSend(query)
|
|
So(err, ShouldBeNil)
|
|
So(len(query.Result), ShouldEqual, 3)
|
|
})
|
|
|
|
Convey("all", func() {
|
|
query := &models.GetAllAlertNotificationsQuery{
|
|
OrgId: 1,
|
|
}
|
|
|
|
err := GetAllAlertNotifications(query)
|
|
So(err, ShouldBeNil)
|
|
So(len(query.Result), ShouldEqual, 4)
|
|
})
|
|
})
|
|
})
|
|
}
|