* Plugins: Angular detector: Remote patterns fetching
* Renamed PatternType to GCOMPatternType
* Renamed files
* Renamed more files
* Moved files again
* Add type checks, unexport GCOM structs
* Cache failures, update log messages, fix GCOM URL
* Fail silently for unknown pattern types, update docstrings
* Fix tests
* Rename gcomPattern.Value to gcomPattern.Pattern
* Refactoring
* Add FlagPluginsRemoteAngularDetectionPatterns feature flag
* Fix tests
* Re-generate feature flags
* Add TestProvideInspector, renamed TestDefaultStaticDetectorsInspector
* Add TestProvideInspector
* Add TestContainsBytesDetector and TestRegexDetector
* Renamed getter to provider
* More tests
* TestStaticDetectorsProvider, TestSequenceDetectorsProvider
* GCOM tests
* Lint
* Made detector.detect unexported, updated docstrings
* Allow changing grafana.com URL
* Fix API path, add more logs
* Update tryUpdateRemoteDetectors docstring
* Use angulardetector http client
* Return false, nil if module.js does not exist
* Chore: Split angualrdetector into angularinspector and angulardetector packages
Moved files around, changed references and fixed tests:
- Split the old angulardetector package into angular/angulardetector and angular/angularinspector
- angulardetector provides the detection structs/interfaces (Detector, DetectorsProvider...)
- angularinspector provides the actual angular detection service used directly in pluginsintegration
- Exported most of the stuff that was private and now put into angulardetector, as it is not required by angularinspector
* Renamed detector.go -> angulardetector.go and inspector.go -> angularinspector.go
Forgot to rename those two files to match the package's names
* Renamed angularinspector.ProvideInspector to angularinspector.ProvideService
* Renamed "harcoded" to "static" and "remote" to "dynamic"
from PR review, matches the same naming schema used for signing keys fetching
* WIP: Angular: cache patterns in db, moved gcom into pluginsintegration
More similar to signing keys fetching
* Rename package, refactoring
* try to solve circular import
* Fix merge conflict on updated angular patterns
* Fix circular imports
* Fix wire gen
* Add docstrings, refactoring
* Removed angualrdetectorsprovider dependency into angularpatternsstore
* Moved GCOM test files
* Removed GCOM cache
* Renamed Detect to DetectAngular and Detector to AngularDetector
* Fix call to NewGCOMDetectorsProvider in newDynamicInspector
* Removed unused test function newError500GCOMScenario
* Added angularinspector service definition in pluginsintegration
* refactoring
* lint
* Fix angularinspector TestProvideService
* cleanup
* Await initial restore
* Register dynamicAngularDetector background service
* Removed static detectors provider from pluginsintegration
* Add tests for kvstore
* Add more tests
* order imports in dynamic_test.go
* Fix potential panic in dynamic_test
* Add "runs the job periodically" test
* lint
* add timeout to test
* refactoring
* Removed context.Context from DetectorsProvider
* Refactoring, ensure angular dynamic background service is not started if feature flag is off
* Fix deadlock on startup
* Fix angulardetectorsprovider tests
* Revert "Removed context.Context from DetectorsProvider"
This reverts commit 4e8c6dded7.
* Fix wrong argument number in dynamic_teset
* Standardize gcom http client
* Reduce context timeout for angular inspector in plugins loader
* Simplify initial restore logic
* Fix dynamic detectors provider tests
* Chore: removed angulardetector/provider.go
* Add more tests
* Removed backgroundJob interface, PR review feedback
* Update tests
* PR review feedback: remove ErrNoCachedValue from kv store Get
* Update tests
* PR review feedback: add IsDisabled and remove nop background srevice
* Update tests
* Remove initialRestore channel, use mux instead
* Removed backgroundJobInterval, use package-level variable instead
* Add TestDynamicAngularDetectorsProviderBackgroundService
* Removed timeouts
* pr review feedback: restore from store before returning the service
* Update tests
* Log duration on startup restore and cron run
* Switch cron job start log to debug level
* Do not attempt to restore if disabled
391 lines
12 KiB
Go
391 lines
12 KiB
Go
package loader
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"path"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/grafana/grafana/pkg/infra/metrics"
|
|
"github.com/grafana/grafana/pkg/infra/slugify"
|
|
"github.com/grafana/grafana/pkg/plugins"
|
|
"github.com/grafana/grafana/pkg/plugins/config"
|
|
"github.com/grafana/grafana/pkg/plugins/log"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/loader/angular/angularinspector"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/loader/assetpath"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/loader/finder"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/loader/initializer"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/process"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/registry"
|
|
"github.com/grafana/grafana/pkg/plugins/manager/signature"
|
|
"github.com/grafana/grafana/pkg/plugins/oauth"
|
|
"github.com/grafana/grafana/pkg/services/featuremgmt"
|
|
"github.com/grafana/grafana/pkg/util"
|
|
)
|
|
|
|
var _ plugins.ErrorResolver = (*Loader)(nil)
|
|
|
|
type Loader struct {
|
|
pluginFinder finder.Finder
|
|
processManager process.Service
|
|
pluginRegistry registry.Service
|
|
roleRegistry plugins.RoleRegistry
|
|
pluginInitializer initializer.Initializer
|
|
signatureValidator signature.Validator
|
|
signatureCalculator plugins.SignatureCalculator
|
|
externalServiceRegistry oauth.ExternalServiceRegistry
|
|
assetPath *assetpath.Service
|
|
log log.Logger
|
|
cfg *config.Cfg
|
|
|
|
angularInspector angularinspector.Inspector
|
|
|
|
errs map[string]*plugins.SignatureError
|
|
}
|
|
|
|
func ProvideService(cfg *config.Cfg, license plugins.Licensing, authorizer plugins.PluginLoaderAuthorizer,
|
|
pluginRegistry registry.Service, backendProvider plugins.BackendFactoryProvider, pluginFinder finder.Finder,
|
|
roleRegistry plugins.RoleRegistry, assetPath *assetpath.Service, signatureCalculator plugins.SignatureCalculator,
|
|
angularInspector angularinspector.Inspector, externalServiceRegistry oauth.ExternalServiceRegistry) *Loader {
|
|
return New(cfg, license, authorizer, pluginRegistry, backendProvider, process.NewManager(pluginRegistry),
|
|
roleRegistry, assetPath, pluginFinder, signatureCalculator, angularInspector, externalServiceRegistry)
|
|
}
|
|
|
|
func New(cfg *config.Cfg, license plugins.Licensing, authorizer plugins.PluginLoaderAuthorizer,
|
|
pluginRegistry registry.Service, backendProvider plugins.BackendFactoryProvider,
|
|
processManager process.Service, roleRegistry plugins.RoleRegistry,
|
|
assetPath *assetpath.Service, pluginFinder finder.Finder, signatureCalculator plugins.SignatureCalculator,
|
|
angularInspector angularinspector.Inspector, externalServiceRegistry oauth.ExternalServiceRegistry) *Loader {
|
|
return &Loader{
|
|
pluginFinder: pluginFinder,
|
|
pluginRegistry: pluginRegistry,
|
|
pluginInitializer: initializer.New(cfg, backendProvider, license),
|
|
signatureValidator: signature.NewValidator(authorizer),
|
|
signatureCalculator: signatureCalculator,
|
|
processManager: processManager,
|
|
errs: make(map[string]*plugins.SignatureError),
|
|
log: log.New("plugin.loader"),
|
|
roleRegistry: roleRegistry,
|
|
cfg: cfg,
|
|
assetPath: assetPath,
|
|
angularInspector: angularInspector,
|
|
externalServiceRegistry: externalServiceRegistry,
|
|
}
|
|
}
|
|
|
|
func (l *Loader) Load(ctx context.Context, src plugins.PluginSource) ([]*plugins.Plugin, error) {
|
|
found, err := l.pluginFinder.Find(ctx, src)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return l.loadPlugins(ctx, src, found)
|
|
}
|
|
|
|
// nolint:gocyclo
|
|
func (l *Loader) loadPlugins(ctx context.Context, src plugins.PluginSource, found []*plugins.FoundBundle) ([]*plugins.Plugin, error) {
|
|
loadedPlugins := make([]*plugins.Plugin, 0, len(found))
|
|
|
|
for _, p := range found {
|
|
if _, exists := l.pluginRegistry.Plugin(ctx, p.Primary.JSONData.ID); exists {
|
|
l.log.Warn("Skipping plugin loading as it's a duplicate", "pluginID", p.Primary.JSONData.ID)
|
|
continue
|
|
}
|
|
|
|
sig, err := l.signatureCalculator.Calculate(ctx, src, p.Primary)
|
|
if err != nil {
|
|
l.log.Warn("Could not calculate plugin signature state", "pluginID", p.Primary.JSONData.ID, "err", err)
|
|
continue
|
|
}
|
|
plugin, err := l.createPluginBase(p.Primary.JSONData, src.PluginClass(ctx), p.Primary.FS)
|
|
if err != nil {
|
|
l.log.Error("Could not create primary plugin base", "pluginID", p.Primary.JSONData.ID, "err", err)
|
|
continue
|
|
}
|
|
|
|
plugin.Signature = sig.Status
|
|
plugin.SignatureType = sig.Type
|
|
plugin.SignatureOrg = sig.SigningOrg
|
|
|
|
loadedPlugins = append(loadedPlugins, plugin)
|
|
|
|
for _, c := range p.Children {
|
|
if _, exists := l.pluginRegistry.Plugin(ctx, c.JSONData.ID); exists {
|
|
l.log.Warn("Skipping plugin loading as it's a duplicate", "pluginID", p.Primary.JSONData.ID)
|
|
continue
|
|
}
|
|
|
|
cp, err := l.createPluginBase(c.JSONData, plugin.Class, c.FS)
|
|
if err != nil {
|
|
l.log.Error("Could not create child plugin base", "pluginID", p.Primary.JSONData.ID, "err", err)
|
|
continue
|
|
}
|
|
cp.Parent = plugin
|
|
cp.Signature = sig.Status
|
|
cp.SignatureType = sig.Type
|
|
cp.SignatureOrg = sig.SigningOrg
|
|
|
|
plugin.Children = append(plugin.Children, cp)
|
|
|
|
loadedPlugins = append(loadedPlugins, cp)
|
|
}
|
|
}
|
|
|
|
// validate signatures
|
|
verifiedPlugins := make([]*plugins.Plugin, 0, len(loadedPlugins))
|
|
for _, plugin := range loadedPlugins {
|
|
signingError := l.signatureValidator.Validate(plugin)
|
|
if signingError != nil {
|
|
l.log.Warn("Skipping loading plugin due to problem with signature",
|
|
"pluginID", plugin.ID, "status", signingError.SignatureStatus)
|
|
plugin.SignatureError = signingError
|
|
l.errs[plugin.ID] = signingError
|
|
// skip plugin so it will not be loaded any further
|
|
continue
|
|
}
|
|
|
|
// clear plugin error if a pre-existing error has since been resolved
|
|
delete(l.errs, plugin.ID)
|
|
|
|
// Hardcoded alias changes
|
|
switch plugin.ID {
|
|
case "grafana-pyroscope-datasource": // rebranding
|
|
plugin.Alias = "phlare"
|
|
case "debug": // panel plugin used for testing
|
|
plugin.Alias = "debugX"
|
|
}
|
|
|
|
// verify module.js exists for SystemJS to load.
|
|
// CDN plugins can be loaded with plugin.json only, so do not warn for those.
|
|
if !plugin.IsRenderer() && !plugin.IsCorePlugin() {
|
|
f, err := plugin.FS.Open("module.js")
|
|
if err != nil {
|
|
if errors.Is(err, plugins.ErrFileNotExist) {
|
|
l.log.Warn("Plugin missing module.js", "pluginID", plugin.ID,
|
|
"warning", "Missing module.js, If you loaded this plugin from git, make sure to compile it.")
|
|
}
|
|
} else if f != nil {
|
|
if err := f.Close(); err != nil {
|
|
l.log.Warn("Could not close module.js", "pluginID", plugin.ID, "err", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
if plugin.IsApp() {
|
|
setDefaultNavURL(plugin)
|
|
}
|
|
|
|
if plugin.Parent != nil && plugin.Parent.IsApp() {
|
|
configureAppChildPlugin(plugin.Parent, plugin)
|
|
}
|
|
|
|
verifiedPlugins = append(verifiedPlugins, plugin)
|
|
}
|
|
|
|
// initialize plugins
|
|
initializedPlugins := make([]*plugins.Plugin, 0, len(verifiedPlugins))
|
|
for _, p := range verifiedPlugins {
|
|
// detect angular for external plugins
|
|
if p.IsExternalPlugin() {
|
|
var err error
|
|
|
|
cctx, canc := context.WithTimeout(ctx, time.Second*10)
|
|
p.AngularDetected, err = l.angularInspector.Inspect(cctx, p)
|
|
canc()
|
|
|
|
if err != nil {
|
|
l.log.Warn("Could not inspect plugin for angular", "pluginID", p.ID, "err", err)
|
|
}
|
|
|
|
// Do not initialize plugins if they're using Angular and Angular support is disabled
|
|
if p.AngularDetected && !l.cfg.AngularSupportEnabled {
|
|
l.log.Error("Refusing to initialize plugin because it's using Angular, which has been disabled", "pluginID", p.ID)
|
|
continue
|
|
}
|
|
}
|
|
|
|
if p.ExternalServiceRegistration != nil && l.cfg.Features.IsEnabled(featuremgmt.FlagExternalServiceAuth) {
|
|
s, err := l.externalServiceRegistry.RegisterExternalService(ctx, p.ID, p.ExternalServiceRegistration)
|
|
if err != nil {
|
|
l.log.Error("Could not register an external service. Initialization skipped", "pluginID", p.ID, "err", err)
|
|
continue
|
|
}
|
|
p.ExternalService = s
|
|
}
|
|
|
|
err := l.pluginInitializer.Initialize(ctx, p)
|
|
if err != nil {
|
|
l.log.Error("Could not initialize plugin", "pluginId", p.ID, "err", err)
|
|
continue
|
|
}
|
|
if errDeclareRoles := l.roleRegistry.DeclarePluginRoles(ctx, p.ID, p.Name, p.Roles); errDeclareRoles != nil {
|
|
l.log.Warn("Declare plugin roles failed.", "pluginID", p.ID, "err", errDeclareRoles)
|
|
}
|
|
|
|
initializedPlugins = append(initializedPlugins, p)
|
|
}
|
|
|
|
for _, p := range initializedPlugins {
|
|
if err := l.load(ctx, p); err != nil {
|
|
l.log.Error("Could not start plugin", "pluginId", p.ID, "err", err)
|
|
}
|
|
|
|
if !p.IsCorePlugin() && !p.IsBundledPlugin() {
|
|
metrics.SetPluginBuildInformation(p.ID, string(p.Type), p.Info.Version, string(p.Signature))
|
|
}
|
|
}
|
|
|
|
return initializedPlugins, nil
|
|
}
|
|
|
|
func (l *Loader) Unload(ctx context.Context, pluginID string) error {
|
|
plugin, exists := l.pluginRegistry.Plugin(ctx, pluginID)
|
|
if !exists {
|
|
return plugins.ErrPluginNotInstalled
|
|
}
|
|
|
|
if plugin.IsCorePlugin() || plugin.IsBundledPlugin() {
|
|
return plugins.ErrUninstallCorePlugin
|
|
}
|
|
|
|
if err := l.unload(ctx, plugin); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (l *Loader) load(ctx context.Context, p *plugins.Plugin) error {
|
|
if err := l.pluginRegistry.Add(ctx, p); err != nil {
|
|
return err
|
|
}
|
|
|
|
if !p.IsCorePlugin() {
|
|
l.log.Info("Plugin registered", "pluginID", p.ID)
|
|
}
|
|
|
|
return l.processManager.Start(ctx, p.ID)
|
|
}
|
|
|
|
func (l *Loader) unload(ctx context.Context, p *plugins.Plugin) error {
|
|
l.log.Debug("Stopping plugin process", "pluginId", p.ID)
|
|
|
|
if err := l.processManager.Stop(ctx, p.ID); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := l.pluginRegistry.Remove(ctx, p.ID); err != nil {
|
|
return err
|
|
}
|
|
l.log.Debug("Plugin unregistered", "pluginId", p.ID)
|
|
|
|
if remover, ok := p.FS.(plugins.FSRemover); ok {
|
|
if err := remover.Remove(); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (l *Loader) createPluginBase(pluginJSON plugins.JSONData, class plugins.Class, files plugins.FS) (*plugins.Plugin, error) {
|
|
baseURL, err := l.assetPath.Base(pluginJSON, class, files.Base())
|
|
if err != nil {
|
|
return nil, fmt.Errorf("base url: %w", err)
|
|
}
|
|
moduleURL, err := l.assetPath.Module(pluginJSON, class, files.Base())
|
|
if err != nil {
|
|
return nil, fmt.Errorf("module url: %w", err)
|
|
}
|
|
plugin := &plugins.Plugin{
|
|
JSONData: pluginJSON,
|
|
FS: files,
|
|
BaseURL: baseURL,
|
|
Module: moduleURL,
|
|
Class: class,
|
|
}
|
|
|
|
plugin.SetLogger(log.New(fmt.Sprintf("plugin.%s", plugin.ID)))
|
|
if err := l.setImages(plugin); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return plugin, nil
|
|
}
|
|
|
|
func (l *Loader) setImages(p *plugins.Plugin) error {
|
|
var err error
|
|
for _, dst := range []*string{&p.Info.Logos.Small, &p.Info.Logos.Large} {
|
|
*dst, err = l.assetPath.RelativeURL(p, *dst, defaultLogoPath(p.Type))
|
|
if err != nil {
|
|
return fmt.Errorf("logo: %w", err)
|
|
}
|
|
}
|
|
for i := 0; i < len(p.Info.Screenshots); i++ {
|
|
screenshot := &p.Info.Screenshots[i]
|
|
screenshot.Path, err = l.assetPath.RelativeURL(p, screenshot.Path, "")
|
|
if err != nil {
|
|
return fmt.Errorf("screenshot %d relative url: %w", i, err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func setDefaultNavURL(p *plugins.Plugin) {
|
|
// slugify pages
|
|
for _, include := range p.Includes {
|
|
if include.Slug == "" {
|
|
include.Slug = slugify.Slugify(include.Name)
|
|
}
|
|
|
|
if !include.DefaultNav {
|
|
continue
|
|
}
|
|
|
|
if include.Type == "page" {
|
|
p.DefaultNavURL = path.Join("/plugins/", p.ID, "/page/", include.Slug)
|
|
}
|
|
if include.Type == "dashboard" {
|
|
dboardURL := include.DashboardURLPath()
|
|
if dboardURL == "" {
|
|
p.Logger().Warn("Included dashboard is missing a UID field")
|
|
continue
|
|
}
|
|
|
|
p.DefaultNavURL = dboardURL
|
|
}
|
|
}
|
|
}
|
|
|
|
func configureAppChildPlugin(parent *plugins.Plugin, child *plugins.Plugin) {
|
|
if !parent.IsApp() {
|
|
return
|
|
}
|
|
appSubPath := strings.ReplaceAll(strings.Replace(child.FS.Base(), parent.FS.Base(), "", 1), "\\", "/")
|
|
child.IncludedInAppID = parent.ID
|
|
child.BaseURL = parent.BaseURL
|
|
|
|
if parent.IsCorePlugin() {
|
|
child.Module = util.JoinURLFragments("app/plugins/app/"+parent.ID, appSubPath) + "/module"
|
|
} else {
|
|
child.Module = util.JoinURLFragments("plugins/"+parent.ID, appSubPath) + "/module"
|
|
}
|
|
}
|
|
|
|
func defaultLogoPath(pluginType plugins.Type) string {
|
|
return "public/img/icn-" + string(pluginType) + ".svg"
|
|
}
|
|
|
|
func (l *Loader) PluginErrors() []*plugins.Error {
|
|
errs := make([]*plugins.Error, 0, len(l.errs))
|
|
for _, err := range l.errs {
|
|
errs = append(errs, &plugins.Error{
|
|
PluginID: err.PluginID,
|
|
ErrorCode: err.AsErrorCode(),
|
|
})
|
|
}
|
|
|
|
return errs
|
|
}
|