722c414fef
* Encryption: Add support to encrypt/decrypt sjd * Add datasources.Service as a proxy to datasources db operations * Encrypt ds.SecureJsonData before calling SQLStore * Move ds cache code into ds service * Fix tlsmanager tests * Fix pluginproxy tests * Remove some securejsondata.GetEncryptedJsonData usages * Add pluginsettings.Service as a proxy for plugin settings db operations * Add AlertNotificationService as a proxy for alert notification db operations * Remove some securejsondata.GetEncryptedJsonData usages * Remove more securejsondata.GetEncryptedJsonData usages * Fix lint errors * Minor fixes * Remove encryption global functions usages from ngalert * Fix lint errors * Minor fixes * Minor fixes * Remove securejsondata.DecryptedValue usage * Refactor the refactor * Remove securejsondata.DecryptedValue usage * Move securejsondata to migrations package * Move securejsondata to migrations package * Minor fix * Fix integration test * Fix integration tests * Undo undesired changes * Fix tests * Add context.Context into encryption methods * Fix tests * Fix tests * Fix tests * Trigger CI * Fix test * Add names to params of encryption service interface * Remove bus from CacheServiceImpl * Add logging * Add keys to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Add missing key to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Undo changes in markdown files * Fix formatting * Add context to secrets service * Rename decryptSecureJsonData to decryptSecureJsonDataFn * Name args in GetDecryptedValueFn * Add template back to NewAlertmanagerNotifier * Copy GetDecryptedValueFn to ngalert * Add logging to pluginsettings * Fix pluginsettings test Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
227 lines
7.3 KiB
Go
227 lines
7.3 KiB
Go
package notifiers
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/pkg/bus"
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/alerting"
|
|
"github.com/grafana/grafana/pkg/services/encryption/ossencryption"
|
|
"github.com/grafana/grafana/pkg/services/validations"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
func TestOpsGenieNotifier(t *testing.T) {
|
|
Convey("OpsGenie notifier tests", t, func() {
|
|
Convey("Parsing alert notification from settings", func() {
|
|
Convey("empty settings should return error", func() {
|
|
json := `{ }`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
_, err := NewOpsGenieNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("settings should trigger incident", func() {
|
|
json := `
|
|
{
|
|
"apiKey": "abcdefgh0123456789"
|
|
}`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewOpsGenieNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
|
|
opsgenieNotifier := not.(*OpsGenieNotifier)
|
|
|
|
So(err, ShouldBeNil)
|
|
So(opsgenieNotifier.Name, ShouldEqual, "opsgenie_testing")
|
|
So(opsgenieNotifier.Type, ShouldEqual, "opsgenie")
|
|
So(opsgenieNotifier.APIKey, ShouldEqual, "abcdefgh0123456789")
|
|
})
|
|
})
|
|
|
|
Convey("Handling notification tags", func() {
|
|
Convey("invalid sendTagsAs value should return error", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789",
|
|
"sendTagsAs": "not_a_valid_value"
|
|
}`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
_, err := NewOpsGenieNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
|
|
So(err, ShouldNotBeNil)
|
|
So(err, ShouldHaveSameTypeAs, alerting.ValidationError{})
|
|
So(err.Error(), ShouldEndWith, "Invalid value for sendTagsAs: \"not_a_valid_value\"")
|
|
})
|
|
|
|
Convey("alert payload should include tag pairs only as an array in the tags key when sendAsTags is not set", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789"
|
|
}`
|
|
|
|
tagPairs := []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "aKey", Value: "aValue"},
|
|
}
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
notifier, notifierErr := NewOpsGenieNotifier(model, ossencryption.ProvideService().GetDecryptedValue) // unhandled error
|
|
|
|
opsgenieNotifier := notifier.(*OpsGenieNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: tagPairs,
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
evalContext.IsTestRun = true
|
|
|
|
tags := make([]string, 0)
|
|
details := make(map[string]interface{})
|
|
bus.AddHandlerCtx("alerting", func(ctx context.Context, cmd *models.SendWebhookSync) error {
|
|
bodyJSON, err := simplejson.NewJson([]byte(cmd.Body))
|
|
if err == nil {
|
|
tags = bodyJSON.Get("tags").MustStringArray([]string{})
|
|
details = bodyJSON.Get("details").MustMap(map[string]interface{}{})
|
|
}
|
|
return err
|
|
})
|
|
|
|
alertErr := opsgenieNotifier.createAlert(evalContext)
|
|
|
|
So(notifierErr, ShouldBeNil)
|
|
So(alertErr, ShouldBeNil)
|
|
So(tags, ShouldResemble, []string{"keyOnly", "aKey:aValue"})
|
|
So(details, ShouldResemble, map[string]interface{}{"url": ""})
|
|
})
|
|
|
|
Convey("alert payload should include tag pairs only as a map in the details key when sendAsTags=details", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789",
|
|
"sendTagsAs": "details"
|
|
}`
|
|
|
|
tagPairs := []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "aKey", Value: "aValue"},
|
|
}
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
notifier, notifierErr := NewOpsGenieNotifier(model, ossencryption.ProvideService().GetDecryptedValue) // unhandled error
|
|
|
|
opsgenieNotifier := notifier.(*OpsGenieNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: tagPairs,
|
|
}, nil)
|
|
evalContext.IsTestRun = true
|
|
|
|
tags := make([]string, 0)
|
|
details := make(map[string]interface{})
|
|
bus.AddHandlerCtx("alerting", func(ctx context.Context, cmd *models.SendWebhookSync) error {
|
|
bodyJSON, err := simplejson.NewJson([]byte(cmd.Body))
|
|
if err == nil {
|
|
tags = bodyJSON.Get("tags").MustStringArray([]string{})
|
|
details = bodyJSON.Get("details").MustMap(map[string]interface{}{})
|
|
}
|
|
return err
|
|
})
|
|
|
|
alertErr := opsgenieNotifier.createAlert(evalContext)
|
|
|
|
So(notifierErr, ShouldBeNil)
|
|
So(alertErr, ShouldBeNil)
|
|
So(tags, ShouldResemble, []string{})
|
|
So(details, ShouldResemble, map[string]interface{}{"keyOnly": "", "aKey": "aValue", "url": ""})
|
|
})
|
|
|
|
Convey("alert payload should include tag pairs as both a map in the details key and an array in the tags key when sendAsTags=both", func() {
|
|
json := `{
|
|
"apiKey": "abcdefgh0123456789",
|
|
"sendTagsAs": "both"
|
|
}`
|
|
|
|
tagPairs := []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "aKey", Value: "aValue"},
|
|
}
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "opsgenie_testing",
|
|
Type: "opsgenie",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
notifier, notifierErr := NewOpsGenieNotifier(model, ossencryption.ProvideService().GetDecryptedValue) // unhandled error
|
|
|
|
opsgenieNotifier := notifier.(*OpsGenieNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: tagPairs,
|
|
}, nil)
|
|
evalContext.IsTestRun = true
|
|
|
|
tags := make([]string, 0)
|
|
details := make(map[string]interface{})
|
|
bus.AddHandlerCtx("alerting", func(ctx context.Context, cmd *models.SendWebhookSync) error {
|
|
bodyJSON, err := simplejson.NewJson([]byte(cmd.Body))
|
|
if err == nil {
|
|
tags = bodyJSON.Get("tags").MustStringArray([]string{})
|
|
details = bodyJSON.Get("details").MustMap(map[string]interface{}{})
|
|
}
|
|
return err
|
|
})
|
|
|
|
alertErr := opsgenieNotifier.createAlert(evalContext)
|
|
|
|
So(notifierErr, ShouldBeNil)
|
|
So(alertErr, ShouldBeNil)
|
|
So(tags, ShouldResemble, []string{"keyOnly", "aKey:aValue"})
|
|
So(details, ShouldResemble, map[string]interface{}{"keyOnly": "", "aKey": "aValue", "url": ""})
|
|
})
|
|
})
|
|
})
|
|
}
|