722c414fef
* Encryption: Add support to encrypt/decrypt sjd * Add datasources.Service as a proxy to datasources db operations * Encrypt ds.SecureJsonData before calling SQLStore * Move ds cache code into ds service * Fix tlsmanager tests * Fix pluginproxy tests * Remove some securejsondata.GetEncryptedJsonData usages * Add pluginsettings.Service as a proxy for plugin settings db operations * Add AlertNotificationService as a proxy for alert notification db operations * Remove some securejsondata.GetEncryptedJsonData usages * Remove more securejsondata.GetEncryptedJsonData usages * Fix lint errors * Minor fixes * Remove encryption global functions usages from ngalert * Fix lint errors * Minor fixes * Minor fixes * Remove securejsondata.DecryptedValue usage * Refactor the refactor * Remove securejsondata.DecryptedValue usage * Move securejsondata to migrations package * Move securejsondata to migrations package * Minor fix * Fix integration test * Fix integration tests * Undo undesired changes * Fix tests * Add context.Context into encryption methods * Fix tests * Fix tests * Fix tests * Trigger CI * Fix test * Add names to params of encryption service interface * Remove bus from CacheServiceImpl * Add logging * Add keys to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Add missing key to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Undo changes in markdown files * Fix formatting * Add context to secrets service * Rename decryptSecureJsonData to decryptSecureJsonDataFn * Name args in GetDecryptedValueFn * Add template back to NewAlertmanagerNotifier * Copy GetDecryptedValueFn to ngalert * Add logging to pluginsettings * Fix pluginsettings test Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>
163 lines
4.7 KiB
Go
163 lines
4.7 KiB
Go
package notifiers
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/grafana/grafana/pkg/components/simplejson"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/alerting"
|
|
"github.com/grafana/grafana/pkg/services/encryption/ossencryption"
|
|
"github.com/grafana/grafana/pkg/services/validations"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
)
|
|
|
|
func presenceComparerInt(a, b int64) bool {
|
|
if a == -1 {
|
|
return b != 0
|
|
}
|
|
if b == -1 {
|
|
return a != 0
|
|
}
|
|
return a == b
|
|
}
|
|
func TestVictoropsNotifier(t *testing.T) {
|
|
Convey("Victorops notifier tests", t, func() {
|
|
Convey("Parsing alert notification from settings", func() {
|
|
Convey("empty settings should return error", func() {
|
|
json := `{ }`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
_, err := NewVictoropsNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
|
|
So(err, ShouldNotBeNil)
|
|
})
|
|
|
|
Convey("from settings", func() {
|
|
json := `
|
|
{
|
|
"url": "http://google.com"
|
|
}`
|
|
|
|
settingsJSON, _ := simplejson.NewJson([]byte(json))
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewVictoropsNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
|
|
victoropsNotifier := not.(*VictoropsNotifier)
|
|
|
|
So(err, ShouldBeNil)
|
|
So(victoropsNotifier.Name, ShouldEqual, "victorops_testing")
|
|
So(victoropsNotifier.Type, ShouldEqual, "victorops")
|
|
So(victoropsNotifier.URL, ShouldEqual, "http://google.com")
|
|
})
|
|
|
|
Convey("should return properly formatted event payload when using severity override tag", func() {
|
|
json := `
|
|
{
|
|
"url": "http://google.com"
|
|
}`
|
|
|
|
settingsJSON, err := simplejson.NewJson([]byte(json))
|
|
So(err, ShouldBeNil)
|
|
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewVictoropsNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
|
|
So(err, ShouldBeNil)
|
|
|
|
victoropsNotifier := not.(*VictoropsNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateAlerting,
|
|
AlertRuleTags: []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "severity", Value: "warning"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
evalContext.IsTestRun = true
|
|
|
|
payload, err := victoropsNotifier.buildEventPayload(evalContext)
|
|
So(err, ShouldBeNil)
|
|
|
|
diff := cmp.Diff(map[string]interface{}{
|
|
"alert_url": "",
|
|
"entity_display_name": "[Alerting] someRule",
|
|
"entity_id": "someRule",
|
|
"message_type": "WARNING",
|
|
"metrics": map[string]interface{}{},
|
|
"monitoring_tool": "Grafana v",
|
|
"state_message": "someMessage",
|
|
"state_start_time": int64(-1),
|
|
"timestamp": int64(-1),
|
|
}, payload.Interface(), cmp.Comparer(presenceComparerInt))
|
|
So(diff, ShouldBeEmpty)
|
|
})
|
|
Convey("resolving with severity works properly", func() {
|
|
json := `
|
|
{
|
|
"url": "http://google.com"
|
|
}`
|
|
|
|
settingsJSON, err := simplejson.NewJson([]byte(json))
|
|
So(err, ShouldBeNil)
|
|
|
|
model := &models.AlertNotification{
|
|
Name: "victorops_testing",
|
|
Type: "victorops",
|
|
Settings: settingsJSON,
|
|
}
|
|
|
|
not, err := NewVictoropsNotifier(model, ossencryption.ProvideService().GetDecryptedValue)
|
|
So(err, ShouldBeNil)
|
|
|
|
victoropsNotifier := not.(*VictoropsNotifier)
|
|
|
|
evalContext := alerting.NewEvalContext(context.Background(), &alerting.Rule{
|
|
ID: 0,
|
|
Name: "someRule",
|
|
Message: "someMessage",
|
|
State: models.AlertStateOK,
|
|
AlertRuleTags: []*models.Tag{
|
|
{Key: "keyOnly"},
|
|
{Key: "severity", Value: "warning"},
|
|
},
|
|
}, &validations.OSSPluginRequestValidator{})
|
|
evalContext.IsTestRun = true
|
|
|
|
payload, err := victoropsNotifier.buildEventPayload(evalContext)
|
|
So(err, ShouldBeNil)
|
|
|
|
diff := cmp.Diff(map[string]interface{}{
|
|
"alert_url": "",
|
|
"entity_display_name": "[OK] someRule",
|
|
"entity_id": "someRule",
|
|
"message_type": "RECOVERY",
|
|
"metrics": map[string]interface{}{},
|
|
"monitoring_tool": "Grafana v",
|
|
"state_message": "someMessage",
|
|
"state_start_time": int64(-1),
|
|
"timestamp": int64(-1),
|
|
}, payload.Interface(), cmp.Comparer(presenceComparerInt))
|
|
So(diff, ShouldBeEmpty)
|
|
})
|
|
})
|
|
})
|
|
}
|